Re: [PATCH v3] hv/hv_kvp_daemon: Add support for keyfile config based connection profile in NM

Shradha Gupta
2023-08-08T17:47:14Z

On Tue, Aug 08, 2023 at 10:41:21AM +0530, Ani Sinha wrote:
>
>
> > On 12-Jul-2023, at 12:32 PM, Ani Sinha <anisinha@redhat.com> wrote:
> >
> >
> >
> >> On 23-May-2023, at 11:06 AM, Shradha Gupta <shradhagupta@linux.microsoft.com> wrote:
> >>
> >> On Mon, May 08, 2023 at 05:16:19PM +0000, Wei Liu wrote:
> >>> On Mon, May 08, 2023 at 07:12:46PM +0200, Olaf Hering wrote:
> >>>> Mon, 8 May 2023 16:47:54 +0000 Wei Liu <wei.liu@kernel.org>:
> >>>>
> >>>>> Olaf, is this a reviewed-by from you? :-)
> >>>>
> >>>> Sorry, I did not review the new functionality, just tried to make sure there will be no regression for existing consumers.
> >>>
> >>> Okay, this is fine, too. Thank you for looking into this.
> >>>
> >>>
> >>>>
> >>>> Olaf
> >>>
> >>
> >> Gentle reminder.
> >>
> >
> > I have a comment about the following change:
> >
> > + error = fprintf(nmfile, "\n[ipv4]\n");
> > + if (error < 0)
> > + goto setval_error;
> > +
> > + if (new_val->dhcp_enabled) {
> > + error = kvp_write_file(nmfile, "method", "", "auto");
> > + if (error < 0)
> > + goto setval_error;
> > + } else {
> > + error = kvp_write_file(nmfile, "method", "", "manual");
> > + if (error < 0)
> > + goto setval_error;
> > + }
> >
> > I think the method equally would apply for ipv6 as it applies for ipv4.
> > We can use https://www.golinuxcloud.com/nmcli-command-examples-cheatsheet-centos-rhel/#18_Disable_IPv6_Address_for_ethernet_connection_IPV6INIT as a reference.
> > So setting the method should be common to both ipv4 and ipv6.
>
> Ping once more ???
> Can anyone comment on the avove and/or review the patchset?
That's correct Ani, this needs to be enabled for ipv6 as well, will send out another version. Thanks for catching this.