From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5AA9DC77B73 for ; Mon, 8 May 2023 14:01:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234115AbjEHOBY (ORCPT ); Mon, 8 May 2023 10:01:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41934 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233475AbjEHOBV (ORCPT ); Mon, 8 May 2023 10:01:21 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E330C348B5; Mon, 8 May 2023 07:01:16 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 78DF962D9B; Mon, 8 May 2023 14:01:16 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4BDCEC433EF; Mon, 8 May 2023 14:01:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1683554475; bh=O8tjsOi+oKea2wipKtbwhwqOEm7vtb389lfsVLc4ECo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Ymgv1cowBjCfDf/5ikYFlNvu2+D2jnmp7vR8c95Fs+X+AO9Z9RAYUOf1OlPwVxept XHDgQUFJxDL98IXbSNLc2U1JKnisBGWsYm51DJ4IHGYzDojlv1On+XTfmI4RPFvvN/ be00CmCOf7hXa1tkn7Ni0VP7Fa4OSn8dnJMw6SZQ= Date: Mon, 8 May 2023 16:01:12 +0200 From: Greg Kroah-Hartman To: Mirsad Goran Todorovac Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, linux-input@vger.kernel.org, Benjamin Tissoires , Jiri Kosina Subject: Re: [BUG] Kmemleak, possibly hiddev_connect(), in 6.3.0+ torvalds tree commit gfc4354c6e5c2 Message-ID: <2023050854-collage-dreamt-660c@gregkh> References: <2023050824-juiciness-catching-9290@gregkh> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <2023050824-juiciness-catching-9290@gregkh> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, May 08, 2023 at 08:51:55AM +0200, Greg Kroah-Hartman wrote: > On Mon, May 08, 2023 at 08:30:07AM +0200, Mirsad Goran Todorovac wrote: > > Hi, > > > > There seems to be a kernel memory leak in the USB keyboard driver. > > > > The leaked memory allocs are 96 and 512 bytes. > > > > The platform is Ubuntu 22.04 LTS on a assembled AMD Ryzen 9 with X670E PG > > Lightning mobo, > > and Genius SlimStar i220 GK-080012 keyboard. > > > > (Logitech M100 HID mouse is not affected by the bug.) > > > > BIOS is: > > > >      *-firmware > >           description: BIOS > >           vendor: American Megatrends International, LLC. > >           physical id: 0 > >           version: 1.21 > >           date: 04/26/2023 > >           size: 64KiB > > > > The kernel is 6.3.0-torvalds--13466-gfc4354c6e5c2. > > > > The keyboard is recognised as Chicony: > > > >                  *-usb > >                       description: Keyboard > >                       product: CHICONY USB Keyboard > >                       vendor: CHICONY > >                       physical id: 2 > >                       bus info: usb@5:2 > >                       logical name: input35 > >                       logical name: /dev/input/event4 > >                       logical name: input35::capslock > >                       logical name: input35::numlock > >                       logical name: input35::scrolllock > >                       logical name: input36 > >                       logical name: /dev/input/event5 > >                       logical name: input37 > >                       logical name: /dev/input/event6 > >                       logical name: input38 > >                       logical name: /dev/input/event8 > >                       version: 2.30 > >                       capabilities: usb-2.00 usb > >                       configuration: driver=usbhid maxpower=100mA > > speed=1Mbit/s > > > > The bug is easily reproduced by unplugging the USB keyboard, waiting about a > > couple of seconds, > > and then reconnect and scan for memory leaks twice. > > > > The kmemleak log is as follows [edited privacy info]: > > > > root@hostname:/home/username# cat /sys/kernel/debug/kmemleak > > unreferenced object 0xffff8dd020037c00 (size 96): > >   comm "systemd-udevd", pid 435, jiffies 4294892550 (age 8909.356s) > >   hex dump (first 32 bytes): > >     5d 8e 4e b9 ff ff ff ff 00 00 00 00 00 00 00 00 ].N............. > >     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................ > >   backtrace: > >     [] __kmem_cache_alloc_node+0x22e/0x2b0 > >     [] kmalloc_trace+0x2e/0xa0 > >     [] class_create+0x29/0x80 > >     [] usb_register_dev+0x1d4/0x2e0 > > As the call to class_create() in this path is now gone in 6.4-rc1, can > you retry that release to see if this is still there or not? No, wait, it's still there, I was looking at a development branch of mine that isn't sent upstream yet. And syzbot just reported the same thing: https://lore.kernel.org/r/00000000000058d15f05fb264013@google.com So something's wrong here, let me dig into it tomorrow when I get a chance... thanks, greg k-h