Re: [PATCH 1/2] lockdep: lock_set_cmp_fn()

kernel test robot
2023-05-09T23:27:04Z

Hi Kent,

kernel test robot noticed the following build errors:

[auto build test ERROR on tip/locking/core]
[cannot apply to linus/master v6.4-rc1 next-20230509]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url: https://github.com/intel-lab-lkp/linux/commits/Kent-Overstreet/bcache-Convert-to-lock_cmp_fn/20230510-040030
base: tip/locking/core
patch link: https://lore.kernel.org/r/20230509195847.1745548-1-kent.overstreet%40linux.dev
patch subject: [PATCH 1/2] lockdep: lock_set_cmp_fn()
config: loongarch-allyesconfig (https://download.01.org/0day-ci/archive/20230510/202305100719.eq9Z9e7H-lkp@intel.com/config)
compiler: loongarch64-linux-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/intel-lab-lkp/linux/commit/f265373c48cadb6f81e032df9893abffc370ab89
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Kent-Overstreet/bcache-Convert-to-lock_cmp_fn/20230510-040030
git checkout f265373c48cadb6f81e032df9893abffc370ab89
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=loongarch olddefconfig
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=loongarch SHELL=/bin/bash drivers/md/ kernel/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@intel.com>
| Link: https://lore.kernel.org/oe-kbuild-all/202305100719.eq9Z9e7H-lkp@intel.com/

All errors (new ones prefixed by >>):

kernel/locking/lockdep.c: In function 'print_chain_keys_chain':
>> kernel/locking/lockdep.c:3592:46: error: passing argument 1 of 'print_lock_name' from incompatible pointer type [-Werror=incompatible-pointer-types]
3592 | print_lock_name(lock_classes + chain_hlock_class_idx(hlock_id));
| ~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
| |
| struct lock_class *
kernel/locking/lockdep.c:732:47: note: expected 'struct held_lock *' but argument is of type 'struct lock_class *'
732 | static void print_lock_name(struct held_lock *hlock, struct lock_class *class)
| ~~~~~~~~~~~~~~~~~~^~~~~
>> kernel/locking/lockdep.c:3592:17: error: too few arguments to function 'print_lock_name'
3592 | print_lock_name(lock_classes + chain_hlock_class_idx(hlock_id));
| ^~~~~~~~~~~~~~~
kernel/locking/lockdep.c:732:13: note: declared here
732 | static void print_lock_name(struct held_lock *hlock, struct lock_class *class)
| ^~~~~~~~~~~~~~~
kernel/locking/lockdep.c: At top level:
kernel/locking/lockdep.c:4898:6: warning: no previous prototype for 'lockdep_set_lock_cmp_fn' [-Wmissing-prototypes]
4898 | void lockdep_set_lock_cmp_fn(struct lockdep_map *lock, lock_cmp_fn cmp_fn,
| ^~~~~~~~~~~~~~~~~~~~~~~
cc1: some warnings being treated as errors

vim +/print_lock_name +3592 kernel/locking/lockdep.c

39e2e173fb1f90 Alfredo Alvarez Fernandez 2016-03-30 3580
39e2e173fb1f90 Alfredo Alvarez Fernandez 2016-03-30 3581 static void print_chain_keys_chain(struct lock_chain *chain)
39e2e173fb1f90 Alfredo Alvarez Fernandez 2016-03-30 3582 {
39e2e173fb1f90 Alfredo Alvarez Fernandez 2016-03-30 3583 int i;
f6ec8829ac9d59 Yuyang Du 2019-05-06 3584 u64 chain_key = INITIAL_CHAIN_KEY;
f611e8cf98ec90 Boqun Feng 2020-08-07 3585 u16 hlock_id;
39e2e173fb1f90 Alfredo Alvarez Fernandez 2016-03-30 3586
39e2e173fb1f90 Alfredo Alvarez Fernandez 2016-03-30 3587 printk("depth: %u\n", chain->depth);
39e2e173fb1f90 Alfredo Alvarez Fernandez 2016-03-30 3588 for (i = 0; i < chain->depth; i++) {
f611e8cf98ec90 Boqun Feng 2020-08-07 3589 hlock_id = chain_hlocks[chain->base + i];
f611e8cf98ec90 Boqun Feng 2020-08-07 3590 chain_key = print_chain_key_iteration(hlock_id, chain_key);
39e2e173fb1f90 Alfredo Alvarez Fernandez 2016-03-30 3591
28df029d53a2fd Cheng Jui Wang 2022-02-10 @3592 print_lock_name(lock_classes + chain_hlock_class_idx(hlock_id));
39e2e173fb1f90 Alfredo Alvarez Fernandez 2016-03-30 3593 printk("\n");
39e2e173fb1f90 Alfredo Alvarez Fernandez 2016-03-30 3594 }
39e2e173fb1f90 Alfredo Alvarez Fernandez 2016-03-30 3595 }
39e2e173fb1f90 Alfredo Alvarez Fernandez 2016-03-30 3596

--
0-DAY CI Kernel Test Service