Re: [PATCH v9.1 01/11] fprobe: Pass return address to the handlers

Masami Hiramatsu
2023-05-09T14:51:32Z

On Fri, 5 May 2023 11:21:34 -0400
Steven Rostedt <rostedt@goodmis.org> wrote:

> On Tue, 2 May 2023 11:17:28 +0900
> "Masami Hiramatsu (Google)" <mhiramat@kernel.org> wrote:
>
> > From: Masami Hiramatsu (Google) <mhiramat@kernel.org>
> >
> > Pass return address as 'ret_ip' to the fprobe entry and return handlers.
>
> The change log tells us "what" but not "why".

Indeed, and thanks, I almost forgot the reason why I introduced it :(
This is actually for fprobe_exit_handler() to pass the return address to
user handler so that the fprobe-events can show the return address correctly.
When I implemented the fprobe-events, I found this was required but splitted
from the main fprobe event patch but forgot to update the description.

Let me update it.

Thank you!

>
> -- Steve
>
> >
> > Signed-off-by: Masami Hiramatsu (Google) <mhiramat@kernel.org>
> > ---
> >

--
Masami Hiramatsu (Google) <mhiramat@kernel.org>