Re: [PATCH v1 1/5] iommu/arm-smmu-v3: Move cdtable to arm_smmu_master

Michael Shavit
2023-05-11T16:28:17Z

On Thu, May 11, 2023 at 5:15 AM Jason Gunthorpe <jgg@nvidia.com> wrote:
> As per my remark on the cover letter this seems a bit confusing
> description, but the idea that the CD Table for kernel owned PASID
> list is placed in the 'struct arm_smmu_master' does make sense to me

Ack; glad to hear the idea is well received. I'll rephrase commit
messages for v2.

> This patch seems very big, is there any way to break it into smaller
> steps?

I can add a preparatory patch that defines and allocates the
arm_smmu_master's cd table before this patch starts writing to that cd
table instead of the smmu_domain owned cd table. This doesn't cut down
the patch's size by a significant amount but it's a start. I'll try to
think about it some more but a lot of the other changes in this patch
are pretty tightly coupled.