From: Takashi Sakamoto <o-takashi@sakamocchi.jp>
To: linux1394-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org
Cc: Dan Carpenter <error27@gmail.com>
Subject: Re: [PATCH] firewire: net: fix unexpected release of object for asynchronous request packet
Date: Thu, 11 May 2023 09:08:30 +0900 [thread overview]
Message-ID: <20230511000830.GA796953@workstation> (raw)
In-Reply-To: <20230510031205.782032-1-o-takashi@sakamocchi.jp>
On Wed, May 10, 2023 at 12:12:05PM +0900, Takashi Sakamoto wrote:
> The lifetime of object for asynchronous request packet is now maintained
> by reference counting, while current implementation of firewire-net
> releases the passed object in the handler.
>
> This commit fixes the bug.
>
> Reported-by: Dan Carpenter <error27@gmail.com>
> Link: https://lore.kernel.org/lkml/Y%2Fymx6WZIAlrtjLc@workstation/
> Fixes: 13a55d6bb15f ("firewire: core: use kref structure to maintain lifetime of data for fw_request structure")
> Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
> ---
> drivers/firewire/net.c | 21 +++++++++++----------
> 1 file changed, 11 insertions(+), 10 deletions(-)
The patch is applied to for-linus branch and will be sent to mainline
within a few days.
Regards
Takashi Sakamoto
prev parent reply other threads:[~2023-05-11 0:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-10 3:12 [PATCH] firewire: net: fix unexpected release of object for asynchronous request packet Takashi Sakamoto
2023-05-11 0:08 ` Takashi Sakamoto [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230511000830.GA796953@workstation \
--to=o-takashi@sakamocchi.jp \
--cc=error27@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux1394-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox