From: Jakub Kicinski <kuba@kernel.org>
To: Georgi Valkov <gvalkov@abv.bg>
Cc: Greg KH <gregkh@linuxfoundation.org>,
Foster Snowhill <forst@pen.gy>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Jan Kiszka <jan.kiszka@siemens.com>
Subject: Re: net: usb: ipheth: add CDC NCM support
Date: Thu, 11 May 2023 07:40:23 -0700 [thread overview]
Message-ID: <20230511074023.5217e972@kernel.org> (raw)
In-Reply-To: <0A1C2108-75F2-46B7-8712-616FE6464294@abv.bg>
On Thu, 11 May 2023 12:47:56 +0300 Georgi Valkov wrote:
> Can you please review, and accept the following patch. I’ve been using it for one year.
> I added the author Foster Snowhill to this mail, as well as a link to his Github [1].
> If needed, we can ask him to add the tag Signed-off-by:
>
>
> From 257d843a7f90e4e519635f82fe5b73fba918ec33 Mon Sep 17 00:00:00 2001
> From: Foster Snowhill <Forst@users.noreply.github.com>
> Date: Fri, 22 Apr 2022 23:50:09 +0200
> Subject: [PATCH] net: usb: ipheth: add CDC NCM support (PoC)
>
> Recent iOS releases support CDC NCM encapsulation on RX. This mode is
> the default on macOS and Windows.
>
> When reconnecting a device from a macOS/Windows machine to a Linux
> machine, the device stays in NCM mode. Therefore to correctly support
> such a device, the driver has to either support the NCM mode too, or
> somehow put the device back into legacy mode.
>
> To match the behaviour of the macOS/Windows driver, and since there
> are no documented control commands to revert to legacy mode, I chose
> to implement basic NCM support.
>
> With this change, the device is attempted to be put into NCM mode by
> default, and falls back to legacy mode if said attempt failed.
>
> Tested-by: Georgi Valkov <gvalkov@abv.bg>
Take a look at submitting patches, the best way to send a change is
with git send-mail. And make sure you CC the right lists
(./scripts/get_maintainer.pl)
prev parent reply other threads:[~2023-05-11 14:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-11 9:47 net: usb: ipheth: add CDC NCM support Georgi Valkov
2023-05-11 12:02 ` Forst
2023-05-11 12:58 ` Jan Kiszka
2023-05-11 14:40 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230511074023.5217e972@kernel.org \
--to=kuba@kernel.org \
--cc=forst@pen.gy \
--cc=gregkh@linuxfoundation.org \
--cc=gvalkov@abv.bg \
--cc=jan.kiszka@siemens.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox