From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3B9F9C7EE22 for ; Thu, 11 May 2023 14:45:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238388AbjEKOpL (ORCPT ); Thu, 11 May 2023 10:45:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36230 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238061AbjEKOoZ (ORCPT ); Thu, 11 May 2023 10:44:25 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 28142106E6 for ; Thu, 11 May 2023 07:40:26 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id B1F5464E5F for ; Thu, 11 May 2023 14:40:25 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DE1E5C433EF; Thu, 11 May 2023 14:40:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1683816025; bh=lhI97CHH+r3JLmZwQJ+lLCcnnkyzDi2iG/AZXvbQjXs=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=ZdBmPpHIb8oTFwPtVIEBrQYjKulFQ1kqFvAU/1y0pI/YnrmjrbnhcwFtHauRSfVK0 /XseV5P7UuUg6bPX0HHU+0tidaa0C9WejyTgx7aDDDKmyvfn173UsQbizB/G1E364I D2G0tNBR8XiKfKjvhVIq10rtGfbapR9/6wnJITsh212J4t/mQ8PJxwkolh1XqlY1FK TuT89fjKxpktCG90Gf860PxN35BAd7s+jvV/pBNal/zdWFpkVf/dK3h1rqFLjH77Qo nmncdrXyFyzXmhLwzQL4VNi9M7z3gt7tNAdapUtTamYssWfk9ROsaCxY9t/2HU+oHA cs0aEz0lR/2ow== Date: Thu, 11 May 2023 07:40:23 -0700 From: Jakub Kicinski To: Georgi Valkov Cc: Greg KH , Foster Snowhill , Linux Kernel Mailing List , Jan Kiszka Subject: Re: net: usb: ipheth: add CDC NCM support Message-ID: <20230511074023.5217e972@kernel.org> In-Reply-To: <0A1C2108-75F2-46B7-8712-616FE6464294@abv.bg> References: <0A1C2108-75F2-46B7-8712-616FE6464294@abv.bg> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 11 May 2023 12:47:56 +0300 Georgi Valkov wrote: > Can you please review, and accept the following patch. I=E2=80=99ve been = using it for one year. > I added the author Foster Snowhill to this mail, as well as a link to his= Github [1]. > If needed, we can ask him to add the tag Signed-off-by: >=20 >=20 > From 257d843a7f90e4e519635f82fe5b73fba918ec33 Mon Sep 17 00:00:00 2001 > From: Foster Snowhill > Date: Fri, 22 Apr 2022 23:50:09 +0200 > Subject: [PATCH] net: usb: ipheth: add CDC NCM support (PoC) >=20 > Recent iOS releases support CDC NCM encapsulation on RX. This mode is > the default on macOS and Windows. >=20 > When reconnecting a device from a macOS/Windows machine to a Linux > machine, the device stays in NCM mode. Therefore to correctly support > such a device, the driver has to either support the NCM mode too, or > somehow put the device back into legacy mode. >=20 > To match the behaviour of the macOS/Windows driver, and since there > are no documented control commands to revert to legacy mode, I chose > to implement basic NCM support. >=20 > With this change, the device is attempted to be put into NCM mode by > default, and falls back to legacy mode if said attempt failed. >=20 > Tested-by: Georgi Valkov Take a look at submitting patches, the best way to send a change is with git send-mail. And make sure you CC the right lists (./scripts/get_maintainer.pl)