From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A2524C77B7F for ; Thu, 11 May 2023 15:21:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238579AbjEKPVa (ORCPT ); Thu, 11 May 2023 11:21:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44874 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238536AbjEKPV0 (ORCPT ); Thu, 11 May 2023 11:21:26 -0400 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EC0A51992; Thu, 11 May 2023 08:21:25 -0700 (PDT) Received: by verein.lst.de (Postfix, from userid 2407) id 6205868D08; Thu, 11 May 2023 17:21:23 +0200 (CEST) Date: Thu, 11 May 2023 17:21:23 +0200 From: Christoph Hellwig To: Yu Kuai Cc: hch@lst.de, tj@kernel.org, josef@toxicpanda.com, axboe@kernel.dk, yukuai3@huawei.com, cgroups@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, yi.zhang@huawei.com, yangerkun@huawei.com Subject: Re: [PATCH -next 3/6] blk-wbt: don't enable wbt for bio based device Message-ID: <20230511152123.GC7880@lst.de> References: <20230511014509.679482-1-yukuai1@huaweicloud.com> <20230511014509.679482-4-yukuai1@huaweicloud.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230511014509.679482-4-yukuai1@huaweicloud.com> User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, May 11, 2023 at 09:45:06AM +0800, Yu Kuai wrote: > From: Yu Kuai > > Because rq_qos only make sense for rq based device. Instead of fail > from sysfs configuration, make wbt sysfs dentry invisible directly. This looks ok, bt I would be better to just have a separate attr group just for blk-mq based devices?