From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6FA14C77B7C for ; Wed, 10 May 2023 23:00:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236701AbjEJXAO (ORCPT ); Wed, 10 May 2023 19:00:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57702 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236637AbjEJXAK (ORCPT ); Wed, 10 May 2023 19:00:10 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 50F0610F5; Wed, 10 May 2023 16:00:09 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id CE7A06412B; Wed, 10 May 2023 23:00:08 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id AE7ADC433D2; Wed, 10 May 2023 23:00:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1683759608; bh=umzHISqoAA36LPmJRWW/Sw6ophSwcJtyqSKYG5+yMhU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=07sNrAtFgYqFz9UVmlng4DV2f2e8k8dAG8FdWXwcI+yE7wmsuJx44JjtTJ6YU48h6 qPWiTPTbyJOr6mra8d2033pU0+aYCas5+EIgvxp/hl2pTzPcU637DKS1FPmhdBm21Z WRpjQqB64LRJQXNgS+X7BaRmb6y7gl4XKTQYqsmU= Date: Thu, 11 May 2023 08:00:00 +0900 From: Greg Kroah-Hartman To: Rudi Heitbaum Cc: stable@vger.kernel.org, patches@lists.linux.dev, linux-kernel@vger.kernel.org, torvalds@linux-foundation.org, akpm@linux-foundation.org, linux@roeck-us.net, shuah@kernel.org, patches@kernelci.org, lkft-triage@lists.linaro.org, pavel@denx.de, jonathanh@nvidia.com, f.fainelli@gmail.com, sudipm.mukherjee@gmail.com, srw@sladewatkins.net, rwarsow@gmx.de, ntfs3@lists.linux.dev, almaz.alexandrovich@paragon-software.com Subject: Re: [PATCH 6.3 000/694] 6.3.2-rc2 review Message-ID: <2023051132-dweller-upturned-b446@gregkh> References: <20230509030705.399628514@linuxfoundation.org> <20230509080658.GA152864@d6921c044a31> <20230509131032.GA8@9ed91d9f7b3c> <2023050913-spearhead-angrily-fc58@gregkh> <20230509145806.GA8@df3c0d7ae0b0> <2023051025-plug-willow-e278@gregkh> <2023051048-plus-mountable-6280@gregkh> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 10, 2023 at 09:58:06PM +1000, Rudi Heitbaum wrote: > On Wed, 10 May 2023 at 19:09, Greg Kroah-Hartman > wrote: > > > > On Wed, May 10, 2023 at 06:29:23PM +1000, Rudi Heitbaum wrote: > > > On Wed, 10 May 2023 at 17:25, Greg Kroah-Hartman > > > wrote: > > > > > > > > On Tue, May 09, 2023 at 02:58:06PM +0000, Rudi Heitbaum wrote: > > > > > On Tue, May 09, 2023 at 03:56:42PM +0200, Greg Kroah-Hartman wrote: > > > > > > On Tue, May 09, 2023 at 01:10:32PM +0000, Rudi Heitbaum wrote: > > > > > > > On Tue, May 09, 2023 at 08:06:58AM +0000, Rudi Heitbaum wrote: > > > > > > > > On Tue, May 09, 2023 at 05:26:44AM +0200, Greg Kroah-Hartman wrote: > > > > > > > > > This is the start of the stable review cycle for the 6.3.2 release. > > > > > > > > > There are 694 patches in this series, all will be posted as a response > > > > > > > > > to this one. If anyone has any issues with these being applied, please > > > > > > > > > let me know. > > > > > > > > > > > > > > > > > > Responses should be made by Thu, 11 May 2023 03:05:05 +0000. > > > > > > > > > Anything received after that time might be too late. > > > > > > > > > > > > > > > > Hi Greg, > > > > > > > > > > > > > > > > 6.3.2-rc2 tested. > > > > > > > > > > > > > > Hi Greg, > > > > > > > > > > > > > > Further testing and have seen ntfs3: NULL pointer dereference with ntfs_lookup errors > > > > > > > with 6.3.2-rc2 (I have not seen this error before.) No other errors in the logs. > > > > > > > > > > > > Can you reproduce this without the extern, gpl-violation module loaded? > > > > > > > > > > > > thanks, > > > > > > > > > > > > greg k-h > > > > > > > > > > Hi Greg, > > > > > > > > > > I dropped the bcm_sta and recompiled and commented out the i915.guc=3 > > > > > and was able to reproduce. > > > > > > > > > > [ 84.745080] BUG: kernel NULL pointer dereference, address: 0000000000000020 > > > > > [ 84.746239] #PF: supervisor read access in kernel mode > > > > > [ 84.747599] #PF: error_code(0x0000) - not-present page > > > > > [ 84.748929] PGD 0 P4D 0 > > > > > [ 84.750240] Oops: 0000 [#1] SMP NOPTI > > > > > [ 84.751575] CPU: 2 PID: 3176 Comm: .NET ThreadPool Not tainted 6.3.2-rc2 #1 > > > > > [ 84.752998] Hardware name: Intel(R) Client Systems NUC12WSKi7/NUC12WSBi7, BIOS WSADL357.0085.2022.0718.1739 07/18/2022 > > > > > [ 84.754474] RIP: 0010:ntfs_lookup+0x76/0xe0 [ntfs3] > > > > > > > > And do you get this same crash on ntfs3 on 6.4-rc1? Is this a new > > > > regression, or does it also show up on 6.3.1? > > > > > > Tested with 6.3.1 during the day today. No errors, and had been > > > running 6.3.1 with no issue. Retested with 6.3.2-rc2 and problem > > > immediately evident. So yes - I believe a regression. > > > > > > I have built and am now testing 6.4.0-rc1 this evening - no errors so far. > > > > > > [ 0.000000] Linux version 6.4.0-rc1 (docker@1ccd349e2545) > > > (x86_64-libreelec-linux-gnu-gcc-13.1.0 (GCC) 13.1.0, GNU ld (GNU > > > Binutils) 2.40) #1 SMP Wed May 10 07:51:37 UTC 2023 > > > > > > > And ntfs, ick, why? And .NET? What a combination... > > > > > > Joys of media players. Test device gets to test exfat, ntfs3, .NET, > > > and throw in a compile host/GHA runner to put it through paces. > > > > Yeah, this should work. Thanks for verifying this works on other > > releases. Any chance you can do 'git bisect' to track down the > > offending commit? In looking things over, I don't see anything > > obvious... > > Hi Greg, > > I can confirm the offending commit in 6.3.2-rc2 is > > bf11fd528a97 fs/ntfs3: Fix null-ptr-deref on inode->i_op in ntfs_lookup() Thanks! Odd that this didn't show up for you on the other stable -rc releases, as that commit is also in those trees. I'll go revert this for now and ask the maintainer to send a fixed version. thanks, greg k-h