* [PATCH] nbd: Fix debugfs_create_dir error checking
@ 2023-05-12 13:05 Ivan Orlov
2023-05-12 15:09 ` Jens Axboe
0 siblings, 1 reply; 2+ messages in thread
From: Ivan Orlov @ 2023-05-12 13:05 UTC (permalink / raw)
To: josef, axboe
Cc: Ivan Orlov, linux-block, nbd, linux-kernel, skhan, himadrispandya,
linux-kernel-mentees
The debugfs_create_dir function returns ERR_PTR in case of error, and the
only correct way to check if an error occurred is 'IS_ERR' inline function.
This patch will replace the null-comparison with IS_ERR.
Signed-off-by: Ivan Orlov <ivan.orlov0322@gmail.com>
---
drivers/block/nbd.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/block/nbd.c b/drivers/block/nbd.c
index 9c35c958f2c8..65ecde3e2a5b 100644
--- a/drivers/block/nbd.c
+++ b/drivers/block/nbd.c
@@ -1666,7 +1666,7 @@ static int nbd_dev_dbg_init(struct nbd_device *nbd)
return -EIO;
dir = debugfs_create_dir(nbd_name(nbd), nbd_dbg_dir);
- if (!dir) {
+ if (IS_ERR(dir)) {
dev_err(nbd_to_dev(nbd), "Failed to create debugfs dir for '%s'\n",
nbd_name(nbd));
return -EIO;
@@ -1692,7 +1692,7 @@ static int nbd_dbg_init(void)
struct dentry *dbg_dir;
dbg_dir = debugfs_create_dir("nbd", NULL);
- if (!dbg_dir)
+ if (IS_ERR(dbg_dir))
return -EIO;
nbd_dbg_dir = dbg_dir;
--
2.34.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] nbd: Fix debugfs_create_dir error checking
2023-05-12 13:05 [PATCH] nbd: Fix debugfs_create_dir error checking Ivan Orlov
@ 2023-05-12 15:09 ` Jens Axboe
0 siblings, 0 replies; 2+ messages in thread
From: Jens Axboe @ 2023-05-12 15:09 UTC (permalink / raw)
To: josef, Ivan Orlov
Cc: linux-block, nbd, linux-kernel, skhan, himadrispandya,
linux-kernel-mentees
On Fri, 12 May 2023 17:05:32 +0400, Ivan Orlov wrote:
> The debugfs_create_dir function returns ERR_PTR in case of error, and the
> only correct way to check if an error occurred is 'IS_ERR' inline function.
> This patch will replace the null-comparison with IS_ERR.
>
>
Applied, thanks!
[1/1] nbd: Fix debugfs_create_dir error checking
commit: 4913cfcf014c95f0437db2df1734472fd3e15098
Best regards,
--
Jens Axboe
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-05-12 15:09 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-05-12 13:05 [PATCH] nbd: Fix debugfs_create_dir error checking Ivan Orlov
2023-05-12 15:09 ` Jens Axboe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox