public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Bagas Sanjaya <bagasdotme@gmail.com>
Cc: "Linux SPDX Licenses" <linux-spdx@vger.kernel.org>,
	"Linux DRI Development" <dri-devel@lists.freedesktop.org>,
	"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
	"Linux Networking" <netdev@vger.kernel.org>,
	"Linux ARM" <linux-arm-kernel@lists.infradead.org>,
	"Linux Staging Drivers" <linux-staging@lists.linux.dev>,
	"Linux Watchdog Devices" <linux-watchdog@vger.kernel.org>,
	"Linux Kernel Actions" <linux-actions@lists.infradead.org>,
	"Diederik de Haas" <didi.debian@cknow.org>,
	"Kate Stewart" <kstewart@linuxfoundation.org>,
	"Philippe Ombredanne" <pombredanne@nexb.com>,
	"Thomas Gleixner" <tglx@linutronix.de>,
	"David Airlie" <airlied@redhat.com>,
	"Karsten Keil" <isdn@linux-pingi.de>,
	"Jay Vosburgh" <j.vosburgh@gmail.com>,
	"Andy Gospodarek" <andy@greyhouse.net>,
	"David S. Miller" <davem@davemloft.net>,
	"Eric Dumazet" <edumazet@google.com>,
	"Jakub Kicinski" <kuba@kernel.org>,
	"Paolo Abeni" <pabeni@redhat.com>,
	"Sam Creasey" <sammy@sammy.net>,
	"Dominik Brodowski" <linux@dominikbrodowski.net>,
	"Daniel Mack" <daniel@zonque.org>,
	"Haojian Zhuang" <haojian.zhuang@gmail.com>,
	"Robert Jarzmik" <robert.jarzmik@free.fr>,
	"Wim Van Sebroeck" <wim@linux-watchdog.org>,
	"Guenter Roeck" <linux@roeck-us.net>, "Jan Kara" <jack@suse.com>,
	"Andreas Färber" <afaerber@suse.de>,
	"Manivannan Sadhasivam" <mani@kernel.org>
Subject: Re: [PATCH v2 00/10] Treewide GPL SPDX conversion and cleanup (in response to Didi's GPL full name fixes)
Date: Fri, 12 May 2023 20:23:37 +0900	[thread overview]
Message-ID: <2023051243-bunch-goliath-7380@gregkh> (raw)
In-Reply-To: <20230512100620.36807-1-bagasdotme@gmail.com>

On Fri, May 12, 2023 at 05:06:11PM +0700, Bagas Sanjaya wrote:
> I trigger this patch series as a response to Didi's GPL full name fix
> patches [1], for which all of them had been NAKed. In many cases, the
> appropriate correction is to use SPDX license identifier instead.
> 
> Often, when replacing license notice boilerplates with their equivalent
> SPDX identifier, the notice doesn't mention explicit GPL version. Greg
> [2] replied this question by falling back to GPL 1.0 (more precisely
> GPL 1.0+ in order to be compatible with GPL 2.0 used by Linux kernel),
> although there are exceptions (mostly resolved by inferring from
> older patches covering similar situation).
> 
> The series covers the same directories touched as Didi's ones, minus
> Documentation/ (as should have been inferred by SPDX tags on respective
> docs).
>

I'm glad to take these types of changes through the SPDX tree, but
please break them up into smaller changes that show the justification
for each type of change in each subsystem, so that we can evaluate them
on an individual basis.  As you did here, you are lumping things
together only by the existance of the file in the tree, not by the
logical type of change happening, which isn't ok.

Also, you can send them as subsystem-specific series, so as to not have
to cross-post all of the changes all over the place.  I doubt the drm
developers care about ethernet driver license issues :)

thanks,

greg k-h

  parent reply	other threads:[~2023-05-12 11:23 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-12 10:06 [PATCH v2 00/10] Treewide GPL SPDX conversion and cleanup (in response to Didi's GPL full name fixes) Bagas Sanjaya
2023-05-12 10:06 ` [PATCH v2 01/10] agp/amd64: Remove GPL distribution notice Bagas Sanjaya
2023-05-12 10:06 ` [PATCH v2 02/10] mISDN: Replace GPL notice boilerplate with SPDX identifier Bagas Sanjaya
2023-05-12 10:06 ` [PATCH v2 03/10] net: bonding: Add SPDX identifier to remaining files Bagas Sanjaya
2023-05-12 10:06 ` [PATCH v2 04/10] net: ethernet: 8390: Replace GPL boilerplate with SPDX identifier Bagas Sanjaya
2023-05-12 11:27   ` Geert Uytterhoeven
2023-05-12 13:03   ` Richard Fontana
2023-05-12 10:06 ` [PATCH v2 05/10] net: ethernet: i825xx: " Bagas Sanjaya
2023-05-12 11:21   ` Greg Kroah-Hartman
2023-05-12 10:06 ` [PATCH v2 06/10] pcmcia: Add " Bagas Sanjaya
2023-05-12 10:06 ` [PATCH v2 07/10] drivers: staging: wlan-ng: Remove GPL/MPL boilerplate Bagas Sanjaya
2023-05-12 10:06 ` [PATCH v2 08/10] drivers: watchdog: Replace GPL license notice with SPDX identifier Bagas Sanjaya
2023-05-12 12:46   ` Richard Fontana
2023-05-13 10:52     ` Bagas Sanjaya
2023-05-13 13:43       ` Richard Fontana
2023-05-13 15:07         ` Greg Kroah-Hartman
2023-05-14 13:08           ` Guenter Roeck
2023-05-12 12:49   ` Guenter Roeck
2023-05-12 12:50   ` Bagas Sanjaya
2023-05-12 13:14   ` Andreas Färber
2023-05-12 10:06 ` [PATCH v2 09/10] udf: Replace " Bagas Sanjaya
2023-05-12 13:21   ` Richard Fontana
2023-05-13  9:31     ` Bagas Sanjaya
2023-05-13  9:48   ` Pali Rohár
2023-05-13  9:59     ` Greg Kroah-Hartman
2023-05-12 10:06 ` [PATCH v2 10/10] include: synclink: Replace GPL " Bagas Sanjaya
2023-05-12 11:23 ` Greg Kroah-Hartman [this message]
2023-05-13  9:25   ` [PATCH v2 00/10] Treewide GPL SPDX conversion and cleanup (in response to Didi's GPL full name fixes) Bagas Sanjaya

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2023051243-bunch-goliath-7380@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=afaerber@suse.de \
    --cc=airlied@redhat.com \
    --cc=andy@greyhouse.net \
    --cc=bagasdotme@gmail.com \
    --cc=daniel@zonque.org \
    --cc=davem@davemloft.net \
    --cc=didi.debian@cknow.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=edumazet@google.com \
    --cc=haojian.zhuang@gmail.com \
    --cc=isdn@linux-pingi.de \
    --cc=j.vosburgh@gmail.com \
    --cc=jack@suse.com \
    --cc=kstewart@linuxfoundation.org \
    --cc=kuba@kernel.org \
    --cc=linux-actions@lists.infradead.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-spdx@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=linux-watchdog@vger.kernel.org \
    --cc=linux@dominikbrodowski.net \
    --cc=linux@roeck-us.net \
    --cc=mani@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=pombredanne@nexb.com \
    --cc=robert.jarzmik@free.fr \
    --cc=sammy@sammy.net \
    --cc=tglx@linutronix.de \
    --cc=wim@linux-watchdog.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox