From: Shawn Guo <shawnguo@kernel.org>
To: Adam Ford <aford173@gmail.com>
Cc: linux-arm-kernel@lists.infradead.org, aford@beaconembedded.com,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
NXP Linux Team <linux-imx@nxp.com>, Marek Vasut <marex@denx.de>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH V2] arm64: dts: imx8mn: Fix video clock parents
Date: Sun, 14 May 2023 20:32:53 +0800 [thread overview]
Message-ID: <20230514123253.GS727834@dragon> (raw)
In-Reply-To: <CAHCN7x+evo1mJaBUdx5pe5rnG2A8dkmf4myXJcK7mas7nZMwxg@mail.gmail.com>
On Sat, May 13, 2023 at 11:23:04PM -0500, Adam Ford wrote:
> On Sat, May 13, 2023 at 10:58 PM Shawn Guo <shawnguo@kernel.org> wrote:
> >
> > On Sun, Apr 23, 2023 at 07:35:13AM -0500, Adam Ford wrote:
> > > There are a few clocks whose parents are set in mipi_dsi
> > > and mxsfb nodes, but these clocks are used by the disp_blk_ctrl
> > > power domain which may cause an issue when re-parenting, resuling
> > > in a disp_pixel clock having the wrong parent and wrong rate.
> > >
> > > Fix this by moving the assigned-clock-parents as associate clock
> > > assignments to the power-domain node to setup these clocks before
> > > they are enabled.
> > >
> > > Fixes: d825fb6455d5 ("arm64: dts: imx8mn: Add display pipeline components")
> > > Signed-off-by: Adam Ford <aford173@gmail.com>
> >
> > Is it a fix for v6.4-rc or material for -next?
>
> The Samsung DSI driver for Nano is in 6.4, and an attempt was made to
> setup the device tree in 6.4. While I don't think there are users of
> this yet, if people try to add DT entries in their boards, they might
> struggle getting the video working if this isn't applied since the
> disp1_pix clock may be stuck at 24MHz which likely won't sync much if
> any displays.
Ok, applied for v6.4-rc, thanks!
prev parent reply other threads:[~2023-05-14 12:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-23 12:35 [PATCH V2] arm64: dts: imx8mn: Fix video clock parents Adam Ford
2023-05-06 0:37 ` Adam Ford
2023-05-14 3:58 ` Shawn Guo
2023-05-14 4:23 ` Adam Ford
2023-05-14 12:32 ` Shawn Guo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230514123253.GS727834@dragon \
--to=shawnguo@kernel.org \
--cc=aford173@gmail.com \
--cc=aford@beaconembedded.com \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=marex@denx.de \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox