* [PATCH 1/2] dt-bindings: arm: fsl: Add i.MX8MM-EVKB
2023-05-03 15:20 [PATCH 0/2] Add i.MX8MM-EVKB Support Marco Felsch
@ 2023-05-03 15:20 ` Marco Felsch
2023-05-03 16:10 ` Krzysztof Kozlowski
2023-05-03 15:20 ` [PATCH 2/2] arm64: dts: add NXP i.MX8MM-EVKB support Marco Felsch
2023-05-14 13:07 ` [PATCH 0/2] Add i.MX8MM-EVKB Support Shawn Guo
2 siblings, 1 reply; 6+ messages in thread
From: Marco Felsch @ 2023-05-03 15:20 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Shawn Guo, Li Yang,
Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
NXP Linux Team
Cc: devicetree, linux-kernel, linux-arm-kernel, Johannes Schneider
From: Johannes Schneider <johannes.schneider@leica-geosystems.com>
Add DT compatible for the imx8mm EVKB [1].
[1] https://www.nxp.com/design/development-boards/ \
i-mx-evaluation-and-development-boards/ \
evaluation-kit-for-the-i-mx-8m-mini-applications-processor:8MMINILPD4-EVK
Signed-off-by: Johannes Schneider <johannes.schneider@leica-geosystems.com>
[m.felsch@pengutronix.de: Adapt the commit message]
[m.felsch@pengutronix.de: Adapt the yaml comment]
Signed-off-by: Marco Felsch <m.felsch@pengutronix.de>
---
Documentation/devicetree/bindings/arm/fsl.yaml | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml
index 442ce8f4d675..446f71b7b798 100644
--- a/Documentation/devicetree/bindings/arm/fsl.yaml
+++ b/Documentation/devicetree/bindings/arm/fsl.yaml
@@ -887,6 +887,7 @@ properties:
- emtrion,emcon-mx8mm-avari # emCON-MX8MM SoM on Avari Base
- fsl,imx8mm-ddr4-evk # i.MX8MM DDR4 EVK Board
- fsl,imx8mm-evk # i.MX8MM EVK Board
+ - fsl,imx8mm-evkb # i.MX8MM EVKB Board
- gateworks,imx8mm-gw7904
- gw,imx8mm-gw71xx-0x # i.MX8MM Gateworks Development Kit
- gw,imx8mm-gw72xx-0x # i.MX8MM Gateworks Development Kit
--
2.39.2
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH 1/2] dt-bindings: arm: fsl: Add i.MX8MM-EVKB
2023-05-03 15:20 ` [PATCH 1/2] dt-bindings: arm: fsl: Add i.MX8MM-EVKB Marco Felsch
@ 2023-05-03 16:10 ` Krzysztof Kozlowski
2023-05-03 18:51 ` Marco Felsch
0 siblings, 1 reply; 6+ messages in thread
From: Krzysztof Kozlowski @ 2023-05-03 16:10 UTC (permalink / raw)
To: Marco Felsch, Rob Herring, Krzysztof Kozlowski, Shawn Guo,
Li Yang, Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
NXP Linux Team
Cc: devicetree, linux-kernel, linux-arm-kernel, Johannes Schneider
On 03/05/2023 17:20, Marco Felsch wrote:
> From: Johannes Schneider <johannes.schneider@leica-geosystems.com>
>
> Add DT compatible for the imx8mm EVKB [1].
>
> [1] https://www.nxp.com/design/development-boards/ \
> i-mx-evaluation-and-development-boards/ \
> evaluation-kit-for-the-i-mx-8m-mini-applications-processor:8MMINILPD4-EVK
>
> Signed-off-by: Johannes Schneider <johannes.schneider@leica-geosystems.com>
> [m.felsch@pengutronix.de: Adapt the commit message]
> [m.felsch@pengutronix.de: Adapt the yaml comment]
I don't see any differences. The comment is exactly the same as before.
This is a friendly reminder during the review process.
It looks like you received a tag and forgot to add it.
If you do not know the process, here is a short explanation:
Please add Acked-by/Reviewed-by/Tested-by tags when posting new
versions. However, there's no need to repost patches *only* to add the
tags. The upstream maintainer will do that for acks received on the
version they apply.
https://elixir.bootlin.com/linux/v5.17/source/Documentation/process/submitting-patches.rst#L540
If a tag was not added on purpose, please state why and what changed.
Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] dt-bindings: arm: fsl: Add i.MX8MM-EVKB
2023-05-03 16:10 ` Krzysztof Kozlowski
@ 2023-05-03 18:51 ` Marco Felsch
0 siblings, 0 replies; 6+ messages in thread
From: Marco Felsch @ 2023-05-03 18:51 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Rob Herring, Krzysztof Kozlowski, Shawn Guo, Li Yang,
Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
NXP Linux Team, devicetree, linux-kernel, linux-arm-kernel,
Johannes Schneider
On 23-05-03, Krzysztof Kozlowski wrote:
> On 03/05/2023 17:20, Marco Felsch wrote:
> > From: Johannes Schneider <johannes.schneider@leica-geosystems.com>
> >
> > Add DT compatible for the imx8mm EVKB [1].
> >
> > [1] https://www.nxp.com/design/development-boards/ \
> > i-mx-evaluation-and-development-boards/ \
> > evaluation-kit-for-the-i-mx-8m-mini-applications-processor:8MMINILPD4-EVK
> >
> > Signed-off-by: Johannes Schneider <johannes.schneider@leica-geosystems.com>
> > [m.felsch@pengutronix.de: Adapt the commit message]
> > [m.felsch@pengutronix.de: Adapt the yaml comment]
>
> I don't see any differences. The comment is exactly the same as before.
I fogot to say that I used V8 as base which caused problems on Shawns
side and there was a difference.
> This is a friendly reminder during the review process.
>
> It looks like you received a tag and forgot to add it.
>
> If you do not know the process, here is a short explanation:
> Please add Acked-by/Reviewed-by/Tested-by tags when posting new
> versions. However, there's no need to repost patches *only* to add the
> tags. The upstream maintainer will do that for acks received on the
> version they apply.
>
> https://elixir.bootlin.com/linux/v5.17/source/Documentation/process/submitting-patches.rst#L540
>
> If a tag was not added on purpose, please state why and what changed.
As said above..
Regards,
Marco
>
>
> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>
> Best regards,
> Krzysztof
>
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 2/2] arm64: dts: add NXP i.MX8MM-EVKB support
2023-05-03 15:20 [PATCH 0/2] Add i.MX8MM-EVKB Support Marco Felsch
2023-05-03 15:20 ` [PATCH 1/2] dt-bindings: arm: fsl: Add i.MX8MM-EVKB Marco Felsch
@ 2023-05-03 15:20 ` Marco Felsch
2023-05-14 13:07 ` [PATCH 0/2] Add i.MX8MM-EVKB Support Shawn Guo
2 siblings, 0 replies; 6+ messages in thread
From: Marco Felsch @ 2023-05-03 15:20 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Shawn Guo, Li Yang,
Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
NXP Linux Team
Cc: devicetree, linux-kernel, linux-arm-kernel, Johannes Schneider
From: Johannes Schneider <johannes.schneider@leica-geosystems.com>
Add the i.MX8MM-EVKB [1] devicetree support. The EVKB is basically the
same device except for the different used PMIC.
[1] https://www.nxp.com/design/development-boards/ \
i-mx-evaluation-and-development-boards/ \
evaluation-kit-for-the-i-mx-8m-mini-applications-processor:8MMINILPD4-EVK
Signed-off-by: Johannes Schneider <johannes.schneider@leica-geosystems.com>
[m.felsch@pengutronix.de: Adapt the commit message]
[m.felsch@pengutronix.de: Include Shawns feedback]
[m.felsch@pengutronix.de: Fix the regulator settings]
Signed-off-by: Marco Felsch <m.felsch@pengutronix.de>
---
arch/arm64/boot/dts/freescale/Makefile | 1 +
arch/arm64/boot/dts/freescale/imx8mm-evkb.dts | 128 ++++++++++++++++++++++++++
2 files changed, 129 insertions(+)
diff --git a/arch/arm64/boot/dts/freescale/Makefile b/arch/arm64/boot/dts/freescale/Makefile
index 198fff3731ae..a054313761a4 100644
--- a/arch/arm64/boot/dts/freescale/Makefile
+++ b/arch/arm64/boot/dts/freescale/Makefile
@@ -55,6 +55,7 @@ dtb-$(CONFIG_ARCH_MXC) += imx8mm-data-modul-edm-sbc.dtb
dtb-$(CONFIG_ARCH_MXC) += imx8mm-ddr4-evk.dtb
dtb-$(CONFIG_ARCH_MXC) += imx8mm-emcon-avari.dtb
dtb-$(CONFIG_ARCH_MXC) += imx8mm-evk.dtb
+dtb-$(CONFIG_ARCH_MXC) += imx8mm-evkb.dtb
dtb-$(CONFIG_ARCH_MXC) += imx8mm-icore-mx8mm-ctouch2.dtb
dtb-$(CONFIG_ARCH_MXC) += imx8mm-icore-mx8mm-edimm2.2.dtb
dtb-$(CONFIG_ARCH_MXC) += imx8mm-innocomm-wb15-evk.dtb
diff --git a/arch/arm64/boot/dts/freescale/imx8mm-evkb.dts b/arch/arm64/boot/dts/freescale/imx8mm-evkb.dts
new file mode 100644
index 000000000000..164df627a213
--- /dev/null
+++ b/arch/arm64/boot/dts/freescale/imx8mm-evkb.dts
@@ -0,0 +1,128 @@
+// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
+/*
+ * Copyright 2019-2020 NXP
+ */
+
+/dts-v1/;
+
+#include "imx8mm-evk.dtsi"
+
+/ {
+ model = "FSL i.MX8MM EVKB";
+ compatible = "fsl,imx8mm-evkb", "fsl,imx8mm";
+};
+
+&i2c1 {
+ /delete-node/ pmic@4b;
+
+ pmic@25 {
+ compatible = "nxp,pca9450a";
+ reg = <0x25>;
+ pinctrl-0 = <&pinctrl_pmic>;
+ pinctrl-names = "default";
+ interrupt-parent = <&gpio1>;
+ interrupts = <3 IRQ_TYPE_LEVEL_LOW>;
+
+ regulators {
+ /* VDD_SOC with PCIe */
+ buck1_reg: BUCK1 {
+ regulator-name = "BUCK1";
+ regulator-min-microvolt = <850000>;
+ regulator-max-microvolt = <850000>;
+ regulator-boot-on;
+ regulator-always-on;
+ regulator-ramp-delay = <3125>;
+ };
+
+ /* VDD_ARM */
+ buck2_reg: BUCK2 {
+ regulator-name = "BUCK2";
+ regulator-min-microvolt = <850000>;
+ regulator-max-microvolt = <1000000>;
+ regulator-boot-on;
+ regulator-always-on;
+ regulator-ramp-delay = <3125>;
+ nxp,dvs-standby-voltage = <850000>;
+ };
+
+ /* VDD_GPU, VDD_VPU, VDD_DRAM */
+ buck3_reg: BUCK3 {
+ regulator-name = "BUCK3";
+ regulator-min-microvolt = <850000>;
+ regulator-max-microvolt = <1000000>;
+ regulator-boot-on;
+ regulator-always-on;
+ };
+
+ /* NVCC_3V3 */
+ buck4_reg: BUCK4 {
+ regulator-name = "BUCK4";
+ regulator-min-microvolt = <3300000>;
+ regulator-max-microvolt = <3300000>;
+ regulator-boot-on;
+ regulator-always-on;
+ };
+
+ /* VDD_1V8, NVCC_1V8, NVCC_ENET */
+ buck5_reg: BUCK5 {
+ regulator-name = "BUCK5";
+ regulator-min-microvolt = <1800000>;
+ regulator-max-microvolt = <1800000>;
+ regulator-boot-on;
+ regulator-always-on;
+ };
+
+ /* NVCC_DRAM for LPDDR4 */
+ buck6_reg: BUCK6 {
+ regulator-name = "BUCK6";
+ regulator-min-microvolt = <1100000>;
+ regulator-max-microvolt = <1100000>;
+ regulator-boot-on;
+ regulator-always-on;
+ };
+
+ /* NVCC_SNVS_1P8 */
+ ldo1_reg: LDO1 {
+ regulator-name = "LDO1";
+ regulator-min-microvolt = <1800000>;
+ regulator-max-microvolt = <1800000>;
+ regulator-boot-on;
+ regulator-always-on;
+ };
+
+ /* VDD_SNVS_0P8 */
+ ldo2_reg: LDO2 {
+ regulator-name = "LDO2";
+ regulator-min-microvolt = <800000>;
+ regulator-max-microvolt = <800000>;
+ regulator-boot-on;
+ regulator-always-on;
+ };
+
+ /* VDD_*_1V8 */
+ ldo3_reg: LDO3 {
+ regulator-name = "LDO3";
+ regulator-min-microvolt = <1800000>;
+ regulator-max-microvolt = <1800000>;
+ regulator-boot-on;
+ regulator-always-on;
+ };
+
+ /* VDD_PHY_0V9 */
+ ldo4_reg: LDO4 {
+ regulator-name = "LDO4";
+ regulator-min-microvolt = <900000>;
+ regulator-max-microvolt = <900000>;
+ regulator-boot-on;
+ regulator-always-on;
+ };
+
+ /* NVCC_SD2 */
+ ldo5_reg: LDO5 {
+ regulator-name = "LDO5";
+ regulator-min-microvolt = <1800000>;
+ regulator-max-microvolt = <3300000>;
+ };
+ };
+ };
+};
--
2.39.2
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH 0/2] Add i.MX8MM-EVKB Support
2023-05-03 15:20 [PATCH 0/2] Add i.MX8MM-EVKB Support Marco Felsch
2023-05-03 15:20 ` [PATCH 1/2] dt-bindings: arm: fsl: Add i.MX8MM-EVKB Marco Felsch
2023-05-03 15:20 ` [PATCH 2/2] arm64: dts: add NXP i.MX8MM-EVKB support Marco Felsch
@ 2023-05-14 13:07 ` Shawn Guo
2 siblings, 0 replies; 6+ messages in thread
From: Shawn Guo @ 2023-05-14 13:07 UTC (permalink / raw)
To: Marco Felsch
Cc: Rob Herring, Krzysztof Kozlowski, Li Yang, Sascha Hauer,
Pengutronix Kernel Team, Fabio Estevam, NXP Linux Team,
devicetree, linux-kernel, linux-arm-kernel, Johannes Schneider
On Wed, May 03, 2023 at 05:20:03PM +0200, Marco Felsch wrote:
> Hi,
>
> I picked the patch series from Johannes [1] and reworked it according
> the comments and the discussion.
>
> @Krzysztof
> I dropped your ack for the bindings since I adapted the comment within
> this oneliner. Please can you check the current state and provide your
> (n)ack again?
>
> [1] https://lore.kernel.org/all/20230130172553.2738182-1-johannes.schneider@leica-geosystems.com/
>
> ---
> Johannes Schneider (2):
> dt-bindings: arm: fsl: Add i.MX8MM-EVKB
> arm64: dts: add NXP i.MX8MM-EVKB support
Applied both, thanks!
^ permalink raw reply [flat|nested] 6+ messages in thread