From: Kees Cook <keescook@chromium.org>
To: Arnd Bergmann <arnd@kernel.org>
Cc: Sebastian Reichel <sre@kernel.org>,
Carlos Chinea <carlos.chinea@nokia.com>,
Arnd Bergmann <arnd@arndb.de>,
Jianglei Nie <niejianglei2021@163.com>,
Nathan Chancellor <nathan@kernel.org>,
Wang Qing <wangqing@vivo.com>,
Yang Yingliang <yangyingliang@huawei.com>,
Yuan Can <yuancan@huawei.com>, Miaoqian Lin <linmq006@gmail.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] hsi: fix ssi_waketest() declaration
Date: Tue, 16 May 2023 13:30:35 -0700 [thread overview]
Message-ID: <202305161330.FE7311B@keescook> (raw)
In-Reply-To: <20230516202226.559733-1-arnd@kernel.org>
On Tue, May 16, 2023 at 10:22:07PM +0200, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> The ssi_waketest() function definition causes a 'make W=1' warning
> because the declaration is hidden away in ssi_protocol.c:
>
> drivers/hsi/controllers/omap_ssi_core.c:147:6: error: no previous prototype for 'ssi_waketest'
>
> Move it into a header file instead.
>
> Fixes: dc7bf5d71868 ("HSI: Introduce driver for SSI Protocol")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Kees Cook <keescook@chromium.org>
--
Kees Cook
next prev parent reply other threads:[~2023-05-16 20:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-16 20:22 [PATCH] hsi: fix ssi_waketest() declaration Arnd Bergmann
2023-05-16 20:30 ` Kees Cook [this message]
2023-05-20 17:22 ` Sebastian Reichel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202305161330.FE7311B@keescook \
--to=keescook@chromium.org \
--cc=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=carlos.chinea@nokia.com \
--cc=linmq006@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nathan@kernel.org \
--cc=niejianglei2021@163.com \
--cc=sre@kernel.org \
--cc=wangqing@vivo.com \
--cc=yangyingliang@huawei.com \
--cc=yuancan@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox