* [PATCH] hsi: fix ssi_waketest() declaration
@ 2023-05-16 20:22 Arnd Bergmann
2023-05-16 20:30 ` Kees Cook
0 siblings, 1 reply; 3+ messages in thread
From: Arnd Bergmann @ 2023-05-16 20:22 UTC (permalink / raw)
To: Sebastian Reichel, Carlos Chinea
Cc: Arnd Bergmann, Jianglei Nie, Kees Cook, Nathan Chancellor,
Wang Qing, Yang Yingliang, Yuan Can, Miaoqian Lin, linux-kernel
From: Arnd Bergmann <arnd@arndb.de>
The ssi_waketest() function definition causes a 'make W=1' warning
because the declaration is hidden away in ssi_protocol.c:
drivers/hsi/controllers/omap_ssi_core.c:147:6: error: no previous prototype for 'ssi_waketest'
Move it into a header file instead.
Fixes: dc7bf5d71868 ("HSI: Introduce driver for SSI Protocol")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/hsi/clients/ssi_protocol.c | 2 --
drivers/hsi/controllers/omap_ssi_core.c | 1 +
include/linux/hsi/ssi_protocol.h | 1 +
3 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/hsi/clients/ssi_protocol.c b/drivers/hsi/clients/ssi_protocol.c
index 38e572faff43..da6a7abd584f 100644
--- a/drivers/hsi/clients/ssi_protocol.c
+++ b/drivers/hsi/clients/ssi_protocol.c
@@ -32,8 +32,6 @@
#include <linux/hsi/hsi.h>
#include <linux/hsi/ssi_protocol.h>
-void ssi_waketest(struct hsi_client *cl, unsigned int enable);
-
#define SSIP_TXQUEUE_LEN 100
#define SSIP_MAX_MTU 65535
#define SSIP_DEFAULT_MTU 4000
diff --git a/drivers/hsi/controllers/omap_ssi_core.c b/drivers/hsi/controllers/omap_ssi_core.c
index 26f2c3c01297..84ba8b875199 100644
--- a/drivers/hsi/controllers/omap_ssi_core.c
+++ b/drivers/hsi/controllers/omap_ssi_core.c
@@ -17,6 +17,7 @@
#include <linux/dma-mapping.h>
#include <linux/dmaengine.h>
#include <linux/delay.h>
+#include <linux/hsi/ssi_protocol.h>
#include <linux/seq_file.h>
#include <linux/scatterlist.h>
#include <linux/interrupt.h>
diff --git a/include/linux/hsi/ssi_protocol.h b/include/linux/hsi/ssi_protocol.h
index 2d6f3cfa7dea..972434daa000 100644
--- a/include/linux/hsi/ssi_protocol.h
+++ b/include/linux/hsi/ssi_protocol.h
@@ -24,6 +24,7 @@ int ssip_slave_stop_tx(struct hsi_client *master);
void ssip_reset_event(struct hsi_client *master);
int ssip_slave_running(struct hsi_client *master);
+void ssi_waketest(struct hsi_client *cl, unsigned int enable);
#endif /* __LINUX_SSIP_SLAVE_H__ */
--
2.39.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] hsi: fix ssi_waketest() declaration
2023-05-16 20:22 [PATCH] hsi: fix ssi_waketest() declaration Arnd Bergmann
@ 2023-05-16 20:30 ` Kees Cook
2023-05-20 17:22 ` Sebastian Reichel
0 siblings, 1 reply; 3+ messages in thread
From: Kees Cook @ 2023-05-16 20:30 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Sebastian Reichel, Carlos Chinea, Arnd Bergmann, Jianglei Nie,
Nathan Chancellor, Wang Qing, Yang Yingliang, Yuan Can,
Miaoqian Lin, linux-kernel
On Tue, May 16, 2023 at 10:22:07PM +0200, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> The ssi_waketest() function definition causes a 'make W=1' warning
> because the declaration is hidden away in ssi_protocol.c:
>
> drivers/hsi/controllers/omap_ssi_core.c:147:6: error: no previous prototype for 'ssi_waketest'
>
> Move it into a header file instead.
>
> Fixes: dc7bf5d71868 ("HSI: Introduce driver for SSI Protocol")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Kees Cook <keescook@chromium.org>
--
Kees Cook
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] hsi: fix ssi_waketest() declaration
2023-05-16 20:30 ` Kees Cook
@ 2023-05-20 17:22 ` Sebastian Reichel
0 siblings, 0 replies; 3+ messages in thread
From: Sebastian Reichel @ 2023-05-20 17:22 UTC (permalink / raw)
To: Kees Cook
Cc: Arnd Bergmann, Carlos Chinea, Arnd Bergmann, Jianglei Nie,
Nathan Chancellor, Wang Qing, Yang Yingliang, Yuan Can,
Miaoqian Lin, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 681 bytes --]
Hi,
On Tue, May 16, 2023 at 01:30:35PM -0700, Kees Cook wrote:
> On Tue, May 16, 2023 at 10:22:07PM +0200, Arnd Bergmann wrote:
> > From: Arnd Bergmann <arnd@arndb.de>
> >
> > The ssi_waketest() function definition causes a 'make W=1' warning
> > because the declaration is hidden away in ssi_protocol.c:
> >
> > drivers/hsi/controllers/omap_ssi_core.c:147:6: error: no previous prototype for 'ssi_waketest'
> >
> > Move it into a header file instead.
> >
> > Fixes: dc7bf5d71868 ("HSI: Introduce driver for SSI Protocol")
> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>
> Reviewed-by: Kees Cook <keescook@chromium.org>
Thanks, queued.
-- Sebastian
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-05-20 17:24 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-05-16 20:22 [PATCH] hsi: fix ssi_waketest() declaration Arnd Bergmann
2023-05-16 20:30 ` Kees Cook
2023-05-20 17:22 ` Sebastian Reichel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).