From: Joel Granados <j.granados@samsung.com>
To: Luis Chamberlain <mcgrof@kernel.org>
Cc: Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Iurii Zaikin <yzaikin@google.com>,
Kees Cook <keescook@chromium.org>, <linux-kernel@vger.kernel.org>,
<linux-fsdevel@vger.kernel.org>
Subject: Re: [PATCH 0/6] sysctl: Remove register_sysctl_table from parport
Date: Tue, 16 May 2023 16:06:40 +0200 [thread overview]
Message-ID: <20230516140640.il6w54hpbj3zq7lo@localhost> (raw)
In-Reply-To: <ZGKU5vP8Anmfeen0@bombadil.infradead.org>
[-- Attachment #1: Type: text/plain, Size: 1251 bytes --]
On Mon, May 15, 2023 at 01:24:06PM -0700, Luis Chamberlain wrote:
> On Mon, May 15, 2023 at 09:14:40AM +0200, Joel Granados wrote:
> > This is part of the general push to deprecate register_sysctl_paths and
> > register_sysctl_table. Parport driver uses the "CHILD" pointer
> > in the ctl_table structure to create its directory structure. We move to
> > the newer register_sysctl call and remove the pointer madness.
>
> Nice! Thanks for doing this and unwinding the sysctl use case which
> takes the cake for the obfuscation use case of sysctls.
Indeed. They were being very creative :)
>
> > I have separated the parport into 5 patches to clarify the different
> > changes needed for the 3 calls to register_sysctl_paths. I can squash
> > them together if need be.
>
> I think it makes sense to keep them that way.
Fine by me :).
>
> > We no longer export the register_sysctl_table call as parport was the
> > last user from outside proc_sysctl.c. Also modified documentation slightly
> > so register_sysctl_table is no longer mentioned.
>
> We can go further, but I'll explain in patch review on the patches.
ok
>
> > I'm waiting on the 0-day tests results.
>
> Nice!
>
> Luis
--
Joel Granados
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
prev parent reply other threads:[~2023-05-16 14:06 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20230515071448eucas1p111c55b7078f1541f487c9dfb1a9f9c15@eucas1p1.samsung.com>
2023-05-15 7:14 ` [PATCH 0/6] sysctl: Remove register_sysctl_table from parport Joel Granados
2023-05-15 7:14 ` [PATCH 1/6] parport: Move magic number "15" to a define Joel Granados
2023-05-15 7:14 ` [PATCH 2/6] parport: Remove register_sysctl_table from parport_proc_register Joel Granados
2023-05-16 4:17 ` Luis Chamberlain
2023-05-16 14:31 ` Joel Granados
2023-05-16 16:12 ` Joel Granados
2023-05-16 21:49 ` Luis Chamberlain
2023-05-15 7:14 ` [PATCH 3/6] parport: Remove register_sysctl_table from parport_device_proc_register Joel Granados
2023-05-15 19:10 ` Joel Granados
2023-05-15 7:14 ` [PATCH 4/6] parport: Remove register_sysctl_table from parport_default_proc_register Joel Granados
2023-05-15 7:14 ` [PATCH 5/6] parport: Removed sysctl related defines Joel Granados
2023-05-15 7:14 ` [PATCH 6/6] sysctl: stop exporting register_sysctl_table Joel Granados
2023-05-15 20:24 ` [PATCH 0/6] sysctl: Remove register_sysctl_table from parport Luis Chamberlain
2023-05-16 14:06 ` Joel Granados [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230516140640.il6w54hpbj3zq7lo@localhost \
--to=j.granados@samsung.com \
--cc=keescook@chromium.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mcgrof@kernel.org \
--cc=sudipm.mukherjee@gmail.com \
--cc=yzaikin@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox