* [PATCH] remoteproc: qcom: pas: mark adsp_segment_dump() static
@ 2023-05-16 20:23 Arnd Bergmann
2023-05-18 7:47 ` Mukesh Ojha
0 siblings, 1 reply; 2+ messages in thread
From: Arnd Bergmann @ 2023-05-16 20:23 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Mathieu Poirier, Sibi Sankar,
Yogesh Lal
Cc: Arnd Bergmann, Konrad Dybcio, Mukesh Ojha, Neil Armstrong,
Abel Vesa, linux-arm-msm, linux-remoteproc, linux-kernel
From: Arnd Bergmann <arnd@arndb.de>
The function has no other callers and should not be globally defined.
Making it static avoids this warning:
drivers/remoteproc/qcom_q6v5_pas.c:108:6: error: no previous prototype for 'adsp_segment_dump'
Fixes: a376c10d45a8 ("remoteproc: qcom: pas: Adjust the phys addr wrt the mem region")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/remoteproc/qcom_q6v5_pas.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/remoteproc/qcom_q6v5_pas.c b/drivers/remoteproc/qcom_q6v5_pas.c
index e34d82b18a67..a1d69721a0e7 100644
--- a/drivers/remoteproc/qcom_q6v5_pas.c
+++ b/drivers/remoteproc/qcom_q6v5_pas.c
@@ -105,8 +105,9 @@ struct qcom_adsp {
struct qcom_scm_pas_metadata dtb_pas_metadata;
};
-void adsp_segment_dump(struct rproc *rproc, struct rproc_dump_segment *segment,
- void *dest, size_t offset, size_t size)
+static void adsp_segment_dump(struct rproc *rproc,
+ struct rproc_dump_segment *segment,
+ void *dest, size_t offset, size_t size)
{
struct qcom_adsp *adsp = rproc->priv;
int total_offset;
--
2.39.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] remoteproc: qcom: pas: mark adsp_segment_dump() static
2023-05-16 20:23 [PATCH] remoteproc: qcom: pas: mark adsp_segment_dump() static Arnd Bergmann
@ 2023-05-18 7:47 ` Mukesh Ojha
0 siblings, 0 replies; 2+ messages in thread
From: Mukesh Ojha @ 2023-05-18 7:47 UTC (permalink / raw)
To: Arnd Bergmann, Andy Gross, Bjorn Andersson, Mathieu Poirier,
Sibi Sankar, Yogesh Lal
Cc: Arnd Bergmann, Konrad Dybcio, Neil Armstrong, Abel Vesa,
linux-arm-msm, linux-remoteproc, linux-kernel
On 5/17/2023 1:53 AM, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> The function has no other callers and should not be globally defined.
> Making it static avoids this warning:
>
> drivers/remoteproc/qcom_q6v5_pas.c:108:6: error: no previous prototype for 'adsp_segment_dump'
>
> Fixes: a376c10d45a8 ("remoteproc: qcom: pas: Adjust the phys addr wrt the mem region")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
This seems to be posted already
https://lore.kernel.org/lkml/20230507144826.193067-1-krzysztof.kozlowski@linaro.org/
-- Mukesh
> ---
> drivers/remoteproc/qcom_q6v5_pas.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/remoteproc/qcom_q6v5_pas.c b/drivers/remoteproc/qcom_q6v5_pas.c
> index e34d82b18a67..a1d69721a0e7 100644
> --- a/drivers/remoteproc/qcom_q6v5_pas.c
> +++ b/drivers/remoteproc/qcom_q6v5_pas.c
> @@ -105,8 +105,9 @@ struct qcom_adsp {
> struct qcom_scm_pas_metadata dtb_pas_metadata;
> };
>
> -void adsp_segment_dump(struct rproc *rproc, struct rproc_dump_segment *segment,
> - void *dest, size_t offset, size_t size)
> +static void adsp_segment_dump(struct rproc *rproc,
> + struct rproc_dump_segment *segment,
> + void *dest, size_t offset, size_t size)
> {
> struct qcom_adsp *adsp = rproc->priv;
> int total_offset;
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-05-18 7:48 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-05-16 20:23 [PATCH] remoteproc: qcom: pas: mark adsp_segment_dump() static Arnd Bergmann
2023-05-18 7:47 ` Mukesh Ojha
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).