From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0372DC7EE2A for ; Wed, 17 May 2023 18:54:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229809AbjEQSyc (ORCPT ); Wed, 17 May 2023 14:54:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48152 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229789AbjEQSya (ORCPT ); Wed, 17 May 2023 14:54:30 -0400 Received: from mail-pj1-x1030.google.com (mail-pj1-x1030.google.com [IPv6:2607:f8b0:4864:20::1030]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C6CF0134 for ; Wed, 17 May 2023 11:54:28 -0700 (PDT) Received: by mail-pj1-x1030.google.com with SMTP id 98e67ed59e1d1-24de9c66559so948937a91.0 for ; Wed, 17 May 2023 11:54:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1684349668; x=1686941668; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=R54qrXpRXauvJnkZnQVt+Z87JHaYQBFqFu4dbWlWKuU=; b=YOBsq8PP05/w38VDa0SXCGmdQh/1emiGk49qoBF9cz1Jc6Eoas/qpQPA7EbPAmB7S0 aZFk3Z2iHcKzdKa388FofA0Up5h+ZFapgP9NTHcTzV/eRtJZP0CeSe214oQGRChz4F96 88O5wM9zSkZr8bnOxQ3PwNnFIdFUoMaKhUmNk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684349668; x=1686941668; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=R54qrXpRXauvJnkZnQVt+Z87JHaYQBFqFu4dbWlWKuU=; b=X0vgD0B+K/G+kNhNhYD20HiBglbHx6nf5Pyr7Bk8R4O5w9B+QUJ4ZU3r/nlKr+vM3R bOUjUeWfo+nctFc0ua8GuBEUk5TQ3nRq9ZJJF+tR9hUezJh/tpXNvKq728PbGplKreOf 0VRnJNMr9uNxdYCaD4tE9OxfgcKkgvJJDzDzzEM2wq2QVPT58ycyElbYRKKwFM6jijOM EWrUYyTVD4wB1dNfww7IJCp008ezjI5I1QzyZQlY241GQiQBB4GKPAqGw9pMDgwYGMXD a9pWPt2BdMcH8ab8IbLV1c1aMyf0UEOWtAPN0Htts/hgyivW+Yre1Vv1eN9HokBvGOcA tmyw== X-Gm-Message-State: AC+VfDxvClHhKDgGx8YYF1zRuQd0BU4LhYzI3fzgnPIFqYj9xPfGkv7m U7pOy6VczcSJMzGwK86a6dSQtA== X-Google-Smtp-Source: ACHHUZ6+0qmyB748J64aWK2VoC7egUUCgofve5208iCv5bsbGWtl4XBIGCzOemSDxj8LWHRRM1KRTA== X-Received: by 2002:a17:90b:2398:b0:253:3e9d:f92a with SMTP id mr24-20020a17090b239800b002533e9df92amr633903pjb.29.1684349668336; Wed, 17 May 2023 11:54:28 -0700 (PDT) Received: from www.outflux.net (198-0-35-241-static.hfc.comcastbusiness.net. [198.0.35.241]) by smtp.gmail.com with ESMTPSA id om11-20020a17090b3a8b00b0024e268985b1sm1941458pjb.9.2023.05.17.11.54.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 May 2023 11:54:27 -0700 (PDT) Date: Wed, 17 May 2023 11:54:27 -0700 From: Kees Cook To: "Gustavo A. R. Silva" Cc: Stanimir Varbanov , Vikash Garodia , Andy Gross , Bjorn Andersson , Konrad Dybcio , Mauro Carvalho Chehab , linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org Subject: Re: [PATCH][next] media: venus: hfi_cmds: Replace fake flex-arrays with flexible-array members Message-ID: <202305171152.79664B158@keescook> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 16, 2023 at 07:18:01PM -0600, Gustavo A. R. Silva wrote: > One-element arrays are deprecated, and we are replacing them with flexible > array members instead. So, replace one-element arrays with flexible-array > members in multiple structures. > > This helps with the ongoing efforts to tighten the FORTIFY_SOURCE > routines on memcpy() and help us make progress towards globally > enabling -fstrict-flex-arrays=3 [1]. > > This results in no differences in binary output. > > Link: https://github.com/KSPP/linux/issues/79 > Link: https://github.com/KSPP/linux/issues/294 > Link: https://gcc.gnu.org/pipermail/gcc-patches/2022-October/602902.html [1] > Signed-off-by: Gustavo A. R. Silva The subject is very close to the related patch (plural vs non-plural): https://lore.kernel.org/all/e4b13d7b79d1477e775c6d4564f7b23c4cf967f2.1684278538.git.gustavoars@kernel.org/ So it might be nice to name struct hfi_session_set_buffers_pkt specifically in the other patch's subject, but otherwise: Reviewed-by: Kees Cook -- Kees Cook