* [PATCH] kdb: include kdb_private.h for function prototypes
@ 2023-05-17 12:47 Arnd Bergmann
2023-05-17 15:43 ` Doug Anderson
0 siblings, 1 reply; 2+ messages in thread
From: Arnd Bergmann @ 2023-05-17 12:47 UTC (permalink / raw)
To: Jason Wessel, Daniel Thompson
Cc: Arnd Bergmann, Douglas Anderson, kgdb-bugreport, linux-kernel
From: Arnd Bergmann <arnd@arndb.de>
The kdb_kbd_cleanup_state() is called from another file through
the kdb_private.h file, but that is not included before the
definition, causing a W=1 warning:
kernel/debug/kdb/kdb_keyboard.c:198:6: error: no previous prototype for 'kdb_kbd_cleanup_state' [-Werror=missing-prototypes]
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
kernel/debug/kdb/kdb_keyboard.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/kernel/debug/kdb/kdb_keyboard.c b/kernel/debug/kdb/kdb_keyboard.c
index f87c750d3eb3..3c2987f46f6e 100644
--- a/kernel/debug/kdb/kdb_keyboard.c
+++ b/kernel/debug/kdb/kdb_keyboard.c
@@ -13,6 +13,8 @@
#include <linux/ctype.h>
#include <linux/io.h>
+#include "kdb_private.h"
+
/* Keyboard Controller Registers on normal PCs. */
#define KBD_STATUS_REG 0x64 /* Status register (R) */
--
2.39.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] kdb: include kdb_private.h for function prototypes
2023-05-17 12:47 [PATCH] kdb: include kdb_private.h for function prototypes Arnd Bergmann
@ 2023-05-17 15:43 ` Doug Anderson
0 siblings, 0 replies; 2+ messages in thread
From: Doug Anderson @ 2023-05-17 15:43 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Jason Wessel, Daniel Thompson, Arnd Bergmann, kgdb-bugreport,
linux-kernel
Hi,
On Wed, May 17, 2023 at 5:48 AM Arnd Bergmann <arnd@kernel.org> wrote:
>
> From: Arnd Bergmann <arnd@arndb.de>
>
> The kdb_kbd_cleanup_state() is called from another file through
> the kdb_private.h file, but that is not included before the
> definition, causing a W=1 warning:
>
> kernel/debug/kdb/kdb_keyboard.c:198:6: error: no previous prototype for 'kdb_kbd_cleanup_state' [-Werror=missing-prototypes]
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> kernel/debug/kdb/kdb_keyboard.c | 2 ++
> 1 file changed, 2 insertions(+)
Reviewed-by: Douglas Anderson <dianders@chromium.org>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-05-17 15:44 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-05-17 12:47 [PATCH] kdb: include kdb_private.h for function prototypes Arnd Bergmann
2023-05-17 15:43 ` Doug Anderson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox