Re: [PATCH 10/14] suspend: add a arch_resume_nosmt() prototype

Rafael J. Wysocki
2023-05-17T13:48:57Z

On Wed, May 17, 2023 at 3:12 PM Arnd Bergmann <arnd@kernel.org> wrote:
>
> From: Arnd Bergmann <arnd@arndb.de>
>
> The arch_resume_nosmt() has a __weak definition, plus an x86
> specific override, but no prototype that ensures the two have
> the same arguments. This causes a W=1 warning:
>
> arch/x86/power/hibernate.c:189:5: error: no previous prototype for 'arch_resume_nosmt' [-Werror=missing-prototypes]
>
> Add the prototype in linux/suspend.h, which is included in
> both places.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Do you want me to pick this up?

If not

Acked-by: Rafael J. Wysocki <rafael@kernel.org>

> ---
> include/linux/suspend.h | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/include/linux/suspend.h b/include/linux/suspend.h
> index f16653f7be32..bc911fecb8e8 100644
> --- a/include/linux/suspend.h
> +++ b/include/linux/suspend.h
> @@ -472,6 +472,8 @@ static inline int hibernate_quiet_exec(int (*func)(void *data), void *data) {
> }
> #endif /* CONFIG_HIBERNATION */
>
> +int arch_resume_nosmt(void);
> +
> #ifdef CONFIG_HIBERNATION_SNAPSHOT_DEV
> int is_hibernate_resume_dev(dev_t dev);
> #else
> --
> 2.39.2
>