* [PATCH] jffs2: mark __jffs2_dbg_superblock_counts() static
@ 2023-05-17 13:27 Arnd Bergmann
2023-05-17 13:57 ` Tudor Ambarus
0 siblings, 1 reply; 2+ messages in thread
From: Arnd Bergmann @ 2023-05-17 13:27 UTC (permalink / raw)
To: David Woodhouse, Richard Weinberger
Cc: Arnd Bergmann, linux-mtd, linux-kernel
From: Arnd Bergmann <arnd@arndb.de>
This function is only called locally and does not need to be
global. Since there is no external prototype, gcc warns about
the non-static definition:
fs/jffs2/debug.c:160:6: error: no previous prototype for '__jffs2_dbg_superblock_counts' [-Werror=missing-prototypes]
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
fs/jffs2/debug.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/jffs2/debug.c b/fs/jffs2/debug.c
index 9d26b1b9fc01..0925caab23c4 100644
--- a/fs/jffs2/debug.c
+++ b/fs/jffs2/debug.c
@@ -157,7 +157,7 @@ __jffs2_dbg_prewrite_paranoia_check(struct jffs2_sb_info *c,
kfree(buf);
}
-void __jffs2_dbg_superblock_counts(struct jffs2_sb_info *c)
+static void __jffs2_dbg_superblock_counts(struct jffs2_sb_info *c)
{
struct jffs2_eraseblock *jeb;
uint32_t free = 0, dirty = 0, used = 0, wasted = 0,
--
2.39.2
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] jffs2: mark __jffs2_dbg_superblock_counts() static
2023-05-17 13:27 [PATCH] jffs2: mark __jffs2_dbg_superblock_counts() static Arnd Bergmann
@ 2023-05-17 13:57 ` Tudor Ambarus
0 siblings, 0 replies; 2+ messages in thread
From: Tudor Ambarus @ 2023-05-17 13:57 UTC (permalink / raw)
To: Arnd Bergmann, David Woodhouse, Richard Weinberger
Cc: Arnd Bergmann, linux-mtd, linux-kernel
On 5/17/23 14:27, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> This function is only called locally and does not need to be
> global. Since there is no external prototype, gcc warns about
> the non-static definition:
>
> fs/jffs2/debug.c:160:6: error: no previous prototype for '__jffs2_dbg_superblock_counts' [-Werror=missing-prototypes]
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Tudor Ambarus <tudor.ambarus@linaro.org>
> ---
> fs/jffs2/debug.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/jffs2/debug.c b/fs/jffs2/debug.c
> index 9d26b1b9fc01..0925caab23c4 100644
> --- a/fs/jffs2/debug.c
> +++ b/fs/jffs2/debug.c
> @@ -157,7 +157,7 @@ __jffs2_dbg_prewrite_paranoia_check(struct jffs2_sb_info *c,
> kfree(buf);
> }
>
> -void __jffs2_dbg_superblock_counts(struct jffs2_sb_info *c)
> +static void __jffs2_dbg_superblock_counts(struct jffs2_sb_info *c)
> {
> struct jffs2_eraseblock *jeb;
> uint32_t free = 0, dirty = 0, used = 0, wasted = 0,
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-05-17 13:57 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-05-17 13:27 [PATCH] jffs2: mark __jffs2_dbg_superblock_counts() static Arnd Bergmann
2023-05-17 13:57 ` Tudor Ambarus
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox