From: Osama Muhammad <osmtendev@gmail.com>
To: thierry.reding@gmail.com, jonathanh@nvidia.com,
petlozup@nvidia.com, stefank@nvidia.com, sushilkumars@nvidia.com,
christophe.jaillet@wanadoo.fr, viresh.kumar@linaro.org,
dmitry.osipenko@collabora.com
Cc: linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org,
Osama Muhammad <osmtendev@gmail.com>
Subject: [PATCH] soc/pmc.c: Fix error checking for debugfs_create_dir
Date: Wed, 17 May 2023 21:13:56 +0500 [thread overview]
Message-ID: <20230517161356.11416-1-osmtendev@gmail.com> (raw)
This patch fixes the error checking in pmc.c in
debugfs_create_dir. The correct way to check if an error occurred
is 'IS_ERR' inline function.
Signed-off-by: Osama Muhammad <osmtendev@gmail.com>
---
drivers/soc/tegra/pmc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/soc/tegra/pmc.c b/drivers/soc/tegra/pmc.c
index 5d17799524c9..ac468e4a225c 100644
--- a/drivers/soc/tegra/pmc.c
+++ b/drivers/soc/tegra/pmc.c
@@ -1194,7 +1194,7 @@ static int tegra_powergate_debugfs_init(void)
{
pmc->debugfs = debugfs_create_file("powergate", S_IRUGO, NULL, NULL,
&powergate_fops);
- if (!pmc->debugfs)
+ if (IS_ERR(pmc->debugfs))
return -ENOMEM;
return 0;
--
2.34.1
reply other threads:[~2023-05-17 16:14 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230517161356.11416-1-osmtendev@gmail.com \
--to=osmtendev@gmail.com \
--cc=christophe.jaillet@wanadoo.fr \
--cc=dmitry.osipenko@collabora.com \
--cc=jonathanh@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=petlozup@nvidia.com \
--cc=stefank@nvidia.com \
--cc=sushilkumars@nvidia.com \
--cc=thierry.reding@gmail.com \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox