From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4FF46C7EE23 for ; Thu, 18 May 2023 07:31:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229943AbjERHbc (ORCPT ); Thu, 18 May 2023 03:31:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58658 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229524AbjERHb3 (ORCPT ); Thu, 18 May 2023 03:31:29 -0400 Received: from relay8-d.mail.gandi.net (relay8-d.mail.gandi.net [IPv6:2001:4b98:dc4:8::228]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1D8EB213A; Thu, 18 May 2023 00:30:09 -0700 (PDT) Received: from booty (unknown [77.244.183.192]) (Authenticated sender: luca.ceresoli@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id 7F2251BF204; Thu, 18 May 2023 07:28:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1684394930; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=6/pMkDHqpQee7Q5QnzaROcishnayyd/TZbSD01jovy8=; b=Tx7Z33B3eVZShtKikhLKhfxKEn0I3M0zPi6qXKlztvv0WPqWAUnDaTGJ/vuKHs+/5YQ9MR dUhfbCwqVN+7iXFC4I1x+qhAAdkMj+073xPwYtjpzOFNfsGcYJZRAhwll5VmEyRnKI+O9c 7KCWfqBtXqrUbC6bsTE0Ysih9q1tgPc9hu9J5ldSdgidhf7Inr5oCuNsJMY4lEfuizt6YS ay/in2/LvjycUMlmTIIXeJjhS9uZ2KF9Q7vfyd3yWrgjSS+Rsm7bNCsIMvgMs8VXIy2DpI 1iygqIKW5xgKTvf19jdlDw+mP1d+cjWhbPzC8XNJw0727qxXe4y8gRM2dpIDYQ== Date: Thu, 18 May 2023 09:28:46 +0200 From: Luca Ceresoli To: Uwe =?UTF-8?Q?Kleine-K=C3=B6nig?= Cc: Arnd Bergmann , Greg Kroah-Hartman , Bartosz Golaszewski , Jean Delvare , Eric Piel , Vladimir Oltean , Srinivas Pandruvada , Javier Martinez Canillas , Serge Semin , Wolfram Sang , Hans Verkuil , Justin Stitt , Yuan Can , Dan Carpenter , Adrien Grassein , Andy Shevchenko , Petr Machata , linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org Subject: Re: [PATCH] misc: Switch i2c drivers back to use .probe() Message-ID: <20230518092846.2012482c@booty> In-Reply-To: <20230517220135.170379-1-u.kleine-koenig@pengutronix.de> References: <20230517220135.170379-1-u.kleine-koenig@pengutronix.de> Organization: Bootlin X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Uwe, On Thu, 18 May 2023 00:01:35 +0200 Uwe Kleine-K=C3=B6nig wrote: > After commit b8a1a4cd5a98 ("i2c: Provide a temporary .probe_new() > call-back type"), all drivers being converted to .probe_new() and then > 03c835f498b5 ("i2c: Switch .probe() to not take an id parameter") convert > back to (the new) .probe() to be able to eventually drop .probe_new() from > struct i2c_driver. >=20 > While touching these drivers, fix alignment in apds990x.c and bh1770glc.c. >=20 > Signed-off-by: Uwe Kleine-K=C3=B6nig It's finally happening, thanks! \o/ Reviewed-by: Luca Ceresoli --=20 Luca Ceresoli, Bootlin Embedded Linux and Kernel engineering https://bootlin.com