From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0864AC77B7A for ; Sat, 20 May 2023 08:46:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229807AbjETIqg (ORCPT ); Sat, 20 May 2023 04:46:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34656 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230379AbjETIqd (ORCPT ); Sat, 20 May 2023 04:46:33 -0400 Received: from 1wt.eu (ded1.1wt.eu [163.172.96.212]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 981D7BD for ; Sat, 20 May 2023 01:46:31 -0700 (PDT) Received: (from willy@localhost) by pcw.home.local (8.15.2/8.15.2/Submit) id 34K8kA5U027215; Sat, 20 May 2023 10:46:10 +0200 Date: Sat, 20 May 2023 10:46:10 +0200 From: Willy Tarreau To: Thomas =?iso-8859-1?Q?Wei=DFschuh?= Cc: Zhangjin Wu , Palmer Dabbelt , Paul Walmsley , Albert Ou , "Paul E . McKenney" , linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 0/2] tools/nolibc: riscv: Fix up compile error for rv32 Message-ID: <20230520084610.GA27206@1wt.eu> References: <20230519094030.GA24947@1wt.eu> <3ce199ce-d9ca-4aa1-b19d-8e6b9b574300@t-8ch.de> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <3ce199ce-d9ca-4aa1-b19d-8e6b9b574300@t-8ch.de> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Thomas, On Sat, May 20, 2023 at 09:18:25AM +0200, Thomas Weißschuh wrote: > On 2023-05-19 12:19:10+0200, Willy Tarreau wrote: > > On Fri, May 19, 2023 at 12:11:00PM +0200, Thomas Weißschuh wrote: > > > Hi Willy, > > > > > > On 2023-05-19 11:40:30+0200, Willy Tarreau wrote: > > > > Hi Zhangjin, > > > > > > > > On Fri, May 19, 2023 at 01:00:18AM +0800, Zhangjin Wu wrote: > > > > > Hi, Willy > > > > > > > > > > nolibc for riscv is only tested for rv64 currently (see > > > > > tools/testing/selftests/nolibc/Makefile), this patchset tries to let it > > > > > compile for rv32, but still not pass the nolibc selftest: > > > > > > > > > > * The first patch uses lw/sw instead of ld/sd for rv32 and verse-vice for rv64 > > > > > * This patch may conflict with the stackprotector patch [1], because > > > > > both of them changed the _start assembly in arch-riscv.h > > > > > > > > That's quite embarrassing, I'm having to trace of that series here. Now > > > > I can find it in my LKML archives, but I don't have the direct message and > > > > didn't spot the other ones. I'll have to investigate, thanks for notifying > > > > me! I'm CCing Thomas, I will check with him how to best merge the two. > > > > > > I think the conflict should be trivial to fix. > > > > > > I can also resend my series or just the single riscv patch. > > > > OK then I'll pick Zhangjin's series and will apply yours on top of it. > > Do not bother resending the whole series, only the riscv patch will be > > sufficient, I have the rest of your series in my lkml mbox. > > Could you let me know if or when your are publishing your integration > branch? Just finished it now, I had to manually rebase all patches and had to interrupt it yesterday. You'll find it here: https://git.kernel.org/pub/scm/linux/kernel/git/wtarreau/nolibc.git 20230520-nolibc-rv32+stkp It contains a temporary series made of: - Zhangjin's RV32 patches - your syscall() patch - your stkp series except the riscv one so that you just need to update the riscv one and that will be fine. Be careful, I have *not* restested the riscv port. As usual, do not hesitate to le me know if I messed up with anything. Thanks! Willy