From: Arnd Bergmann <arnd@kernel.org>
To: Ingo Molnar <mingo@redhat.com>, Peter Zijlstra <peterz@infradead.org>
Cc: Arnd Bergmann <arnd@arndb.de>, Juri Lelli <juri.lelli@redhat.com>,
Vincent Guittot <vincent.guittot@linaro.org>,
Dietmar Eggemann <dietmar.eggemann@arm.com>,
Steven Rostedt <rostedt@goodmis.org>,
Ben Segall <bsegall@google.com>, Mel Gorman <mgorman@suse.de>,
Daniel Bristot de Oliveira <bristot@redhat.com>,
Valentin Schneider <vschneid@redhat.com>,
linux-kernel@vger.kernel.org
Subject: [PATCH 4/5] sched: make task_vruntime_update() prototype visible
Date: Mon, 22 May 2023 21:50:20 +0200 [thread overview]
Message-ID: <20230522195021.3456768-5-arnd@kernel.org> (raw)
In-Reply-To: <20230522195021.3456768-1-arnd@kernel.org>
From: Arnd Bergmann <arnd@arndb.de>
Having the prototype next to the caller but not visible to the callee causes
a W=1 warning:
kernel/sched/fair.c:11985:6: error: no previous prototype for 'task_vruntime_update' [-Werror=missing-prototypes]
Move this to a header, as we do for all other function declarations.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
kernel/sched/core.c | 2 --
kernel/sched/sched.h | 1 +
2 files changed, 1 insertion(+), 2 deletions(-)
diff --git a/kernel/sched/core.c b/kernel/sched/core.c
index 044bcdf4181a..aae6ff717c55 100644
--- a/kernel/sched/core.c
+++ b/kernel/sched/core.c
@@ -6030,8 +6030,6 @@ static inline struct task_struct *pick_task(struct rq *rq)
BUG(); /* The idle class should always have a runnable task. */
}
-extern void task_vruntime_update(struct rq *rq, struct task_struct *p, bool in_fi);
-
static void queue_core_balance(struct rq *rq);
static struct task_struct *
diff --git a/kernel/sched/sched.h b/kernel/sched/sched.h
index 44b34836bb60..d5ac0af1eede 100644
--- a/kernel/sched/sched.h
+++ b/kernel/sched/sched.h
@@ -1245,6 +1245,7 @@ static inline raw_spinlock_t *__rq_lockp(struct rq *rq)
bool cfs_prio_less(const struct task_struct *a, const struct task_struct *b,
bool fi);
+void task_vruntime_update(struct rq *rq, struct task_struct *p, bool in_fi);
/*
* Helpers to check if the CPU's core cookie matches with the task's cookie
--
2.39.2
next prev parent reply other threads:[~2023-05-22 19:51 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-22 19:50 [PATCH 0/5] sched: address missing-prototype warnings Arnd Bergmann
2023-05-22 19:50 ` [PATCH 1/5] sched: hide unused sched_update_scaling() Arnd Bergmann
2023-05-23 6:47 ` Mukesh Ojha
2023-05-31 12:04 ` [tip: sched/core] sched: Hide " tip-bot2 for Arnd Bergmann
2023-05-22 19:50 ` [PATCH 2/5] sched: add schedule_user() declaration Arnd Bergmann
2023-05-31 12:04 ` [tip: sched/core] sched: Add " tip-bot2 for Arnd Bergmann
2023-05-22 19:50 ` [PATCH 3/5] sched: fair: hide unused init_cfs_bandwidth() stub Arnd Bergmann
2023-05-23 7:22 ` Mukesh Ojha
2023-05-31 12:04 ` [tip: sched/core] sched/fair: Hide " tip-bot2 for Arnd Bergmann
2023-05-22 19:50 ` Arnd Bergmann [this message]
2023-05-23 7:02 ` [PATCH 4/5] sched: make task_vruntime_update() prototype visible Mukesh Ojha
2023-05-31 12:04 ` [tip: sched/core] sched: Make " tip-bot2 for Arnd Bergmann
2023-05-22 19:50 ` [PATCH 5/5] sched: fair: move unused stub functions to header Arnd Bergmann
2023-05-23 6:58 ` Mukesh Ojha
2023-05-31 12:04 ` [tip: sched/core] sched/fair: Move " tip-bot2 for Arnd Bergmann
2023-05-22 20:08 ` [PATCH 0/5] sched: address missing-prototype warnings Peter Zijlstra
2023-05-23 6:57 ` Vincent Guittot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230522195021.3456768-5-arnd@kernel.org \
--to=arnd@kernel.org \
--cc=arnd@arndb.de \
--cc=bristot@redhat.com \
--cc=bsegall@google.com \
--cc=dietmar.eggemann@arm.com \
--cc=juri.lelli@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=vincent.guittot@linaro.org \
--cc=vschneid@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox