From: Jakub Kicinski <kuba@kernel.org>
To: Peter Rosin <peda@axentia.se>
Cc: LKML <linux-kernel@vger.kernel.org>,
Dinan Gunawardena <dinan.gunawardena@netronome.com>,
Kalle Valo <kvalo@kernel.org>,
Johannes Berg <johannes.berg@intel.com>
Subject: Re: [PATCH] bitfield: suggest using bitwise OR when combining bitfields
Date: Tue, 23 May 2023 08:33:04 -0700 [thread overview]
Message-ID: <20230523083304.4a02d16b@kernel.org> (raw)
In-Reply-To: <9b872036-42ce-2d08-2e98-12bf0abf7095@axentia.se>
On Tue, 23 May 2023 14:16:30 +0200 Peter Rosin wrote:
> Logical OR fails to deliver the desired result. Most of the time.
>
> Fixes: 3e9b3112ec74 ("add basic register-field manipulation macros")
> Fixes: e2192de59e45 ("bitfield: add FIELD_PREP_CONST()")
Fixes tags for comment changes are an overkill. The change looks good.
Who are you expecting to take this patch? Feel free to repost this
CCing netdev@ so networking can take it, otherwise maybe Andrew will?
Not sure..
prev parent reply other threads:[~2023-05-23 15:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-23 12:16 [PATCH] bitfield: suggest using bitwise OR when combining bitfields Peter Rosin
2023-05-23 15:33 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230523083304.4a02d16b@kernel.org \
--to=kuba@kernel.org \
--cc=dinan.gunawardena@netronome.com \
--cc=johannes.berg@intel.com \
--cc=kvalo@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peda@axentia.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox