From: Lee Jones <lee@kernel.org>
To: Azeem Shaikh <azeemshaikh38@gmail.com>
Cc: Sakari Ailus <sakari.ailus@iki.fi>,
linux-hardening@vger.kernel.org, linux-leds@vger.kernel.org,
linux-kernel@vger.kernel.org,
Sakari Ailus <sakari.ailus@linux.intel.com>,
Pavel Machek <pavel@ucw.cz>
Subject: Re: [PATCH] i2c: Replace all non-returning strlcpy with strscpy
Date: Tue, 23 May 2023 10:05:40 +0100 [thread overview]
Message-ID: <20230523090540.GC2174496@google.com> (raw)
In-Reply-To: <20230523021150.2406032-1-azeemshaikh38@gmail.com>
On Tue, 23 May 2023, Azeem Shaikh wrote:
> strlcpy() reads the entire source buffer first.
> This read may exceed the destination size limit.
> This is both inefficient and can lead to linear read
> overflows if a source string is not NUL-terminated [1].
> In an effort to remove strlcpy() completely [2], replace
> strlcpy() here with strscpy().
> No return values were used, so direct replacement is safe.
>
> [1] https://www.kernel.org/doc/html/latest/process/deprecated.html#strlcpy
> [2] https://github.com/KSPP/linux/issues/89
>
> Signed-off-by: Azeem Shaikh <azeemshaikh38@gmail.com>
> ---
> drivers/leds/flash/leds-as3645a.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Please resubmit, taking the time to check the subject line please.
> diff --git a/drivers/leds/flash/leds-as3645a.c b/drivers/leds/flash/leds-as3645a.c
> index bb2249771acb..7dc574b18f5f 100644
> --- a/drivers/leds/flash/leds-as3645a.c
> +++ b/drivers/leds/flash/leds-as3645a.c
> @@ -651,8 +651,8 @@ static int as3645a_v4l2_setup(struct as3645a *flash)
> },
> };
>
> - strlcpy(cfg.dev_name, led->dev->kobj.name, sizeof(cfg.dev_name));
> - strlcpy(cfgind.dev_name, flash->iled_cdev.dev->kobj.name,
> + strscpy(cfg.dev_name, led->dev->kobj.name, sizeof(cfg.dev_name));
> + strscpy(cfgind.dev_name, flash->iled_cdev.dev->kobj.name,
> sizeof(cfgind.dev_name));
>
> flash->vf = v4l2_flash_init(
>
--
Lee Jones [李琼斯]
next prev parent reply other threads:[~2023-05-23 9:06 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-23 2:11 [PATCH] i2c: Replace all non-returning strlcpy with strscpy Azeem Shaikh
2023-05-23 9:05 ` Lee Jones [this message]
2023-05-23 9:13 ` Sakari Ailus
2023-05-23 14:34 ` Azeem Shaikh
2023-05-24 12:15 ` Sakari Ailus
2023-05-23 17:33 ` Kees Cook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230523090540.GC2174496@google.com \
--to=lee@kernel.org \
--cc=azeemshaikh38@gmail.com \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=sakari.ailus@iki.fi \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox