public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Pranav Prasad <pranavpp@google.com>
To: Jack Wang <jinpu.wang@cloud.ionos.com>,
	"James E . J . Bottomley" <jejb@linux.ibm.com>,
	"Martin K . Petersen" <martin.petersen@oracle.com>
Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
	Igor Pylypiv <ipylypiv@google.com>,
	Pranav Prasad <pranavpp@google.com>
Subject: [PATCH 2/2] scsi: pm80xx: Add fatal error check for pm8001_lu_reset()
Date: Tue, 23 May 2023 21:41:27 +0000	[thread overview]
Message-ID: <20230523214127.4006891-3-pranavpp@google.com> (raw)
In-Reply-To: <20230523214127.4006891-1-pranavpp@google.com>

From: Igor Pylypiv <ipylypiv@google.com>

This patch adds a fatal error check for pm8001_lu_reset().

Signed-off-by: Igor Pylypiv <ipylypiv@google.com>
Signed-off-by: Pranav Prasad <pranavpp@google.com>
---
 drivers/scsi/pm8001/pm8001_sas.c | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/drivers/scsi/pm8001/pm8001_sas.c b/drivers/scsi/pm8001/pm8001_sas.c
index b153f0966e5d..e302d5879bb7 100644
--- a/drivers/scsi/pm8001/pm8001_sas.c
+++ b/drivers/scsi/pm8001/pm8001_sas.c
@@ -918,6 +918,16 @@ int pm8001_lu_reset(struct domain_device *dev, u8 *lun)
 	struct pm8001_device *pm8001_dev = dev->lldd_dev;
 	struct pm8001_hba_info *pm8001_ha = pm8001_find_ha_by_dev(dev);
 	DECLARE_COMPLETION_ONSTACK(completion_setstate);
+
+	if (PM8001_CHIP_DISP->fatal_errors(pm8001_ha)) {
+		/* If the controller is in fatal error state,
+		 * we will not get a response from the controller
+		 */
+		pm8001_dbg(pm8001_ha, FAIL,
+				"LUN reset failed due to fatal errors\n");
+		return rc;
+	}
+
 	if (dev_is_sata(dev)) {
 		struct sas_phy *phy = sas_get_local_phy(dev);
 		sas_execute_internal_abort_dev(dev, 0, NULL);
-- 
2.40.1.698.g37aff9b760-goog


  parent reply	other threads:[~2023-05-23 21:42 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-23 21:41 [PATCH 0/2] scsi: pm80xx: Fatal error checks Pranav Prasad
2023-05-23 21:41 ` [PATCH 1/2] scsi: pm80xx: Add fatal error check for pm8001_phy_control() Pranav Prasad
2023-05-24  6:34   ` Jinpu Wang
2023-05-24  7:53   ` Damien Le Moal
2023-05-23 21:41 ` Pranav Prasad [this message]
2023-05-24  6:37   ` [PATCH 2/2] scsi: pm80xx: Add fatal error check for pm8001_lu_reset() Jinpu Wang
2023-05-24  7:55   ` Damien Le Moal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230523214127.4006891-3-pranavpp@google.com \
    --to=pranavpp@google.com \
    --cc=ipylypiv@google.com \
    --cc=jejb@linux.ibm.com \
    --cc=jinpu.wang@cloud.ionos.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox