From: Jean Delvare <jdelvare@suse.de>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: Arnd Bergmann <arnd@arndb.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Bartosz Golaszewski <brgl@bgdev.pl>,
Eric Piel <eric.piel@tremplin-utc.net>,
Luca Ceresoli <luca.ceresoli@bootlin.com>,
Vladimir Oltean <olteanv@gmail.com>,
Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>,
Javier Martinez Canillas <javierm@redhat.com>,
Serge Semin <fancer.lancer@gmail.com>,
Wolfram Sang <wsa@kernel.org>,
Hans Verkuil <hverkuil-cisco@xs4all.nl>,
Justin Stitt <justinstitt@google.com>,
Yuan Can <yuancan@huawei.com>, Dan Carpenter <error27@gmail.com>,
Adrien Grassein <adrien.grassein@gmail.com>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Petr Machata <petrm@nvidia.com>,
linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org
Subject: Re: [PATCH] misc: Switch i2c drivers back to use .probe()
Date: Wed, 24 May 2023 09:43:44 +0200 [thread overview]
Message-ID: <20230524094344.44baaf45@endymion.delvare> (raw)
In-Reply-To: <20230517220135.170379-1-u.kleine-koenig@pengutronix.de>
On Thu, 18 May 2023 00:01:35 +0200, Uwe Kleine-König wrote:
> After commit b8a1a4cd5a98 ("i2c: Provide a temporary .probe_new()
> call-back type"), all drivers being converted to .probe_new() and then
> 03c835f498b5 ("i2c: Switch .probe() to not take an id parameter") convert
> back to (the new) .probe() to be able to eventually drop .probe_new() from
> struct i2c_driver.
>
> While touching these drivers, fix alignment in apds990x.c and bh1770glc.c.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---
> Hello,
>
> I used v6.4-rc1 as base for this patch, but it also fits on top of
> today's next master. If there are some conflicts when you apply it, feel
> free to just drop all conflicting hunks, I'll care about the fallout
> later.
>
> I chose to do this in a single patch for all drivers below drivers/misc
> If you want me to split it, just tell me.
>
> Best regards
> Uwe
>
> drivers/misc/ad525x_dpot-i2c.c | 2 +-
> drivers/misc/apds9802als.c | 2 +-
> drivers/misc/apds990x.c | 4 ++--
> drivers/misc/bh1770glc.c | 4 ++--
> drivers/misc/ds1682.c | 2 +-
> drivers/misc/eeprom/at24.c | 2 +-
> drivers/misc/eeprom/ee1004.c | 2 +-
> drivers/misc/eeprom/eeprom.c | 2 +-
> drivers/misc/eeprom/idt_89hpesx.c | 2 +-
> drivers/misc/eeprom/max6875.c | 2 +-
> drivers/misc/hmc6352.c | 2 +-
> drivers/misc/ics932s401.c | 2 +-
> drivers/misc/isl29003.c | 2 +-
> drivers/misc/isl29020.c | 2 +-
> drivers/misc/lis3lv02d/lis3lv02d_i2c.c | 2 +-
> drivers/misc/tsl2550.c | 2 +-
> 16 files changed, 18 insertions(+), 18 deletions(-)
> (...)
Reviewed-by: Jean Delvare <jdelvare@suse.de>
--
Jean Delvare
SUSE L3 Support
next prev parent reply other threads:[~2023-05-24 7:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-17 22:01 [PATCH] misc: Switch i2c drivers back to use .probe() Uwe Kleine-König
2023-05-18 7:28 ` Luca Ceresoli
2023-05-24 7:43 ` Jean Delvare [this message]
2023-05-24 9:51 ` Bartosz Golaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230524094344.44baaf45@endymion.delvare \
--to=jdelvare@suse.de \
--cc=adrien.grassein@gmail.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=arnd@arndb.de \
--cc=brgl@bgdev.pl \
--cc=eric.piel@tremplin-utc.net \
--cc=error27@gmail.com \
--cc=fancer.lancer@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=hverkuil-cisco@xs4all.nl \
--cc=javierm@redhat.com \
--cc=justinstitt@google.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luca.ceresoli@bootlin.com \
--cc=olteanv@gmail.com \
--cc=petrm@nvidia.com \
--cc=srinivas.pandruvada@linux.intel.com \
--cc=u.kleine-koenig@pengutronix.de \
--cc=wsa@kernel.org \
--cc=yuancan@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox