Re: Re: [PATCH v3] i2c: ocores: use devm_ managed clks

Andrew Lunn
2023-04-25T15:06:49Z

On Tue, Apr 25, 2023 at 10:47:29PM +0800, 张网 wrote:
> Hi Andrew,
>
> I would like to express my sincere gratitude for taking the time and effort to review
> my submitted patch. I understand that reviewing can be a time-consuming process
> and I truly appreciate your dedication.
>
> As we move forward, I would like to inquire about the first version[1] of the patch I submitted.
> As clk_disable_unprepare() has checks for error pointer and NULL already, I think there is no
> need to add the check. So both the first version of the patch and this one can work on this
> branch.
>
> If there are any further changes or revisions needed, please do not hesitate to let me know.
> I am committed to learning and improving, and I welcome any feedback you may have.
> Thank you again for your support and guidance throughout this process.
>
> Best regards,
> Wang Zhang
> ---
> [1] http://patchwork.ozlabs.org/project/linux-i2c/patch/20230416071854.58335-1-silver_code@hust.edu.cn/

So this patch is about the IRQ being an error code, and doing the
correct cleanup.

With the change to devm_clk_get_ there is no need to disabled the
clock, it will be done automatically. This means there is no cleanup
the driver needs to do itself. So the patch is no longer needed.

Andrew