* [PATCH] adm1266.c: Fix error checking for debugfs_create_dir
@ 2023-05-24 16:54 Osama Muhammad
2023-05-24 22:17 ` Guenter Roeck
0 siblings, 1 reply; 2+ messages in thread
From: Osama Muhammad @ 2023-05-24 16:54 UTC (permalink / raw)
To: linux, jdelvare; +Cc: linux-hwmon, linux-kernel, Osama Muhammad
This patch fixes the error checking in adm1266.c in
debugfs_create_dir. The correct way to check if an error occurred
is using 'IS_ERR' inline function.
Signed-off-by: Osama Muhammad <osmtendev@gmail.com>
---
drivers/hwmon/pmbus/adm1266.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/hwmon/pmbus/adm1266.c b/drivers/hwmon/pmbus/adm1266.c
index 1ac2b2f4c570..d88b6115b42e 100644
--- a/drivers/hwmon/pmbus/adm1266.c
+++ b/drivers/hwmon/pmbus/adm1266.c
@@ -340,7 +340,7 @@ static void adm1266_init_debugfs(struct adm1266_data *data)
return;
data->debugfs_dir = debugfs_create_dir(data->client->name, root);
- if (!data->debugfs_dir)
+ if (IS_ERR(data->debugfs_dir))
return;
debugfs_create_devm_seqfile(&data->client->dev, "sequencer_state", data->debugfs_dir,
--
2.34.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] adm1266.c: Fix error checking for debugfs_create_dir
2023-05-24 16:54 [PATCH] adm1266.c: Fix error checking for debugfs_create_dir Osama Muhammad
@ 2023-05-24 22:17 ` Guenter Roeck
0 siblings, 0 replies; 2+ messages in thread
From: Guenter Roeck @ 2023-05-24 22:17 UTC (permalink / raw)
To: Osama Muhammad; +Cc: jdelvare, linux-hwmon, linux-kernel
On Wed, May 24, 2023 at 09:54:23PM +0500, Osama Muhammad wrote:
> This patch fixes the error checking in adm1266.c in
> debugfs_create_dir. The correct way to check if an error occurred
> is using 'IS_ERR' inline function.
>
> Signed-off-by: Osama Muhammad <osmtendev@gmail.com>
> ---
> drivers/hwmon/pmbus/adm1266.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/hwmon/pmbus/adm1266.c b/drivers/hwmon/pmbus/adm1266.c
> index 1ac2b2f4c570..d88b6115b42e 100644
> --- a/drivers/hwmon/pmbus/adm1266.c
> +++ b/drivers/hwmon/pmbus/adm1266.c
> @@ -340,7 +340,7 @@ static void adm1266_init_debugfs(struct adm1266_data *data)
> return;
>
> data->debugfs_dir = debugfs_create_dir(data->client->name, root);
> - if (!data->debugfs_dir)
> + if (IS_ERR(data->debugfs_dir))
> return;
Just drop the error check entirely instead. It is not needed.
Thanks,
Guenter
>
> debugfs_create_devm_seqfile(&data->client->dev, "sequencer_state", data->debugfs_dir,
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-05-24 22:17 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-05-24 16:54 [PATCH] adm1266.c: Fix error checking for debugfs_create_dir Osama Muhammad
2023-05-24 22:17 ` Guenter Roeck
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox