Re: [PATCH v6 3/6] media: starfive: Add basic driver

Jack Zhu
2023-06-19T07:27:48Z

Hi Bryan,

Thank you for your comments.

On 2023/6/16 21:13, Bryan O'Donoghue wrote:
> On 25/05/2023 09:31, Jack Zhu wrote:
>> Add basic platform driver for StarFive Camera Subsystem.
>>
>> Reviewed-by: Bryan O'Donoghue <c.odonoghue@linaro.org>
>> Signed-off-by: Jack Zhu <jack.zhu@starfivetech.com>
>
> One thing here is the patch title and hence commit message.
>
> "media: starfive:" doesn't really tell you this is a camera versus say a encoder/decoder.
>
> I see you've used the name "camss" for your driver, which I think is a perfectly good and logical choice - however if you started to make commits along the lines of "media: camss" that would conflict with the qcom camss.
>
> How about for starfive and qcom by the way, we do what Laurent did in
>
> commit 3e8537b4c15172bfe1b285c3155ed5c37d523cd3
> Author: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> Date:   Wed Dec 21 10:33:39 2022 +0100
>
>     media: ti: omap3isp: Use media_pipeline_for_each_entity()
>
> i.e. future StarFive commits for camera would be "media: starfive: camss" and similarly for Qualcomm "media: qualcomm: camss"
>
> The point being the commit title namespace should be instructive and specific re: 3e8537b4c15172bfe1b285c3155ed5c37d523cd3
>

Okay， I will add a camss directory under the starfive directory and modify the patch title.

> ---
> bod

--
Regards,

Jack Zhu