Re: [PATCH] leds: Replace all non-returning strlcpy with strscpy

Lee Jones
2023-05-25T11:32:14Z

On Tue, 23 May 2023, Azeem Shaikh wrote:

> strlcpy() reads the entire source buffer first.
> This read may exceed the destination size limit.
> This is both inefficient and can lead to linear read
> overflows if a source string is not NUL-terminated [1].
> In an effort to remove strlcpy() completely [2], replace
> strlcpy() here with strscpy().
> No return values were used, so direct replacement is safe.
>
> [1] https://www.kernel.org/doc/html/latest/process/deprecated.html#strlcpy
> [2] https://github.com/KSPP/linux/issues/89
>
> Signed-off-by: Azeem Shaikh <azeemshaikh38@gmail.com>
> ---
> drivers/leds/flash/leds-aat1290.c | 2 +-
> drivers/leds/led-class.c | 2 +-
> drivers/leds/leds-spi-byte.c | 2 +-
> 3 files changed, 3 insertions(+), 3 deletions(-)

Applied, thanks

--
Lee Jones [李琼斯]