From: Lee Jones <lee@kernel.org>
To: Lu Hongfei <luhongfei@vivo.com>
Cc: "Pavel Machek" <pavel@ucw.cz>,
"Anjelique Melendez" <quic_amelende@quicinc.com>,
"Thierry Reding" <thierry.reding@gmail.com>,
"Conor Dooley" <conor.dooley@microchip.com>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Dmitry Baryshkov" <dmitry.baryshkov@linaro.org>,
"Lu Hongfei" <11117923@bbktel.com>,
"open list:LED SUBSYSTEM" <linux-leds@vger.kernel.org>,
"open list" <linux-kernel@vger.kernel.org>,
opensource.kernel@vivo.com
Subject: Re: [PATCH] led: qcom-lpg: Fix resource leaks in for_each_available_child_of_node() loops
Date: Thu, 25 May 2023 13:02:23 +0100 [thread overview]
Message-ID: <20230525120223.GB443478@google.com> (raw)
In-Reply-To: <20230525111705.3055-1-luhongfei@vivo.com>
On Thu, 25 May 2023, Lu Hongfei wrote:
> for_each_available_child_of_node in lpg_probe and lpg_add_led need
> to execute of_node_put before return. this patch could fix this bug.
>
> Signed-off-by: Lu Hongfei <luhongfei@vivo.com>
> ---
> drivers/leds/rgb/leds-qcom-lpg.c | 8 ++++++--
> 1 file changed, 6 insertions(+), 2 deletions(-)
> mode change 100644 => 100755 drivers/leds/rgb/leds-qcom-lpg.c
I made a few tweaks to the commit messaged.
Applied, thanks
--
Lee Jones [李琼斯]
prev parent reply other threads:[~2023-05-25 12:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-25 11:17 [PATCH] led: qcom-lpg: Fix resource leaks in for_each_available_child_of_node() loops Lu Hongfei
2023-05-25 12:02 ` Lee Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230525120223.GB443478@google.com \
--to=lee@kernel.org \
--cc=11117923@bbktel.com \
--cc=conor.dooley@microchip.com \
--cc=dmitry.baryshkov@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=luhongfei@vivo.com \
--cc=opensource.kernel@vivo.com \
--cc=pavel@ucw.cz \
--cc=quic_amelende@quicinc.com \
--cc=thierry.reding@gmail.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox