public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Sasha Levin <sashal@kernel.org>
To: linux-kernel@vger.kernel.org, stable@vger.kernel.org
Cc: Tom Rix <trix@redhat.com>,
	Simon Horman <simon.horman@corigine.com>,
	Florian Westphal <fw@strlen.de>, Sasha Levin <sashal@kernel.org>,
	pablo@netfilter.org, kadlec@netfilter.org, davem@davemloft.net,
	edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
	netfilter-devel@vger.kernel.org, coreteam@netfilter.org,
	netdev@vger.kernel.org
Subject: [PATCH AUTOSEL 6.1 46/57] netfilter: conntrack: define variables exp_nat_nla_policy and any_addr with CONFIG_NF_NAT
Date: Thu, 25 May 2023 14:35:56 -0400	[thread overview]
Message-ID: <20230525183607.1793983-46-sashal@kernel.org> (raw)
In-Reply-To: <20230525183607.1793983-1-sashal@kernel.org>

From: Tom Rix <trix@redhat.com>

[ Upstream commit 224a876e37543eee111bf9b6aa4935080e619335 ]

gcc with W=1 and ! CONFIG_NF_NAT
net/netfilter/nf_conntrack_netlink.c:3463:32: error:
  ‘exp_nat_nla_policy’ defined but not used [-Werror=unused-const-variable=]
 3463 | static const struct nla_policy exp_nat_nla_policy[CTA_EXPECT_NAT_MAX+1] = {
      |                                ^~~~~~~~~~~~~~~~~~
net/netfilter/nf_conntrack_netlink.c:2979:33: error:
  ‘any_addr’ defined but not used [-Werror=unused-const-variable=]
 2979 | static const union nf_inet_addr any_addr;
      |                                 ^~~~~~~~

These variables use is controlled by CONFIG_NF_NAT, so should their definitions.

Signed-off-by: Tom Rix <trix@redhat.com>
Reviewed-by: Simon Horman <simon.horman@corigine.com>
Signed-off-by: Florian Westphal <fw@strlen.de>
Signed-off-by: Sasha Levin <sashal@kernel.org>
---
 net/netfilter/nf_conntrack_netlink.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/net/netfilter/nf_conntrack_netlink.c b/net/netfilter/nf_conntrack_netlink.c
index cb4325b8ebb11..2c21b4ed87c37 100644
--- a/net/netfilter/nf_conntrack_netlink.c
+++ b/net/netfilter/nf_conntrack_netlink.c
@@ -2984,7 +2984,9 @@ static int ctnetlink_exp_dump_mask(struct sk_buff *skb,
 	return -1;
 }
 
+#if IS_ENABLED(CONFIG_NF_NAT)
 static const union nf_inet_addr any_addr;
+#endif
 
 static __be32 nf_expect_get_id(const struct nf_conntrack_expect *exp)
 {
@@ -3468,10 +3470,12 @@ ctnetlink_change_expect(struct nf_conntrack_expect *x,
 	return 0;
 }
 
+#if IS_ENABLED(CONFIG_NF_NAT)
 static const struct nla_policy exp_nat_nla_policy[CTA_EXPECT_NAT_MAX+1] = {
 	[CTA_EXPECT_NAT_DIR]	= { .type = NLA_U32 },
 	[CTA_EXPECT_NAT_TUPLE]	= { .type = NLA_NESTED },
 };
+#endif
 
 static int
 ctnetlink_parse_expect_nat(const struct nlattr *attr,
-- 
2.39.2


  parent reply	other threads:[~2023-05-25 18:44 UTC|newest]

Thread overview: 59+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-25 18:35 [PATCH AUTOSEL 6.1 01/57] nvme-pci: add NVME_QUIRK_BOGUS_NID for HS-SSD-FUTURE 2048G Sasha Levin
2023-05-25 18:35 ` [PATCH AUTOSEL 6.1 02/57] nvme-pci: add quirk for missing secondary temperature thresholds Sasha Levin
2023-05-25 18:35 ` [PATCH AUTOSEL 6.1 03/57] ASoC: amd: yc: Add DMI entry to support System76 Pangolin 12 Sasha Levin
2023-05-25 18:35 ` [PATCH AUTOSEL 6.1 04/57] ASoC: dwc: limit the number of overrun messages Sasha Levin
2023-05-25 18:35 ` [PATCH AUTOSEL 6.1 05/57] selftests/ftrace: Improve integration with kselftest runner Sasha Levin
2023-05-25 18:35 ` [PATCH AUTOSEL 6.1 06/57] um: harddog: fix modular build Sasha Levin
2023-05-25 18:35 ` [PATCH AUTOSEL 6.1 07/57] xfrm: Check if_id in inbound policy/secpath match Sasha Levin
2023-05-25 18:35 ` [PATCH AUTOSEL 6.1 08/57] ASoC: dt-bindings: Adjust #sound-dai-cells on TI's single-DAI codecs Sasha Levin
2023-05-25 18:35 ` [PATCH AUTOSEL 6.1 09/57] ALSA: hda/realtek: Add quirks for ASUS GU604V and GU603V Sasha Levin
2023-05-25 18:35 ` [PATCH AUTOSEL 6.1 10/57] ASoC: ssm2602: Add workaround for playback distortions Sasha Levin
2023-05-25 18:35 ` [PATCH AUTOSEL 6.1 11/57] media: dvb_demux: fix a bug for the continuity counter Sasha Levin
2023-05-25 18:35 ` [PATCH AUTOSEL 6.1 12/57] media: dvb-usb: az6027: fix three null-ptr-deref in az6027_i2c_xfer() Sasha Levin
2023-05-25 18:35 ` [PATCH AUTOSEL 6.1 13/57] media: dvb-usb-v2: ec168: fix null-ptr-deref in ec168_i2c_xfer() Sasha Levin
2023-05-25 18:35 ` [PATCH AUTOSEL 6.1 14/57] media: dvb-usb-v2: ce6230: fix null-ptr-deref in ce6230_i2c_master_xfer() Sasha Levin
2023-05-25 18:35 ` [PATCH AUTOSEL 6.1 15/57] media: dvb-usb-v2: rtl28xxu: fix null-ptr-deref in rtl28xxu_i2c_xfer Sasha Levin
2023-05-25 18:35 ` [PATCH AUTOSEL 6.1 16/57] media: dvb-usb: digitv: fix null-ptr-deref in digitv_i2c_xfer() Sasha Levin
2023-05-25 18:35 ` [PATCH AUTOSEL 6.1 17/57] media: dvb-usb: dw2102: fix uninit-value in su3000_read_mac_address Sasha Levin
2023-05-25 18:35 ` [PATCH AUTOSEL 6.1 18/57] media: netup_unidvb: fix irq init by register it at the end of probe Sasha Levin
2023-05-25 18:35 ` [PATCH AUTOSEL 6.1 19/57] media: dvb_ca_en50221: fix a size write bug Sasha Levin
2023-05-25 18:35 ` [PATCH AUTOSEL 6.1 20/57] media: ttusb-dec: fix memory leak in ttusb_dec_exit_dvb() Sasha Levin
2023-05-25 18:35 ` [PATCH AUTOSEL 6.1 21/57] media: mn88443x: fix !CONFIG_OF error by drop of_match_ptr from ID table Sasha Levin
2023-05-25 18:35 ` [PATCH AUTOSEL 6.1 22/57] media: dvb-core: Fix use-after-free due on race condition at dvb_net Sasha Levin
2023-05-25 18:35 ` [PATCH AUTOSEL 6.1 23/57] media: dvb-core: Fix use-after-free due to race at dvb_register_device() Sasha Levin
2023-05-25 18:35 ` [PATCH AUTOSEL 6.1 24/57] media: dvb-core: Fix kernel WARNING for blocking operation in wait_event*() Sasha Levin
2023-05-25 18:35 ` [PATCH AUTOSEL 6.1 25/57] media: dvb-core: Fix use-after-free due to race condition at dvb_ca_en50221 Sasha Levin
2023-05-25 18:35 ` [PATCH AUTOSEL 6.1 26/57] ASoC: SOF: debug: conditionally bump runtime_pm counter on exceptions Sasha Levin
2023-05-25 18:35 ` [PATCH AUTOSEL 6.1 27/57] ASoC: SOF: pcm: fix pm_runtime imbalance in error handling Sasha Levin
2023-05-25 18:35 ` [PATCH AUTOSEL 6.1 28/57] ASoC: SOF: sof-client-probes: " Sasha Levin
2023-06-16 19:24   ` Pavel Machek
2023-05-25 18:35 ` [PATCH AUTOSEL 6.1 29/57] ASoC: SOF: pm: save io region state in case of errors in resume Sasha Levin
2023-05-25 18:35 ` [PATCH AUTOSEL 6.1 30/57] tipc: add tipc_bearer_min_mtu to calculate min mtu Sasha Levin
2023-06-16 19:27   ` Pavel Machek
2023-05-25 18:35 ` [PATCH AUTOSEL 6.1 31/57] s390/pkey: zeroize key blobs Sasha Levin
2023-05-25 18:35 ` [PATCH AUTOSEL 6.1 32/57] s390/topology: honour nr_cpu_ids when adding CPUs Sasha Levin
2023-05-25 18:35 ` [PATCH AUTOSEL 6.1 33/57] ACPI: resource: Add IRQ override quirk for LG UltraPC 17U70P Sasha Levin
2023-05-25 18:35 ` [PATCH AUTOSEL 6.1 34/57] wifi: rtl8xxxu: fix authentication timeout due to incorrect RCR value Sasha Levin
2023-05-25 18:35 ` [PATCH AUTOSEL 6.1 35/57] ARM: dts: stm32: add pin map for CAN controller on stm32f7 Sasha Levin
2023-05-25 18:35 ` [PATCH AUTOSEL 6.1 36/57] ARM: dts: stm32: add CAN support on stm32f746 Sasha Levin
2023-05-25 18:35 ` [PATCH AUTOSEL 6.1 37/57] arm64/mm: mark private VM_FAULT_X defines as vm_fault_t Sasha Levin
2023-05-25 18:35 ` [PATCH AUTOSEL 6.1 38/57] arm64: vdso: Pass (void *) to virt_to_page() Sasha Levin
2023-05-25 18:35 ` [PATCH AUTOSEL 6.1 39/57] wifi: mac80211: simplify chanctx allocation Sasha Levin
2023-05-25 18:35 ` [PATCH AUTOSEL 6.1 40/57] wifi: mac80211: consider reserved chanctx for mindef Sasha Levin
2023-05-25 18:35 ` [PATCH AUTOSEL 6.1 41/57] wifi: mac80211: recalc chanctx mindef before assigning Sasha Levin
2023-05-25 18:35 ` [PATCH AUTOSEL 6.1 42/57] wifi: iwlwifi: mvm: Add locking to the rate read flow Sasha Levin
2023-05-25 18:35 ` [PATCH AUTOSEL 6.1 43/57] scsi: core: Decrease scsi_device's iorequest_cnt if dispatch failed Sasha Levin
2023-05-25 18:35 ` [PATCH AUTOSEL 6.1 44/57] wifi: b43: fix incorrect __packed annotation Sasha Levin
2023-05-25 18:35 ` [PATCH AUTOSEL 6.1 45/57] net: wwan: t7xx: Ensure init is completed before system sleep Sasha Levin
2023-05-25 18:35 ` Sasha Levin [this message]
2023-05-25 18:35 ` [PATCH AUTOSEL 6.1 47/57] nvme-multipath: don't call blk_mark_disk_dead in nvme_mpath_remove_disk Sasha Levin
2023-05-25 18:35 ` [PATCH AUTOSEL 6.1 48/57] nvme: do not let the user delete a ctrl before a complete initialization Sasha Levin
2023-05-25 18:35 ` [PATCH AUTOSEL 6.1 49/57] ALSA: oss: avoid missing-prototype warnings Sasha Levin
2023-05-25 18:36 ` [PATCH AUTOSEL 6.1 50/57] drm/msm: Be more shouty if per-process pgtables aren't working Sasha Levin
2023-05-25 18:36 ` [PATCH AUTOSEL 6.1 51/57] atm: hide unused procfs functions Sasha Levin
2023-05-25 18:36 ` [PATCH AUTOSEL 6.1 52/57] mdio_bus: unhide mdio_bus_init prototype Sasha Levin
2023-05-25 18:36 ` [PATCH AUTOSEL 6.1 53/57] ceph: silence smatch warning in reconnect_caps_cb() Sasha Levin
2023-05-25 18:36 ` [PATCH AUTOSEL 6.1 54/57] drm/amdgpu: skip disabling fence driver src_irqs when device is unplugged Sasha Levin
2023-05-25 18:36 ` [PATCH AUTOSEL 6.1 55/57] ublk: fix AB-BA lockdep warning Sasha Levin
2023-05-25 18:36 ` [PATCH AUTOSEL 6.1 56/57] nvme-pci: Add quirk for Teamgroup MP33 SSD Sasha Levin
2023-05-25 18:36 ` [PATCH AUTOSEL 6.1 57/57] block: Deny writable memory mapping if block is read-only Sasha Levin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230525183607.1793983-46-sashal@kernel.org \
    --to=sashal@kernel.org \
    --cc=coreteam@netfilter.org \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=fw@strlen.de \
    --cc=kadlec@netfilter.org \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=pablo@netfilter.org \
    --cc=simon.horman@corigine.com \
    --cc=stable@vger.kernel.org \
    --cc=trix@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox