public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Sasha Levin <sashal@kernel.org>
To: linux-kernel@vger.kernel.org, stable@vger.kernel.org
Cc: Guchun Chen <guchun.chen@amd.com>,
	Alex Deucher <alexander.deucher@amd.com>,
	Sasha Levin <sashal@kernel.org>,
	christian.koenig@amd.com, Xinhui.Pan@amd.com, airlied@gmail.com,
	daniel@ffwll.ch, luben.tuikov@amd.com, andrey.grodzovsky@amd.com,
	Jiadong.Zhu@amd.com, gpiccoli@igalia.com, YuBiao.Wang@amd.com,
	slark_xiao@163.com, Likun.Gao@amd.com,
	amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org
Subject: [PATCH AUTOSEL 5.15 42/43] drm/amdgpu: skip disabling fence driver src_irqs when device is unplugged
Date: Thu, 25 May 2023 14:38:53 -0400	[thread overview]
Message-ID: <20230525183854.1855431-42-sashal@kernel.org> (raw)
In-Reply-To: <20230525183854.1855431-1-sashal@kernel.org>

From: Guchun Chen <guchun.chen@amd.com>

[ Upstream commit c1a322a7a4a96cd0a3dde32ce37af437a78bf8cd ]

When performing device unbind or halt, we have disabled all irqs at the
very begining like amdgpu_pci_remove or amdgpu_device_halt. So
amdgpu_irq_put for irqs stored in fence driver should not be called
any more, otherwise, below calltrace will arrive.

[  139.114088] WARNING: CPU: 2 PID: 1550 at drivers/gpu/drm/amd/amdgpu/amdgpu_irq.c:616 amdgpu_irq_put+0xf6/0x110 [amdgpu]
[  139.114655] Call Trace:
[  139.114655]  <TASK>
[  139.114657]  amdgpu_fence_driver_hw_fini+0x93/0x130 [amdgpu]
[  139.114836]  amdgpu_device_fini_hw+0xb6/0x350 [amdgpu]
[  139.114955]  amdgpu_driver_unload_kms+0x51/0x70 [amdgpu]
[  139.115075]  amdgpu_pci_remove+0x63/0x160 [amdgpu]
[  139.115193]  ? __pm_runtime_resume+0x64/0x90
[  139.115195]  pci_device_remove+0x3a/0xb0
[  139.115197]  device_remove+0x43/0x70
[  139.115198]  device_release_driver_internal+0xbd/0x140

Signed-off-by: Guchun Chen <guchun.chen@amd.com>
Acked-by: Alex Deucher <alexander.deucher@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
---
 drivers/gpu/drm/amd/amdgpu/amdgpu_fence.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_fence.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_fence.c
index bbd6f7a123033..8599e0ffa8292 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_fence.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_fence.c
@@ -561,7 +561,8 @@ void amdgpu_fence_driver_hw_fini(struct amdgpu_device *adev)
 		if (r)
 			amdgpu_fence_driver_force_completion(ring);
 
-		if (ring->fence_drv.irq_src)
+		if (!drm_dev_is_unplugged(adev_to_drm(adev)) &&
+		    ring->fence_drv.irq_src)
 			amdgpu_irq_put(adev, ring->fence_drv.irq_src,
 				       ring->fence_drv.irq_type);
 
-- 
2.39.2


  parent reply	other threads:[~2023-05-25 18:48 UTC|newest]

Thread overview: 43+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-25 18:38 [PATCH AUTOSEL 5.15 01/43] nvme-pci: add NVME_QUIRK_BOGUS_NID for HS-SSD-FUTURE 2048G Sasha Levin
2023-05-25 18:38 ` [PATCH AUTOSEL 5.15 02/43] nvme-pci: add quirk for missing secondary temperature thresholds Sasha Levin
2023-05-25 18:38 ` [PATCH AUTOSEL 5.15 03/43] ASoC: dwc: limit the number of overrun messages Sasha Levin
2023-05-25 18:38 ` [PATCH AUTOSEL 5.15 04/43] selftests/ftrace: Improve integration with kselftest runner Sasha Levin
2023-05-25 18:38 ` [PATCH AUTOSEL 5.15 05/43] um: harddog: fix modular build Sasha Levin
2023-05-25 18:38 ` [PATCH AUTOSEL 5.15 06/43] xfrm: Check if_id in inbound policy/secpath match Sasha Levin
2023-05-25 18:38 ` [PATCH AUTOSEL 5.15 07/43] ASoC: dt-bindings: Adjust #sound-dai-cells on TI's single-DAI codecs Sasha Levin
2023-05-25 18:38 ` [PATCH AUTOSEL 5.15 08/43] ASoC: ssm2602: Add workaround for playback distortions Sasha Levin
2023-05-25 18:38 ` [PATCH AUTOSEL 5.15 09/43] media: dvb_demux: fix a bug for the continuity counter Sasha Levin
2023-05-25 18:38 ` [PATCH AUTOSEL 5.15 10/43] media: dvb-usb: az6027: fix three null-ptr-deref in az6027_i2c_xfer() Sasha Levin
2023-05-25 18:38 ` [PATCH AUTOSEL 5.15 11/43] media: dvb-usb-v2: ec168: fix null-ptr-deref in ec168_i2c_xfer() Sasha Levin
2023-05-25 18:38 ` [PATCH AUTOSEL 5.15 12/43] media: dvb-usb-v2: ce6230: fix null-ptr-deref in ce6230_i2c_master_xfer() Sasha Levin
2023-05-25 18:38 ` [PATCH AUTOSEL 5.15 13/43] media: dvb-usb-v2: rtl28xxu: fix null-ptr-deref in rtl28xxu_i2c_xfer Sasha Levin
2023-05-25 18:38 ` [PATCH AUTOSEL 5.15 14/43] media: dvb-usb: digitv: fix null-ptr-deref in digitv_i2c_xfer() Sasha Levin
2023-05-25 18:38 ` [PATCH AUTOSEL 5.15 15/43] media: dvb-usb: dw2102: fix uninit-value in su3000_read_mac_address Sasha Levin
2023-05-25 18:38 ` [PATCH AUTOSEL 5.15 16/43] media: netup_unidvb: fix irq init by register it at the end of probe Sasha Levin
2023-05-25 18:38 ` [PATCH AUTOSEL 5.15 17/43] media: dvb_ca_en50221: fix a size write bug Sasha Levin
2023-05-25 18:38 ` [PATCH AUTOSEL 5.15 18/43] media: ttusb-dec: fix memory leak in ttusb_dec_exit_dvb() Sasha Levin
2023-05-25 18:38 ` [PATCH AUTOSEL 5.15 19/43] media: mn88443x: fix !CONFIG_OF error by drop of_match_ptr from ID table Sasha Levin
2023-05-25 18:38 ` [PATCH AUTOSEL 5.15 20/43] media: dvb-core: Fix use-after-free due on race condition at dvb_net Sasha Levin
2023-05-25 18:38 ` [PATCH AUTOSEL 5.15 21/43] media: dvb-core: Fix use-after-free due to race at dvb_register_device() Sasha Levin
2023-05-25 18:38 ` [PATCH AUTOSEL 5.15 22/43] media: dvb-core: Fix kernel WARNING for blocking operation in wait_event*() Sasha Levin
2023-05-25 18:38 ` [PATCH AUTOSEL 5.15 23/43] media: dvb-core: Fix use-after-free due to race condition at dvb_ca_en50221 Sasha Levin
2023-05-25 18:38 ` [PATCH AUTOSEL 5.15 24/43] tipc: add tipc_bearer_min_mtu to calculate min mtu Sasha Levin
2023-05-25 18:38 ` [PATCH AUTOSEL 5.15 25/43] s390/pkey: zeroize key blobs Sasha Levin
2023-05-25 18:38 ` [PATCH AUTOSEL 5.15 26/43] s390/topology: honour nr_cpu_ids when adding CPUs Sasha Levin
2023-05-25 18:38 ` [PATCH AUTOSEL 5.15 27/43] ACPI: resource: Add IRQ override quirk for LG UltraPC 17U70P Sasha Levin
2023-05-25 18:38 ` [PATCH AUTOSEL 5.15 28/43] wifi: rtl8xxxu: fix authentication timeout due to incorrect RCR value Sasha Levin
2023-05-25 18:38 ` [PATCH AUTOSEL 5.15 29/43] ARM: dts: stm32: add pin map for CAN controller on stm32f7 Sasha Levin
2023-05-25 18:38 ` [PATCH AUTOSEL 5.15 30/43] ARM: dts: stm32: add CAN support on stm32f746 Sasha Levin
2023-05-25 18:38 ` [PATCH AUTOSEL 5.15 31/43] arm64/mm: mark private VM_FAULT_X defines as vm_fault_t Sasha Levin
2023-05-25 18:38 ` [PATCH AUTOSEL 5.15 32/43] arm64: vdso: Pass (void *) to virt_to_page() Sasha Levin
2023-05-25 18:38 ` [PATCH AUTOSEL 5.15 33/43] wifi: mac80211: simplify chanctx allocation Sasha Levin
2023-05-25 18:38 ` [PATCH AUTOSEL 5.15 34/43] scsi: core: Decrease scsi_device's iorequest_cnt if dispatch failed Sasha Levin
2023-05-25 18:38 ` [PATCH AUTOSEL 5.15 35/43] wifi: b43: fix incorrect __packed annotation Sasha Levin
2023-05-25 18:38 ` [PATCH AUTOSEL 5.15 36/43] netfilter: conntrack: define variables exp_nat_nla_policy and any_addr with CONFIG_NF_NAT Sasha Levin
2023-05-25 18:38 ` [PATCH AUTOSEL 5.15 37/43] nvme-multipath: don't call blk_mark_disk_dead in nvme_mpath_remove_disk Sasha Levin
2023-05-25 18:38 ` [PATCH AUTOSEL 5.15 38/43] ALSA: oss: avoid missing-prototype warnings Sasha Levin
2023-05-25 18:38 ` [PATCH AUTOSEL 5.15 39/43] drm/msm: Be more shouty if per-process pgtables aren't working Sasha Levin
2023-05-25 18:38 ` [PATCH AUTOSEL 5.15 40/43] atm: hide unused procfs functions Sasha Levin
2023-05-25 18:38 ` [PATCH AUTOSEL 5.15 41/43] mdio_bus: unhide mdio_bus_init prototype Sasha Levin
2023-05-25 18:38 ` Sasha Levin [this message]
2023-05-25 18:38 ` [PATCH AUTOSEL 5.15 43/43] nvme-pci: Add quirk for Teamgroup MP33 SSD Sasha Levin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230525183854.1855431-42-sashal@kernel.org \
    --to=sashal@kernel.org \
    --cc=Jiadong.Zhu@amd.com \
    --cc=Likun.Gao@amd.com \
    --cc=Xinhui.Pan@amd.com \
    --cc=YuBiao.Wang@amd.com \
    --cc=airlied@gmail.com \
    --cc=alexander.deucher@amd.com \
    --cc=amd-gfx@lists.freedesktop.org \
    --cc=andrey.grodzovsky@amd.com \
    --cc=christian.koenig@amd.com \
    --cc=daniel@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=gpiccoli@igalia.com \
    --cc=guchun.chen@amd.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luben.tuikov@amd.com \
    --cc=slark_xiao@163.com \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox