From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0487FC7EE23 for ; Fri, 26 May 2023 07:39:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242488AbjEZHjd (ORCPT ); Fri, 26 May 2023 03:39:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37622 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242451AbjEZHj3 (ORCPT ); Fri, 26 May 2023 03:39:29 -0400 Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B1ED6E52 for ; Fri, 26 May 2023 00:39:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1685086743; x=1716622743; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=xi7TBBQPejEGgobEw64w8lH8esKp08fZJkFWOZYLoxk=; b=C7fEt4aTb7pGSywmCDhT+p3q/lea+rfmittXDb1uS+UNcoiissJ0YL1Z cDz4f/f2lhoTUuz48G/tuwLDBv8zh3gMfCAOPsReq/p10Yjrs8lR49Zxy OvPPCSVwciNy5wI22dfw92xkestRAjvExPucrffC4nZCCsOnFNhcIDZgj axyNB/uyGmWP9WZmMyIbkyGg8b0BWSffHuPK7KxpUSSo8JBdnTD8LFQu+ kpVz0KhpBo7VdyDGFVAYLsfg80Vt6VfV079O6aFyLQSBFVHBm7H7L7f70 wzVhQWiDlxkOpMuY8If8sH82RHezuV8eTelMp3FhcrQ+Q5BWnrnYYJB1C w==; X-IronPort-AV: E=McAfee;i="6600,9927,10721"; a="352984372" X-IronPort-AV: E=Sophos;i="6.00,193,1681196400"; d="scan'208";a="352984372" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 May 2023 00:36:58 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10721"; a="682641409" X-IronPort-AV: E=Sophos;i="6.00,193,1681196400"; d="scan'208";a="682641409" Received: from joe-255.igk.intel.com (HELO localhost) ([10.91.220.57]) by orsmga006-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 May 2023 00:36:55 -0700 Date: Fri, 26 May 2023 09:36:53 +0200 From: Stanislaw Gruszka To: Randy Dunlap Cc: linux-kernel@vger.kernel.org, kernel test robot , Oded Gabbay , dri-devel@lists.freedesktop.org, Jacek Lawrynowicz , Andrzej Kacprowski , Krystian Pradzynski , Jeffrey Hugo , Daniel Vetter Subject: Re: [PATCH] accel/ivpu: ivpu_ipc needs GENERIC_ALLOCATOR Message-ID: <20230526073653.GA903183@linux.intel.com> References: <20230526044519.13441-1-rdunlap@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230526044519.13441-1-rdunlap@infradead.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, May 25, 2023 at 09:45:19PM -0700, Randy Dunlap wrote: > Drivers that use the gen_pool*() family of functions should > select GENERIC_ALLOCATOR to prevent build errors like these: > > ld: drivers/accel/ivpu/ivpu_ipc.o: in function `gen_pool_free': > include/linux/genalloc.h:172: undefined reference to `gen_pool_free_owner' > ld: drivers/accel/ivpu/ivpu_ipc.o: in function `gen_pool_alloc_algo': > include/linux/genalloc.h:138: undefined reference to `gen_pool_alloc_algo_owner' > ld: drivers/accel/ivpu/ivpu_ipc.o: in function `gen_pool_free': > include/linux/genalloc.h:172: undefined reference to `gen_pool_free_owner' > ld: drivers/accel/ivpu/ivpu_ipc.o: in function `ivpu_ipc_init': > drivers/accel/ivpu/ivpu_ipc.c:441: undefined reference to `devm_gen_pool_create' > ld: drivers/accel/ivpu/ivpu_ipc.o: in function `gen_pool_add_virt': > include/linux/genalloc.h:104: undefined reference to `gen_pool_add_owner' > > Fixes: 5d7422cfb498 ("accel/ivpu: Add IPC driver and JSM messages") > Signed-off-by: Randy Dunlap > Reported-by: kernel test robot > Link: https://lore.kernel.org/all/202305221206.1TaugDKP-lkp@intel.com/ > Cc: Oded Gabbay > Cc: dri-devel@lists.freedesktop.org > Cc: Jacek Lawrynowicz > Cc: Stanislaw Gruszka > Cc: Andrzej Kacprowski > Cc: Krystian Pradzynski > Cc: Jeffrey Hugo > Cc: Daniel Vetter Acked-by: Stanislaw Gruszka > --- > drivers/accel/ivpu/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff -- a/drivers/accel/ivpu/Kconfig b/drivers/accel/ivpu/Kconfig > --- a/drivers/accel/ivpu/Kconfig > +++ b/drivers/accel/ivpu/Kconfig > @@ -7,6 +7,7 @@ config DRM_ACCEL_IVPU > depends on PCI && PCI_MSI > select FW_LOADER > select SHMEM > + select GENERIC_ALLOCATOR > help > Choose this option if you have a system that has an 14th generation Intel CPU > or newer. VPU stands for Versatile Processing Unit and it's a CPU-integrated