* [PATCH] accel/ivpu: ivpu_ipc needs GENERIC_ALLOCATOR
@ 2023-05-26 4:45 Randy Dunlap
2023-05-26 7:36 ` Stanislaw Gruszka
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Randy Dunlap @ 2023-05-26 4:45 UTC (permalink / raw)
To: linux-kernel
Cc: Randy Dunlap, kernel test robot, Oded Gabbay, dri-devel,
Jacek Lawrynowicz, Stanislaw Gruszka, Andrzej Kacprowski,
Krystian Pradzynski, Jeffrey Hugo, Daniel Vetter
Drivers that use the gen_pool*() family of functions should
select GENERIC_ALLOCATOR to prevent build errors like these:
ld: drivers/accel/ivpu/ivpu_ipc.o: in function `gen_pool_free':
include/linux/genalloc.h:172: undefined reference to `gen_pool_free_owner'
ld: drivers/accel/ivpu/ivpu_ipc.o: in function `gen_pool_alloc_algo':
include/linux/genalloc.h:138: undefined reference to `gen_pool_alloc_algo_owner'
ld: drivers/accel/ivpu/ivpu_ipc.o: in function `gen_pool_free':
include/linux/genalloc.h:172: undefined reference to `gen_pool_free_owner'
ld: drivers/accel/ivpu/ivpu_ipc.o: in function `ivpu_ipc_init':
drivers/accel/ivpu/ivpu_ipc.c:441: undefined reference to `devm_gen_pool_create'
ld: drivers/accel/ivpu/ivpu_ipc.o: in function `gen_pool_add_virt':
include/linux/genalloc.h:104: undefined reference to `gen_pool_add_owner'
Fixes: 5d7422cfb498 ("accel/ivpu: Add IPC driver and JSM messages")
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Reported-by: kernel test robot <lkp@intel.com>
Link: https://lore.kernel.org/all/202305221206.1TaugDKP-lkp@intel.com/
Cc: Oded Gabbay <ogabbay@kernel.org>
Cc: dri-devel@lists.freedesktop.org
Cc: Jacek Lawrynowicz <jacek.lawrynowicz@linux.intel.com>
Cc: Stanislaw Gruszka <stanislaw.gruszka@linux.intel.com>
Cc: Andrzej Kacprowski <andrzej.kacprowski@linux.intel.com>
Cc: Krystian Pradzynski <krystian.pradzynski@linux.intel.com>
Cc: Jeffrey Hugo <quic_jhugo@quicinc.com>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
---
drivers/accel/ivpu/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff -- a/drivers/accel/ivpu/Kconfig b/drivers/accel/ivpu/Kconfig
--- a/drivers/accel/ivpu/Kconfig
+++ b/drivers/accel/ivpu/Kconfig
@@ -7,6 +7,7 @@ config DRM_ACCEL_IVPU
depends on PCI && PCI_MSI
select FW_LOADER
select SHMEM
+ select GENERIC_ALLOCATOR
help
Choose this option if you have a system that has an 14th generation Intel CPU
or newer. VPU stands for Versatile Processing Unit and it's a CPU-integrated
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] accel/ivpu: ivpu_ipc needs GENERIC_ALLOCATOR
2023-05-26 4:45 [PATCH] accel/ivpu: ivpu_ipc needs GENERIC_ALLOCATOR Randy Dunlap
@ 2023-05-26 7:36 ` Stanislaw Gruszka
2023-06-02 17:21 ` Jeffrey Hugo
2023-06-06 12:35 ` Stanislaw Gruszka
2 siblings, 0 replies; 4+ messages in thread
From: Stanislaw Gruszka @ 2023-05-26 7:36 UTC (permalink / raw)
To: Randy Dunlap
Cc: linux-kernel, kernel test robot, Oded Gabbay, dri-devel,
Jacek Lawrynowicz, Andrzej Kacprowski, Krystian Pradzynski,
Jeffrey Hugo, Daniel Vetter
On Thu, May 25, 2023 at 09:45:19PM -0700, Randy Dunlap wrote:
> Drivers that use the gen_pool*() family of functions should
> select GENERIC_ALLOCATOR to prevent build errors like these:
>
> ld: drivers/accel/ivpu/ivpu_ipc.o: in function `gen_pool_free':
> include/linux/genalloc.h:172: undefined reference to `gen_pool_free_owner'
> ld: drivers/accel/ivpu/ivpu_ipc.o: in function `gen_pool_alloc_algo':
> include/linux/genalloc.h:138: undefined reference to `gen_pool_alloc_algo_owner'
> ld: drivers/accel/ivpu/ivpu_ipc.o: in function `gen_pool_free':
> include/linux/genalloc.h:172: undefined reference to `gen_pool_free_owner'
> ld: drivers/accel/ivpu/ivpu_ipc.o: in function `ivpu_ipc_init':
> drivers/accel/ivpu/ivpu_ipc.c:441: undefined reference to `devm_gen_pool_create'
> ld: drivers/accel/ivpu/ivpu_ipc.o: in function `gen_pool_add_virt':
> include/linux/genalloc.h:104: undefined reference to `gen_pool_add_owner'
>
> Fixes: 5d7422cfb498 ("accel/ivpu: Add IPC driver and JSM messages")
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Reported-by: kernel test robot <lkp@intel.com>
> Link: https://lore.kernel.org/all/202305221206.1TaugDKP-lkp@intel.com/
> Cc: Oded Gabbay <ogabbay@kernel.org>
> Cc: dri-devel@lists.freedesktop.org
> Cc: Jacek Lawrynowicz <jacek.lawrynowicz@linux.intel.com>
> Cc: Stanislaw Gruszka <stanislaw.gruszka@linux.intel.com>
> Cc: Andrzej Kacprowski <andrzej.kacprowski@linux.intel.com>
> Cc: Krystian Pradzynski <krystian.pradzynski@linux.intel.com>
> Cc: Jeffrey Hugo <quic_jhugo@quicinc.com>
> Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Acked-by: Stanislaw Gruszka <stanislaw.gruszka@linux.intel.com>
> ---
> drivers/accel/ivpu/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff -- a/drivers/accel/ivpu/Kconfig b/drivers/accel/ivpu/Kconfig
> --- a/drivers/accel/ivpu/Kconfig
> +++ b/drivers/accel/ivpu/Kconfig
> @@ -7,6 +7,7 @@ config DRM_ACCEL_IVPU
> depends on PCI && PCI_MSI
> select FW_LOADER
> select SHMEM
> + select GENERIC_ALLOCATOR
> help
> Choose this option if you have a system that has an 14th generation Intel CPU
> or newer. VPU stands for Versatile Processing Unit and it's a CPU-integrated
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] accel/ivpu: ivpu_ipc needs GENERIC_ALLOCATOR
2023-05-26 4:45 [PATCH] accel/ivpu: ivpu_ipc needs GENERIC_ALLOCATOR Randy Dunlap
2023-05-26 7:36 ` Stanislaw Gruszka
@ 2023-06-02 17:21 ` Jeffrey Hugo
2023-06-06 12:35 ` Stanislaw Gruszka
2 siblings, 0 replies; 4+ messages in thread
From: Jeffrey Hugo @ 2023-06-02 17:21 UTC (permalink / raw)
To: Randy Dunlap, linux-kernel
Cc: kernel test robot, Oded Gabbay, dri-devel, Jacek Lawrynowicz,
Stanislaw Gruszka, Andrzej Kacprowski, Krystian Pradzynski,
Daniel Vetter
On 5/25/2023 10:45 PM, Randy Dunlap wrote:
> Drivers that use the gen_pool*() family of functions should
> select GENERIC_ALLOCATOR to prevent build errors like these:
>
> ld: drivers/accel/ivpu/ivpu_ipc.o: in function `gen_pool_free':
> include/linux/genalloc.h:172: undefined reference to `gen_pool_free_owner'
> ld: drivers/accel/ivpu/ivpu_ipc.o: in function `gen_pool_alloc_algo':
> include/linux/genalloc.h:138: undefined reference to `gen_pool_alloc_algo_owner'
> ld: drivers/accel/ivpu/ivpu_ipc.o: in function `gen_pool_free':
> include/linux/genalloc.h:172: undefined reference to `gen_pool_free_owner'
> ld: drivers/accel/ivpu/ivpu_ipc.o: in function `ivpu_ipc_init':
> drivers/accel/ivpu/ivpu_ipc.c:441: undefined reference to `devm_gen_pool_create'
> ld: drivers/accel/ivpu/ivpu_ipc.o: in function `gen_pool_add_virt':
> include/linux/genalloc.h:104: undefined reference to `gen_pool_add_owner'
>
> Fixes: 5d7422cfb498 ("accel/ivpu: Add IPC driver and JSM messages")
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Reported-by: kernel test robot <lkp@intel.com>
> Link: https://lore.kernel.org/all/202305221206.1TaugDKP-lkp@intel.com/
> Cc: Oded Gabbay <ogabbay@kernel.org>
> Cc: dri-devel@lists.freedesktop.org
> Cc: Jacek Lawrynowicz <jacek.lawrynowicz@linux.intel.com>
> Cc: Stanislaw Gruszka <stanislaw.gruszka@linux.intel.com>
> Cc: Andrzej Kacprowski <andrzej.kacprowski@linux.intel.com>
> Cc: Krystian Pradzynski <krystian.pradzynski@linux.intel.com>
> Cc: Jeffrey Hugo <quic_jhugo@quicinc.com>
> Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Reviewed-by: Jeffrey Hugo <quic_jhugo@quicinc.com>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] accel/ivpu: ivpu_ipc needs GENERIC_ALLOCATOR
2023-05-26 4:45 [PATCH] accel/ivpu: ivpu_ipc needs GENERIC_ALLOCATOR Randy Dunlap
2023-05-26 7:36 ` Stanislaw Gruszka
2023-06-02 17:21 ` Jeffrey Hugo
@ 2023-06-06 12:35 ` Stanislaw Gruszka
2 siblings, 0 replies; 4+ messages in thread
From: Stanislaw Gruszka @ 2023-06-06 12:35 UTC (permalink / raw)
To: Randy Dunlap
Cc: linux-kernel, kernel test robot, Oded Gabbay, dri-devel,
Jacek Lawrynowicz, Andrzej Kacprowski, Krystian Pradzynski,
Jeffrey Hugo, Daniel Vetter
On Thu, May 25, 2023 at 09:45:19PM -0700, Randy Dunlap wrote:
> Drivers that use the gen_pool*() family of functions should
> select GENERIC_ALLOCATOR to prevent build errors like these:
>
> ld: drivers/accel/ivpu/ivpu_ipc.o: in function `gen_pool_free':
> include/linux/genalloc.h:172: undefined reference to `gen_pool_free_owner'
> ld: drivers/accel/ivpu/ivpu_ipc.o: in function `gen_pool_alloc_algo':
> include/linux/genalloc.h:138: undefined reference to `gen_pool_alloc_algo_owner'
> ld: drivers/accel/ivpu/ivpu_ipc.o: in function `gen_pool_free':
> include/linux/genalloc.h:172: undefined reference to `gen_pool_free_owner'
> ld: drivers/accel/ivpu/ivpu_ipc.o: in function `ivpu_ipc_init':
> drivers/accel/ivpu/ivpu_ipc.c:441: undefined reference to `devm_gen_pool_create'
> ld: drivers/accel/ivpu/ivpu_ipc.o: in function `gen_pool_add_virt':
> include/linux/genalloc.h:104: undefined reference to `gen_pool_add_owner'
>
> Fixes: 5d7422cfb498 ("accel/ivpu: Add IPC driver and JSM messages")
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Reported-by: kernel test robot <lkp@intel.com>
> Link: https://lore.kernel.org/all/202305221206.1TaugDKP-lkp@intel.com/
> Cc: Oded Gabbay <ogabbay@kernel.org>
> Cc: dri-devel@lists.freedesktop.org
> Cc: Jacek Lawrynowicz <jacek.lawrynowicz@linux.intel.com>
> Cc: Stanislaw Gruszka <stanislaw.gruszka@linux.intel.com>
> Cc: Andrzej Kacprowski <andrzej.kacprowski@linux.intel.com>
> Cc: Krystian Pradzynski <krystian.pradzynski@linux.intel.com>
> Cc: Jeffrey Hugo <quic_jhugo@quicinc.com>
> Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Applied to drm-misc-fixes
Thanks
Stanislaw
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-06-06 12:35 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-05-26 4:45 [PATCH] accel/ivpu: ivpu_ipc needs GENERIC_ALLOCATOR Randy Dunlap
2023-05-26 7:36 ` Stanislaw Gruszka
2023-06-02 17:21 ` Jeffrey Hugo
2023-06-06 12:35 ` Stanislaw Gruszka
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox