From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A8FCAC77B7A for ; Fri, 26 May 2023 12:35:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230361AbjEZMfW (ORCPT ); Fri, 26 May 2023 08:35:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36334 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230139AbjEZMfU (ORCPT ); Fri, 26 May 2023 08:35:20 -0400 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0BE5FE7F; Fri, 26 May 2023 05:34:56 -0700 (PDT) Received: by verein.lst.de (Postfix, from userid 2407) id 29F416732A; Fri, 26 May 2023 14:34:09 +0200 (CEST) Date: Fri, 26 May 2023 14:34:08 +0200 From: Christoph Hellwig To: Yu Kuai Cc: hch@lst.de, tj@kernel.org, josef@toxicpanda.com, axboe@kernel.dk, lukas.bulwahn@gmail.com, cgroups@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, yi.zhang@huawei.com, yangerkun@huawei.com, "yukuai (C)" Subject: Re: [PATCH -next v2 6/6] blk-sysfs: add a new attr_group for blk_mq Message-ID: <20230526123408.GA4569@lst.de> References: <20230512093554.911753-1-yukuai1@huaweicloud.com> <20230512093554.911753-7-yukuai1@huaweicloud.com> <8cafbd02-182a-4071-7e04-cc6f96045852@huaweicloud.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8cafbd02-182a-4071-7e04-cc6f96045852@huaweicloud.com> User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This patch looks good to me: Reviewed-by: Christoph Hellwig