From: Christoph Hellwig <hch@lst.de>
To: Vincent Whitchurch <vincent.whitchurch@axis.com>
Cc: Phillip Lougher <phillip@squashfs.org.uk>,
Andrew Morton <akpm@linux-foundation.org>,
hch@lst.de, linux-kernel@vger.kernel.org, kernel@axis.com
Subject: Re: [PATCH mm-nonmm-unstable 2/2] squashfs: fix page indices
Date: Fri, 26 May 2023 15:37:10 +0200 [thread overview]
Message-ID: <20230526133710.GC8803@lst.de> (raw)
In-Reply-To: <20230526-squashfs-cache-fixup-v1-2-d54a7fa23e7b@axis.com>
On Fri, May 26, 2023 at 03:25:46PM +0200, Vincent Whitchurch wrote:
> The page cache functions want the page index as an argument but we're
> currently passing in the byte address.
Can you avoid the overly long lines by movning the GFP_NOFS parameters
to the following lines?
The rest look good.
prev parent reply other threads:[~2023-05-26 13:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-26 13:25 [PATCH mm-nonmm-unstable 0/2] squashfs: fixups for caching Vincent Whitchurch
2023-05-26 13:25 ` [PATCH mm-nonmm-unstable 1/2] squashfs: fix page update race Vincent Whitchurch
2023-05-26 13:36 ` Christoph Hellwig
2023-05-26 13:25 ` [PATCH mm-nonmm-unstable 2/2] squashfs: fix page indices Vincent Whitchurch
2023-05-26 13:37 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230526133710.GC8803@lst.de \
--to=hch@lst.de \
--cc=akpm@linux-foundation.org \
--cc=kernel@axis.com \
--cc=linux-kernel@vger.kernel.org \
--cc=phillip@squashfs.org.uk \
--cc=vincent.whitchurch@axis.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox