From: Steven Rostedt <rostedt@goodmis.org>
To: "Masami Hiramatsu (Google)" <mhiramat@kernel.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
x86@kernel.org, Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@kernel.org>, Borislav Petkov <bp@alien8.de>,
Peter Zijlstra <peterz@infradead.org>
Subject: Re: [PATCH] x86/alternatives: Add cond_resched() to text_poke_bp_batch()
Date: Sun, 28 May 2023 23:21:32 -0400 [thread overview]
Message-ID: <20230528232132.14ab3201@rorschach.local.home> (raw)
In-Reply-To: <20230529115246.a61734ce4e6d7644e2faec72@kernel.org>
On Mon, 29 May 2023 11:52:46 +0900
Masami Hiramatsu (Google) <mhiramat@kernel.org> wrote:
> > + /*
> > + * Function tracing can enable thousands of places that need to be
> > + * updated. This can take quite some time, and with full kernel debugging
> > + * enabled, this could cause the softlockup watchdog to trigger.
> > + * Add cond_resched() calls to each phase.
> > + */
> > + cond_resched();
>
> Hmm, why don't you put this between the first step (put int3) and the
> second step (put other bytes)? I guess those would takes more time.
Ah you're right. I still want this here to clear the 'need resched'
flag before we start the process, but I did miss one after the first
loop.
Thanks for the review!
-- Steve
next prev parent reply other threads:[~2023-05-29 3:21 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-28 12:46 [PATCH] x86/alternatives: Add cond_resched() to text_poke_bp_batch() Steven Rostedt
2023-05-29 2:52 ` Masami Hiramatsu
2023-05-29 3:21 ` Steven Rostedt [this message]
2023-05-30 12:01 ` Peter Zijlstra
2023-05-30 12:35 ` Steven Rostedt
2023-05-31 9:08 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230528232132.14ab3201@rorschach.local.home \
--to=rostedt@goodmis.org \
--cc=bp@alien8.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox