From: Conor Dooley <conor@kernel.org>
To: Florian Fainelli <florian.fainelli@broadcom.com>
Cc: stable@vger.kernel.org, Pierre Gondois <pierre.gondois@arm.com>,
Conor Dooley <conor.dooley@microchip.com>,
Sudeep Holla <sudeep.holla@arm.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
"open list:GENERIC ARCHITECTURE TOPOLOGY"
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH stable 6.3 v2] arch_topology: Remove early cacheinfo error message if -ENOENT
Date: Tue, 30 May 2023 22:39:00 +0100 [thread overview]
Message-ID: <20230530-basically-wildly-84415a94171d@spud> (raw)
In-Reply-To: <20230530201955.848176-1-florian.fainelli@broadcom.com>
Yo Florian,
On Tue, May 30, 2023 at 01:19:55PM -0700, Florian Fainelli wrote:
> From: Pierre Gondois <pierre.gondois@arm.com>
>
> commit 3522340199cc060b70f0094e3039bdb43c3f6ee1 upstream
>
> fetch_cache_info() tries to get the number of cache leaves/levels
> for each CPU in order to pre-allocate memory for cacheinfo struct.
> Allocating this memory later triggers a:
> 'BUG: sleeping function called from invalid context'
> in PREEMPT_RT kernels.
>
> If there is no cache related information available in DT or ACPI,
> fetch_cache_info() fails and an error message is printed:
> 'Early cacheinfo failed, ret = ...'
>
> Not having cache information should be a valid configuration.
> Remove the error message if fetch_cache_info() fails with -ENOENT.
>
> Suggested-by: Conor Dooley <conor.dooley@microchip.com>
> Link: https://lore.kernel.org/all/20230404-hatred-swimmer-6fecdf33b57a@spud/
> Signed-off-by: Pierre Gondois <pierre.gondois@arm.com>
> Reviewed-by: Conor Dooley <conor.dooley@microchip.com>
> Link: https://lore.kernel.org/r/20230414081453.244787-4-pierre.gondois@arm.com
> Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
> Signed-off-by: Florian Fainelli <florian.fainelli@broadcom.com>
How come this now needs a backport? Did the rest of the series get
backported, but not this one since it has no fixes tag?
Cheers,
Conor.
next prev parent reply other threads:[~2023-05-30 21:39 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-30 20:19 [PATCH stable 6.3 v2] arch_topology: Remove early cacheinfo error message if -ENOENT Florian Fainelli
2023-05-30 21:39 ` Conor Dooley [this message]
2023-05-30 22:42 ` Florian Fainelli
2023-05-31 8:53 ` Sudeep Holla
2023-05-31 9:26 ` Conor Dooley
2023-05-31 15:28 ` Florian Fainelli
2023-05-31 15:43 ` Sudeep Holla
[not found] ` <0f2e3a2b-477b-cbd7-e756-4b3f4df8e045@broadcom.com>
2023-06-01 6:32 ` Sudeep Holla
2023-06-01 10:25 ` Greg Kroah-Hartman
2023-06-01 10:25 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230530-basically-wildly-84415a94171d@spud \
--to=conor@kernel.org \
--cc=conor.dooley@microchip.com \
--cc=florian.fainelli@broadcom.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pierre.gondois@arm.com \
--cc=rafael@kernel.org \
--cc=stable@vger.kernel.org \
--cc=sudeep.holla@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox