* [PATCH] riscv: vector: Fixup modules compile error @ 2023-05-29 7:38 guoren 2023-05-29 13:42 ` Conor Dooley 0 siblings, 1 reply; 9+ messages in thread From: guoren @ 2023-05-29 7:38 UTC (permalink / raw) To: guoren, greentime.hu, vincent.chen, andy.chiu, paul.walmsley, palmer Cc: linux-riscv, linux-kernel, Guo Ren From: Guo Ren <guoren@linux.alibaba.com> Some .ko also need the riscv_v_user_allowed symbol. ERROR: modpost: "riscv_v_user_allowed" [arch/riscv/kvm/kvm.ko] undefined! make[3]: *** [/home/guoren/source/kernel/linux/scripts/Makefile.modpost:136: Module.symvers] Error 1 Signed-off-by: Guo Ren <guoren@linux.alibaba.com> Signed-off-by: Guo Ren <guoren@kernel.org> --- arch/riscv/kernel/vector.c | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/riscv/kernel/vector.c b/arch/riscv/kernel/vector.c index 1c4ac821e008..3ae08816d608 100644 --- a/arch/riscv/kernel/vector.c +++ b/arch/riscv/kernel/vector.c @@ -129,6 +129,7 @@ bool riscv_v_user_allowed(void) { return riscv_v_get_cur_ctrl(current) == PR_RISCV_V_VSTATE_CTRL_ON; } +EXPORT_SYMBOL(riscv_v_user_allowed); bool riscv_v_first_use_handler(struct pt_regs *regs) { -- 2.36.1 ^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH] riscv: vector: Fixup modules compile error 2023-05-29 7:38 [PATCH] riscv: vector: Fixup modules compile error guoren @ 2023-05-29 13:42 ` Conor Dooley 2023-05-30 2:59 ` Guo Ren 0 siblings, 1 reply; 9+ messages in thread From: Conor Dooley @ 2023-05-29 13:42 UTC (permalink / raw) To: guoren Cc: greentime.hu, vincent.chen, andy.chiu, paul.walmsley, palmer, linux-riscv, linux-kernel, Guo Ren [-- Attachment #1: Type: text/plain, Size: 1061 bytes --] On Mon, May 29, 2023 at 03:38:45AM -0400, guoren@kernel.org wrote: > From: Guo Ren <guoren@linux.alibaba.com> > > Some .ko also need the riscv_v_user_allowed symbol. > > ERROR: modpost: "riscv_v_user_allowed" [arch/riscv/kvm/kvm.ko] > undefined! > make[3]: *** > [/home/guoren/source/kernel/linux/scripts/Makefile.modpost:136: > Module.symvers] Error 1 > > Signed-off-by: Guo Ren <guoren@linux.alibaba.com> > Signed-off-by: Guo Ren <guoren@kernel.org> > --- > arch/riscv/kernel/vector.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/riscv/kernel/vector.c b/arch/riscv/kernel/vector.c > index 1c4ac821e008..3ae08816d608 100644 > --- a/arch/riscv/kernel/vector.c > +++ b/arch/riscv/kernel/vector.c > @@ -129,6 +129,7 @@ bool riscv_v_user_allowed(void) > { > return riscv_v_get_cur_ctrl(current) == PR_RISCV_V_VSTATE_CTRL_ON; > } > +EXPORT_SYMBOL(riscv_v_user_allowed); Is there a reason that this should not be EXPORT_SYMBOL_GPL()? I figure Andy will roll this into this next revision.. Cheers, Conor. [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 228 bytes --] ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] riscv: vector: Fixup modules compile error 2023-05-29 13:42 ` Conor Dooley @ 2023-05-30 2:59 ` Guo Ren 2023-05-30 6:52 ` Guo Ren 0 siblings, 1 reply; 9+ messages in thread From: Guo Ren @ 2023-05-30 2:59 UTC (permalink / raw) To: Conor Dooley Cc: greentime.hu, vincent.chen, andy.chiu, paul.walmsley, palmer, linux-riscv, linux-kernel, Guo Ren On Mon, May 29, 2023 at 9:43 PM Conor Dooley <conor.dooley@microchip.com> wrote: > > On Mon, May 29, 2023 at 03:38:45AM -0400, guoren@kernel.org wrote: > > From: Guo Ren <guoren@linux.alibaba.com> > > > > Some .ko also need the riscv_v_user_allowed symbol. > > > > ERROR: modpost: "riscv_v_user_allowed" [arch/riscv/kvm/kvm.ko] > > undefined! > > make[3]: *** > > [/home/guoren/source/kernel/linux/scripts/Makefile.modpost:136: > > Module.symvers] Error 1 > > > > Signed-off-by: Guo Ren <guoren@linux.alibaba.com> > > Signed-off-by: Guo Ren <guoren@kernel.org> > > --- > > arch/riscv/kernel/vector.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/arch/riscv/kernel/vector.c b/arch/riscv/kernel/vector.c > > index 1c4ac821e008..3ae08816d608 100644 > > --- a/arch/riscv/kernel/vector.c > > +++ b/arch/riscv/kernel/vector.c > > @@ -129,6 +129,7 @@ bool riscv_v_user_allowed(void) > > { > > return riscv_v_get_cur_ctrl(current) == PR_RISCV_V_VSTATE_CTRL_ON; > > } > > +EXPORT_SYMBOL(riscv_v_user_allowed); > > Is there a reason that this should not be EXPORT_SYMBOL_GPL()? Good question, but I just follow our arch/riscv habbit, maybe we should change all of that in another patch. ➜ linux-s64ilp32 git:(s64ilp32) ✗ grep EXPORT_SYMBOL arch/riscv -r | wc -l 66 ➜ linux-s64ilp32 git:(s64ilp32) ✗ grep EXPORT_SYMBOL_GPL arch/riscv -r | wc -l 15 > > I figure Andy will roll this into this next revision. > > Cheers, > Conor. -- Best Regards Guo Ren ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] riscv: vector: Fixup modules compile error 2023-05-30 2:59 ` Guo Ren @ 2023-05-30 6:52 ` Guo Ren 2023-05-30 9:48 ` Andy Chiu 0 siblings, 1 reply; 9+ messages in thread From: Guo Ren @ 2023-05-30 6:52 UTC (permalink / raw) To: Conor Dooley Cc: greentime.hu, vincent.chen, andy.chiu, paul.walmsley, palmer, linux-riscv, linux-kernel, Guo Ren On Tue, May 30, 2023 at 10:59 AM Guo Ren <guoren@kernel.org> wrote: > > On Mon, May 29, 2023 at 9:43 PM Conor Dooley <conor.dooley@microchip.com> wrote: > > > > On Mon, May 29, 2023 at 03:38:45AM -0400, guoren@kernel.org wrote: > > > From: Guo Ren <guoren@linux.alibaba.com> > > > > > > Some .ko also need the riscv_v_user_allowed symbol. > > > > > > ERROR: modpost: "riscv_v_user_allowed" [arch/riscv/kvm/kvm.ko] > > > undefined! > > > make[3]: *** > > > [/home/guoren/source/kernel/linux/scripts/Makefile.modpost:136: > > > Module.symvers] Error 1 > > > > > > Signed-off-by: Guo Ren <guoren@linux.alibaba.com> > > > Signed-off-by: Guo Ren <guoren@kernel.org> > > > --- > > > arch/riscv/kernel/vector.c | 1 + > > > 1 file changed, 1 insertion(+) > > > > > > diff --git a/arch/riscv/kernel/vector.c b/arch/riscv/kernel/vector.c > > > index 1c4ac821e008..3ae08816d608 100644 > > > --- a/arch/riscv/kernel/vector.c > > > +++ b/arch/riscv/kernel/vector.c > > > @@ -129,6 +129,7 @@ bool riscv_v_user_allowed(void) > > > { > > > return riscv_v_get_cur_ctrl(current) == PR_RISCV_V_VSTATE_CTRL_ON; > > > } > > > +EXPORT_SYMBOL(riscv_v_user_allowed); > > > > Is there a reason that this should not be EXPORT_SYMBOL_GPL()? > Good question, but I just follow our arch/riscv habbit, maybe we > should change all of that in another patch. > > ➜ linux-s64ilp32 git:(s64ilp32) ✗ grep EXPORT_SYMBOL arch/riscv -r | wc -l > 66 > ➜ linux-s64ilp32 git:(s64ilp32) ✗ grep EXPORT_SYMBOL_GPL arch/riscv -r | wc -l > 15 Why !MODULE_LICENSE(GPL) modules couldn't use riscv_v_user_allowed? Seems EXPORT_SYMBOL_GPL has more limitations. :c:func:`EXPORT_SYMBOL_GPL()` ----------------------------- Defined in ``include/linux/export.h`` Similar to :c:func:`EXPORT_SYMBOL()` except that the symbols exported by :c:func:`EXPORT_SYMBOL_GPL()` can only be seen by modules with a :c:func:`MODULE_LICENSE()` that specifies a GPL compatible license. It implies that the function is considered an internal implementation issue, and not really an interface. Some maintainers and developers may however require EXPORT_SYMBOL_GPL() when adding any new APIs or functionality. For kvm is okay: MODULE_AUTHOR("Qumranet"); MODULE_LICENSE("GPL"); So, I would leave the decition to Andy. If he didn't want it used with other non-gpl modules, choose the EXPORT_SYMBOL_GPL. > > > > > I figure Andy will roll this into this next revision. > > > > Cheers, > > Conor. > > > > -- > Best Regards > Guo Ren -- Best Regards Guo Ren ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] riscv: vector: Fixup modules compile error 2023-05-30 6:52 ` Guo Ren @ 2023-05-30 9:48 ` Andy Chiu 2023-05-30 15:37 ` Guo Ren 0 siblings, 1 reply; 9+ messages in thread From: Andy Chiu @ 2023-05-30 9:48 UTC (permalink / raw) To: Guo Ren Cc: Conor Dooley, greentime.hu, vincent.chen, paul.walmsley, palmer, linux-riscv, linux-kernel, Guo Ren On Tue, May 30, 2023 at 2:52 PM Guo Ren <guoren@kernel.org> wrote: > > On Tue, May 30, 2023 at 10:59 AM Guo Ren <guoren@kernel.org> wrote: > > > > On Mon, May 29, 2023 at 9:43 PM Conor Dooley <conor.dooley@microchip.com> wrote: > > > > > > On Mon, May 29, 2023 at 03:38:45AM -0400, guoren@kernel.org wrote: > > > > From: Guo Ren <guoren@linux.alibaba.com> > > > > > > > > Some .ko also need the riscv_v_user_allowed symbol. > > > > > > > > ERROR: modpost: "riscv_v_user_allowed" [arch/riscv/kvm/kvm.ko] > > > > undefined! > > > > make[3]: *** > > > > [/home/guoren/source/kernel/linux/scripts/Makefile.modpost:136: > > > > Module.symvers] Error 1 > > > > > > > > Signed-off-by: Guo Ren <guoren@linux.alibaba.com> > > > > Signed-off-by: Guo Ren <guoren@kernel.org> > > > > --- > > > > arch/riscv/kernel/vector.c | 1 + > > > > 1 file changed, 1 insertion(+) > > > > > > > > diff --git a/arch/riscv/kernel/vector.c b/arch/riscv/kernel/vector.c > > > > index 1c4ac821e008..3ae08816d608 100644 > > > > --- a/arch/riscv/kernel/vector.c > > > > +++ b/arch/riscv/kernel/vector.c > > > > @@ -129,6 +129,7 @@ bool riscv_v_user_allowed(void) > > > > { > > > > return riscv_v_get_cur_ctrl(current) == PR_RISCV_V_VSTATE_CTRL_ON; > > > > } > > > > +EXPORT_SYMBOL(riscv_v_user_allowed); > > > > > > Is there a reason that this should not be EXPORT_SYMBOL_GPL()? > > Good question, but I just follow our arch/riscv habbit, maybe we > > should change all of that in another patch. > > > > ➜ linux-s64ilp32 git:(s64ilp32) ✗ grep EXPORT_SYMBOL arch/riscv -r | wc -l > > 66 > > ➜ linux-s64ilp32 git:(s64ilp32) ✗ grep EXPORT_SYMBOL_GPL arch/riscv -r | wc -l > > 15 > > Why !MODULE_LICENSE(GPL) modules couldn't use riscv_v_user_allowed? > Seems EXPORT_SYMBOL_GPL has more limitations. > > :c:func:`EXPORT_SYMBOL_GPL()` > ----------------------------- > > Defined in ``include/linux/export.h`` > > Similar to :c:func:`EXPORT_SYMBOL()` except that the symbols > exported by :c:func:`EXPORT_SYMBOL_GPL()` can only be seen by > modules with a :c:func:`MODULE_LICENSE()` that specifies a GPL > compatible license. It implies that the function is considered an > internal implementation issue, and not really an interface. Some > maintainers and developers may however require EXPORT_SYMBOL_GPL() > when adding any new APIs or functionality. > > For kvm is okay: > > MODULE_AUTHOR("Qumranet"); > MODULE_LICENSE("GPL"); > > So, I would leave the decition to Andy. If he didn't want it used with > other non-gpl modules, choose the EXPORT_SYMBOL_GPL. Do you have any use case for exporting this function to non-GPL licensed modules? I exported the function with EXPORT_SYMBOL_GPL() in v20[1] because I thought most maintainers would accept GPL rather than non-GPL one. And it seems most drivers would never call this function anyway. > > > > > > > > > I figure Andy will roll this into this next revision. The fix for this has been included in v20[1]. However, I also changed the function name s/riscv_v_user_allowed/riscv_v_vstate_ctrl_user_allowed/. > > > > > > Cheers, > > > Conor. > > > > > > > > -- > > Best Regards > > Guo Ren > > > > -- > Best Regards > Guo Ren [1]: https://lore.kernel.org/all/20230518161949.11203-21-andy.chiu@sifive.com/ Cheers, Andy ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] riscv: vector: Fixup modules compile error 2023-05-30 9:48 ` Andy Chiu @ 2023-05-30 15:37 ` Guo Ren 2023-05-30 16:04 ` Conor Dooley 0 siblings, 1 reply; 9+ messages in thread From: Guo Ren @ 2023-05-30 15:37 UTC (permalink / raw) To: Andy Chiu Cc: Conor Dooley, greentime.hu, vincent.chen, paul.walmsley, palmer, linux-riscv, linux-kernel, Guo Ren On Tue, May 30, 2023 at 5:49 PM Andy Chiu <andy.chiu@sifive.com> wrote: > > On Tue, May 30, 2023 at 2:52 PM Guo Ren <guoren@kernel.org> wrote: > > > > On Tue, May 30, 2023 at 10:59 AM Guo Ren <guoren@kernel.org> wrote: > > > > > > On Mon, May 29, 2023 at 9:43 PM Conor Dooley <conor.dooley@microchip.com> wrote: > > > > > > > > On Mon, May 29, 2023 at 03:38:45AM -0400, guoren@kernel.org wrote: > > > > > From: Guo Ren <guoren@linux.alibaba.com> > > > > > > > > > > Some .ko also need the riscv_v_user_allowed symbol. > > > > > > > > > > ERROR: modpost: "riscv_v_user_allowed" [arch/riscv/kvm/kvm.ko] > > > > > undefined! > > > > > make[3]: *** > > > > > [/home/guoren/source/kernel/linux/scripts/Makefile.modpost:136: > > > > > Module.symvers] Error 1 > > > > > > > > > > Signed-off-by: Guo Ren <guoren@linux.alibaba.com> > > > > > Signed-off-by: Guo Ren <guoren@kernel.org> > > > > > --- > > > > > arch/riscv/kernel/vector.c | 1 + > > > > > 1 file changed, 1 insertion(+) > > > > > > > > > > diff --git a/arch/riscv/kernel/vector.c b/arch/riscv/kernel/vector.c > > > > > index 1c4ac821e008..3ae08816d608 100644 > > > > > --- a/arch/riscv/kernel/vector.c > > > > > +++ b/arch/riscv/kernel/vector.c > > > > > @@ -129,6 +129,7 @@ bool riscv_v_user_allowed(void) > > > > > { > > > > > return riscv_v_get_cur_ctrl(current) == PR_RISCV_V_VSTATE_CTRL_ON; > > > > > } > > > > > +EXPORT_SYMBOL(riscv_v_user_allowed); > > > > > > > > Is there a reason that this should not be EXPORT_SYMBOL_GPL()? > > > Good question, but I just follow our arch/riscv habbit, maybe we > > > should change all of that in another patch. > > > > > > ➜ linux-s64ilp32 git:(s64ilp32) ✗ grep EXPORT_SYMBOL arch/riscv -r | wc -l > > > 66 > > > ➜ linux-s64ilp32 git:(s64ilp32) ✗ grep EXPORT_SYMBOL_GPL arch/riscv -r | wc -l > > > 15 > > > > Why !MODULE_LICENSE(GPL) modules couldn't use riscv_v_user_allowed? > > Seems EXPORT_SYMBOL_GPL has more limitations. > > > > :c:func:`EXPORT_SYMBOL_GPL()` > > ----------------------------- > > > > Defined in ``include/linux/export.h`` > > > > Similar to :c:func:`EXPORT_SYMBOL()` except that the symbols > > exported by :c:func:`EXPORT_SYMBOL_GPL()` can only be seen by > > modules with a :c:func:`MODULE_LICENSE()` that specifies a GPL > > compatible license. It implies that the function is considered an > > internal implementation issue, and not really an interface. Some > > maintainers and developers may however require EXPORT_SYMBOL_GPL() > > when adding any new APIs or functionality. > > > > For kvm is okay: > > > > MODULE_AUTHOR("Qumranet"); > > MODULE_LICENSE("GPL"); > > > > So, I would leave the decition to Andy. If he didn't want it used with > > other non-gpl modules, choose the EXPORT_SYMBOL_GPL. > > Do you have any use case for exporting this function to non-GPL > licensed modules? I exported the function with EXPORT_SYMBOL_GPL() in > v20[1] because I thought most maintainers would accept GPL rather than > non-GPL one. And it seems most drivers would never call this function > anyway. I just found Linux-next build is broken, so I sent the patch. It seems you've solved that. That's okay. > > > > > > > > > > > > > > I figure Andy will roll this into this next revision. > > The fix for this has been included in v20[1]. However, I also changed > the function name > s/riscv_v_user_allowed/riscv_v_vstate_ctrl_user_allowed/. > > > > > > > > > Cheers, > > > > Conor. > > > > > > > > > > > > -- > > > Best Regards > > > Guo Ren > > > > > > > > -- > > Best Regards > > Guo Ren > > [1]: https://lore.kernel.org/all/20230518161949.11203-21-andy.chiu@sifive.com/ > > Cheers, > Andy -- Best Regards Guo Ren ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] riscv: vector: Fixup modules compile error 2023-05-30 15:37 ` Guo Ren @ 2023-05-30 16:04 ` Conor Dooley 2023-05-30 16:14 ` Guo Ren 0 siblings, 1 reply; 9+ messages in thread From: Conor Dooley @ 2023-05-30 16:04 UTC (permalink / raw) To: Guo Ren Cc: Andy Chiu, Conor Dooley, greentime.hu, vincent.chen, paul.walmsley, palmer, linux-riscv, linux-kernel, Guo Ren [-- Attachment #1: Type: text/plain, Size: 265 bytes --] On Tue, May 30, 2023 at 11:37:38PM +0800, Guo Ren wrote: > I just found Linux-next build is broken, so I sent the patch. It seems > you've solved that. That's okay. Are you sure that linux-next is broken because of this? This series should not be in linux-next... [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 228 bytes --] ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] riscv: vector: Fixup modules compile error 2023-05-30 16:04 ` Conor Dooley @ 2023-05-30 16:14 ` Guo Ren 2023-05-30 16:22 ` Guo Ren 0 siblings, 1 reply; 9+ messages in thread From: Guo Ren @ 2023-05-30 16:14 UTC (permalink / raw) To: Conor Dooley Cc: Andy Chiu, Conor Dooley, greentime.hu, vincent.chen, paul.walmsley, palmer, linux-riscv, linux-kernel, Guo Ren On Wed, May 31, 2023 at 12:04 AM Conor Dooley <conor@kernel.org> wrote: > > On Tue, May 30, 2023 at 11:37:38PM +0800, Guo Ren wrote: > > I just found Linux-next build is broken, so I sent the patch. It seems > > you've solved that. That's okay. > > Are you sure that linux-next is broken because of this? > This series should not be in linux-next... I mean: https://git.kernel.org/pub/scm/linux/kernel/git/palmer/linux.git/log/?h=for-next -- Best Regards Guo Ren ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] riscv: vector: Fixup modules compile error 2023-05-30 16:14 ` Guo Ren @ 2023-05-30 16:22 ` Guo Ren 0 siblings, 0 replies; 9+ messages in thread From: Guo Ren @ 2023-05-30 16:22 UTC (permalink / raw) To: Conor Dooley Cc: Andy Chiu, Conor Dooley, greentime.hu, vincent.chen, paul.walmsley, palmer, linux-riscv, linux-kernel, Guo Ren On Wed, May 31, 2023 at 12:14 AM Guo Ren <guoren@kernel.org> wrote: > > On Wed, May 31, 2023 at 12:04 AM Conor Dooley <conor@kernel.org> wrote: > > > > On Tue, May 30, 2023 at 11:37:38PM +0800, Guo Ren wrote: > > > I just found Linux-next build is broken, so I sent the patch. It seems > > > you've solved that. That's okay. > > > > Are you sure that linux-next is broken because of this? > > This series should not be in linux-next... > I mean: > > https://git.kernel.org/pub/scm/linux/kernel/git/palmer/linux.git/log/?h=for-next I would change it to +risc-v git git://git.kernel.org/pub/scm/linux/kernel/git/riscv/linux.git#for-next next. > > > > -- > Best Regards > Guo Ren -- Best Regards Guo Ren ^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2023-05-30 16:23 UTC | newest] Thread overview: 9+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2023-05-29 7:38 [PATCH] riscv: vector: Fixup modules compile error guoren 2023-05-29 13:42 ` Conor Dooley 2023-05-30 2:59 ` Guo Ren 2023-05-30 6:52 ` Guo Ren 2023-05-30 9:48 ` Andy Chiu 2023-05-30 15:37 ` Guo Ren 2023-05-30 16:04 ` Conor Dooley 2023-05-30 16:14 ` Guo Ren 2023-05-30 16:22 ` Guo Ren
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox