* [PATCH] usb: typec: tps6598x: Fix broken polling mode after system suspend/resume
@ 2023-05-30 6:59 Roger Quadros
2023-05-30 8:26 ` Heikki Krogerus
0 siblings, 1 reply; 2+ messages in thread
From: Roger Quadros @ 2023-05-30 6:59 UTC (permalink / raw)
To: gregkh, heikki.krogerus
Cc: r-gunasekaran, linux-usb, linux-kernel, Roger Quadros
During system resume we need to resume the polling workqueue
if client->irq is not set else polling will no longer work.
Fixes: 0d6a119cecd7 ("usb: typec: tps6598x: Add support for polling interrupts status")
Signed-off-by: Roger Quadros <rogerq@kernel.org>
---
drivers/usb/typec/tipd/core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/typec/tipd/core.c b/drivers/usb/typec/tipd/core.c
index 438cc40660a1..603dbd44deba 100644
--- a/drivers/usb/typec/tipd/core.c
+++ b/drivers/usb/typec/tipd/core.c
@@ -920,7 +920,7 @@ static int __maybe_unused tps6598x_resume(struct device *dev)
enable_irq(client->irq);
}
- if (client->irq)
+ if (!client->irq)
queue_delayed_work(system_power_efficient_wq, &tps->wq_poll,
msecs_to_jiffies(POLL_INTERVAL));
--
2.34.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] usb: typec: tps6598x: Fix broken polling mode after system suspend/resume
2023-05-30 6:59 [PATCH] usb: typec: tps6598x: Fix broken polling mode after system suspend/resume Roger Quadros
@ 2023-05-30 8:26 ` Heikki Krogerus
0 siblings, 0 replies; 2+ messages in thread
From: Heikki Krogerus @ 2023-05-30 8:26 UTC (permalink / raw)
To: Roger Quadros; +Cc: gregkh, r-gunasekaran, linux-usb, linux-kernel
On Tue, May 30, 2023 at 09:59:26AM +0300, Roger Quadros wrote:
> During system resume we need to resume the polling workqueue
> if client->irq is not set else polling will no longer work.
>
> Fixes: 0d6a119cecd7 ("usb: typec: tps6598x: Add support for polling interrupts status")
> Signed-off-by: Roger Quadros <rogerq@kernel.org>
Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
> ---
> drivers/usb/typec/tipd/core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/typec/tipd/core.c b/drivers/usb/typec/tipd/core.c
> index 438cc40660a1..603dbd44deba 100644
> --- a/drivers/usb/typec/tipd/core.c
> +++ b/drivers/usb/typec/tipd/core.c
> @@ -920,7 +920,7 @@ static int __maybe_unused tps6598x_resume(struct device *dev)
> enable_irq(client->irq);
> }
>
> - if (client->irq)
> + if (!client->irq)
> queue_delayed_work(system_power_efficient_wq, &tps->wq_poll,
> msecs_to_jiffies(POLL_INTERVAL));
>
> --
> 2.34.1
--
heikki
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-05-30 8:26 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-05-30 6:59 [PATCH] usb: typec: tps6598x: Fix broken polling mode after system suspend/resume Roger Quadros
2023-05-30 8:26 ` Heikki Krogerus
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox