From: fl.scratchpad@gmail.com
To: jic23@kernel.org
Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
Fabrizio Lamarque <fl.scratchpad@gmail.com>
Subject: [PATCH v3 0/5] Fix ad7192 driver issues
Date: Tue, 30 May 2023 09:53:06 +0200 [thread overview]
Message-ID: <20230530075311.400686-1-fl.scratchpad@gmail.com> (raw)
From: Fabrizio Lamarque <fl.scratchpad@gmail.com>
Here is a patch set to overcome a number of issues in current ad7192
adc driver implementation prevending the driver to be loaded and
behave correctly:
- null pointer dereference causing kernel panic on driver probe;
- wrong internal clock selection;
- use of "avdd" regulator name in place of vref (reference voltage);
- missing clock options in bindings docs only (already implemented).
The first two issues are regressions.
Backported patches have been tested on a platform with an ARM Cortex-A7
CPU from NXP with kernel 5.15.
As a side note, on the tested platform there is still an issue with a
pending interrupt that I worked around by setting the DRDY IRQ
to LEVEL in place of EDGE sensing. Also, setting IRQ_DISABLE_UNLAZY
flag does not help in my case.
You may find further information here:
https://lore.kernel.org/all/CAPJMGm4GaSjD6bdqMwCr2EVZGenWzT-nCCf3BMRaD1TSfAabpA@mail.gmail.com/
Version log:
v2->v3
- Reworded commit messages
- Split binding fixes
v1->v2
- Obtained ad7192_state from iio_dev pointer
- Added patch on bindings documentation
Fabrizio Lamarque (5):
iio: adc: ad7192: Fix null ad7192_state pointer access
iio: adc: ad7192: Fix internal/external clock selection
iio: adc: ad7192: Use VRef instead of AVdd as reference voltage source
dt-bindings: iio: ad7192: Add mandatory reference voltage source
dt-bindings: iio: ad7192: Allow selection of clock modes
.../bindings/iio/adc/adi,ad7192.yaml | 32 +++++++++++++++++--
drivers/iio/adc/ad7192.c | 31 +++++++++++++++---
2 files changed, 55 insertions(+), 8 deletions(-)
--
2.34.1
next reply other threads:[~2023-05-30 7:53 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-30 7:53 fl.scratchpad [this message]
2023-05-30 7:53 ` [PATCH v3 1/5] iio: adc: ad7192: Fix null ad7192_state pointer access fl.scratchpad
2023-06-04 11:32 ` Jonathan Cameron
2023-05-30 7:53 ` [PATCH v3 2/5] iio: adc: ad7192: Fix internal/external clock selection fl.scratchpad
2023-06-04 11:33 ` Jonathan Cameron
2023-05-30 7:53 ` [PATCH v3 3/5] iio: adc: ad7192: Use VRef instead of AVdd as reference voltage source fl.scratchpad
2023-06-03 12:03 ` andy.shevchenko
2023-05-30 7:53 ` [PATCH v3 4/5] dt-bindings: iio: ad7192: Add mandatory " fl.scratchpad
2023-05-30 17:22 ` Conor Dooley
2023-06-04 11:35 ` Jonathan Cameron
2023-05-30 7:53 ` [PATCH v3 5/5] dt-bindings: iio: ad7192: Allow selection of clock modes fl.scratchpad
2023-05-30 17:22 ` Conor Dooley
2023-05-31 6:59 ` Fabrizio Lamarque
2023-05-31 7:14 ` Krzysztof Kozlowski
2023-05-31 9:40 ` Fabrizio Lamarque
2023-05-31 12:56 ` Conor Dooley
[not found] ` <01dae949-4018-37f4-2dd9-cbecbd65b9a1@linaro.org>
2023-06-07 7:40 ` Fabrizio Lamarque
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230530075311.400686-1-fl.scratchpad@gmail.com \
--to=fl.scratchpad@gmail.com \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox