From: Yue Hu <zbestahu@gmail.com>
To: Gao Xiang <hsiangkao@linux.alibaba.com>
Cc: linux-erofs@lists.ozlabs.org, LKML <linux-kernel@vger.kernel.org>,
huyue2@coolpad.com
Subject: Re: [PATCH v3 5/6] erofs: use struct lockref to replace handcrafted approach
Date: Tue, 30 May 2023 11:59:12 +0800 [thread overview]
Message-ID: <20230530115912.0000195a.zbestahu@gmail.com> (raw)
In-Reply-To: <20230529123727.79943-1-hsiangkao@linux.alibaba.com>
On Mon, 29 May 2023 20:37:27 +0800
Gao Xiang <hsiangkao@linux.alibaba.com> wrote:
> Let's avoid the current handcrafted lockref although `struct lockref`
> inclusion usually increases extra 4 bytes with an explicit spinlock if
> CONFIG_DEBUG_SPINLOCK is off.
>
> Apart from the size difference, note that the meaning of refcount is
> also changed to active users. IOWs, it doesn't take an extra refcount
> for XArray tree insertion.
>
> I don't observe any significant performance difference at least on
> our cloud compute server but the new one indeed simplifies the
> overall codebase a bit.
>
> Signed-off-by: Gao Xiang <hsiangkao@linux.alibaba.com>
Reviewed-by: Yue Hu <huyue2@coolpad.com>
next prev parent reply other threads:[~2023-05-30 3:51 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-26 20:14 [PATCH 0/6] erofs: random cleanups and fixes Gao Xiang
2023-05-26 20:14 ` [PATCH 1/6] erofs: allocate extra bvec pages directly instead of retrying Gao Xiang
2023-05-26 20:14 ` [PATCH 2/6] erofs: avoid on-stack pagepool directly passed by arguments Gao Xiang
2023-05-26 20:14 ` [PATCH 3/6] erofs: kill hooked chains to avoid loops on deduplicated compressed images Gao Xiang
2023-05-26 20:14 ` [PATCH 4/6] erofs: adapt managed inode operations into folios Gao Xiang
2023-05-26 20:14 ` [PATCH 5/6] erofs: use struct lockref to replace handcrafted approach Gao Xiang
2023-05-29 7:29 ` [PATCH v2 " Gao Xiang
2023-05-29 9:16 ` Yue Hu
2023-05-29 9:25 ` Gao Xiang
2023-05-29 12:37 ` [PATCH v3 " Gao Xiang
2023-05-30 3:59 ` Yue Hu [this message]
2023-05-26 20:14 ` [PATCH 6/6] erofs: use poison pointer to replace the hard-coded address Gao Xiang
2023-05-29 9:50 ` [PATCH 0/6] erofs: random cleanups and fixes Yue Hu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230530115912.0000195a.zbestahu@gmail.com \
--to=zbestahu@gmail.com \
--cc=hsiangkao@linux.alibaba.com \
--cc=huyue2@coolpad.com \
--cc=linux-erofs@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox