From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Prashanth K <quic_prashk@quicinc.com>
Cc: Matthias Brugger <matthias.bgg@gmail.com>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v6] usb: common: usb-conn-gpio: Set last role to unknown before initial detection
Date: Tue, 30 May 2023 15:28:19 +0100 [thread overview]
Message-ID: <2023053058-baffling-unveiling-e597@gregkh> (raw)
In-Reply-To: <1685421871-25391-1-git-send-email-quic_prashk@quicinc.com>
On Tue, May 30, 2023 at 10:14:31AM +0530, Prashanth K wrote:
> Currently if we bootup a device without cable connected, then
> usb-conn-gpio won't call set_role() since last_role is same as
> current role. This happens because during probe last_role gets
> initialised to zero.
>
> To avoid this, added a new constant in enum usb_role, last_role
> is set to USB_ROLE_UNKNOWN before performing initial detection.
>
> While at it, also handle default case for the usb_role switch
> in cdns3 to avoid build warnings.
>
> Fixes: 4602f3bff266 ("usb: common: add USB GPIO based connection detection driver")
> Signed-off-by: Prashanth K <quic_prashk@quicinc.com>
Breaks the build :(
Please be more careful when submitting stuff, especially on v6 of a
patch :(
next prev parent reply other threads:[~2023-05-30 14:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-30 4:44 [PATCH v6] usb: common: usb-conn-gpio: Set last role to unknown before initial detection Prashanth K
2023-05-30 7:09 ` AngeloGioacchino Del Regno
2023-05-30 14:28 ` Greg Kroah-Hartman [this message]
2023-05-30 15:26 ` Prashanth K
2023-05-30 16:43 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2023053058-baffling-unveiling-e597@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=angelogioacchino.delregno@collabora.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=quic_prashk@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox