From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: William Breathitt Gray <william.gray@linaro.org>
Cc: Vladislav Efanov <VEfanov@ispras.ru>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Rene Herman <rene.herman@keyaccess.nl>,
linux-kernel@vger.kernel.org, lvc-project@linuxtesting.org
Subject: Re: [PATCH] isa: Remove unnecessary checks
Date: Wed, 31 May 2023 19:03:26 +0100 [thread overview]
Message-ID: <2023053106-multitask-sultry-b4c8@gregkh> (raw)
In-Reply-To: <ZGbU7YQgzGelwiGy@fedora>
On Thu, May 18, 2023 at 09:46:21PM -0400, William Breathitt Gray wrote:
> On Wed, May 17, 2023 at 03:50:25PM +0300, Vladislav Efanov wrote:
> > The isa_dev->dev.platform_data is initialized with incoming
> > parameter isa_driver. After it isa_dev->dev.platform_data is
> > checked for NULL, but incoming parameter isa_driver is not
> > NULL since it is dereferenced many times before this check.
> >
> > Found by Linux Verification Center (linuxtesting.org) with SVACE.
> >
> > Fixes: a5117ba7da37 ("[PATCH] Driver model: add ISA bus")
> > Signed-off-by: Vladislav Efanov <VEfanov@ispras.ru>
>
> I don't think the Fixes line is needed because this is removing a
> superfluous check rather than fixing a bug. Regardless, here's my Ack
> for Greg as the patch itself makes sense.
>
> Acked-by: William Breathitt Gray <william.gray@linaro.org>
Yes, the Fixes line makes no sense at all. I'll delete it when
applying, thanks for the review.
greg k-h
prev parent reply other threads:[~2023-05-31 18:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-17 12:50 [PATCH] isa: Remove unnecessary checks Vladislav Efanov
2023-05-19 1:46 ` William Breathitt Gray
2023-05-31 18:03 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2023053106-multitask-sultry-b4c8@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=VEfanov@ispras.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=lvc-project@linuxtesting.org \
--cc=rafael@kernel.org \
--cc=rene.herman@keyaccess.nl \
--cc=william.gray@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox