Re: [PATCH RESEND 2/2] Bluetooth: fix use-bdaddr-property quirk

Luiz Augusto von Dentz
2023-06-01T23:43:27Z

Hi Johan,

On Thu, Jun 1, 2023 at 3:01 PM Marek Szyprowski
<m.szyprowski@samsung.com> wrote:
>
> On 31.05.2023 11:04, Johan Hovold wrote:
> > Devices that lack persistent storage for the device address can indicate
> > this by setting the HCI_QUIRK_INVALID_BDADDR which causes the controller
> > to be marked as unconfigured until user space has set a valid address.
> >
> > The related HCI_QUIRK_USE_BDADDR_PROPERTY was later added to similarly
> > indicate that the device lacks a valid address but that one may be
> > specified in the devicetree.
> >
> > As is clear from commit 7a0e5b15ca45 ("Bluetooth: Add quirk for reading
> > BD_ADDR from fwnode property") that added and documented this quirk and
> > commits like de79a9df1692 ("Bluetooth: btqcomsmd: use
> > HCI_QUIRK_USE_BDADDR_PROPERTY"), the device address of controllers with
> > this flag should be treated as invalid until user space has had a chance
> > to configure the controller in case the devicetree property is missing.
> >
> > As it does not make sense to allow controllers with invalid addresses,
> > restore the original semantics, which also makes sure that the
> > implementation is consistent (e.g. get_missing_options() indicates that
> > the address must be set) and matches the documentation (including
> > comments in the code, such as, "In case any of them is set, the
> > controller has to start up as unconfigured.").
> >
> > Fixes: e668eb1e1578 ("Bluetooth: hci_core: Don't stop BT if the BD address missing in dts")
> > Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
>
> This patch has been recently merged to linux-next as commit 6ac517d8cf8b
> ("Bluetooth: fix use-bdaddr-property quirk"). Unfortunately it breaks
> bluetooth operation on my Raspberry Pi 3b+, 4b+ and Khadas VIM3 based
> test systems.
>
> Before this patch on Raspberry Pi 4b+:
>
> root@target:~# dmesg | grep hci0
> [ 14.459292] Bluetooth: hci0: BCM: chip id 107
> [ 14.464283] Bluetooth: hci0: BCM: features 0x2f
> [ 14.470632] Bluetooth: hci0: BCM4345C0
> [ 14.474483] Bluetooth: hci0: BCM4345C0 (003.001.025) build 0000
> [ 14.487275] Bluetooth: hci0: BCM4345C0 'brcm/BCM4345C0.hcd' Patch
> [ 15.347542] Bluetooth: hci0: BCM: features 0x2f
> [ 15.354588] Bluetooth: hci0: BCM43455 37.4MHz Raspberry Pi 3+-0159
> [ 15.361076] Bluetooth: hci0: BCM4345C0 (003.001.025) build 0290
> root@target:~# hcitool dev
> Devices:
> hci0 DC:A6:32:12:38:D1
> root@target:~#
> root@target:~# hcitool scan
> Scanning ...
> 88:57:1D:AB:19:B2 Samsung Family Hub
> root@target:~# hcitool | head -n1
> hcitool - HCI Tool ver 5.50
> root@target:~#
>
>
> After this patch:
>
> root@target:~# dmesg | grep hci0
> [ 13.979860] Bluetooth: hci0: BCM: chip id 107
> [ 13.984969] Bluetooth: hci0: BCM: features 0x2f
> [ 13.991444] Bluetooth: hci0: BCM4345C0
> [ 13.995300] Bluetooth: hci0: BCM4345C0 (003.001.025) build 0000
> [ 14.005131] Bluetooth: hci0: BCM4345C0 'brcm/BCM4345C0.hcd' Patch
> [ 14.839465] Bluetooth: hci0: BCM: features 0x2f
> [ 14.846047] Bluetooth: hci0: BCM43455 37.4MHz Raspberry Pi 3+-0159
> [ 14.859859] Bluetooth: hci0: BCM4345C0 (003.001.025) build 0290
> root@target:~# hcitool dev
> Devices:
> root@target:~# hcitool scan
> Device is not available: No such device
> root@target:~# hcitool | head -n1
> hcitool - HCI Tool ver 5.50
> root@target:~#
>
> Reverting $subject on top of linux-next fixes this 'issue'.
>
> Let me know if you need more information about my test systems or to
> make some other tests.

Can you give it a look, looks like different manufacturers have
different expectations, anyway we should probably figure out a way to
get these controllers working otherwise we will need to revert.

--
Luiz Augusto von Dentz